Skip to content

Privtmpl - #566

Closed
pavanb018 wants to merge 7 commits into
apache:masterfrom
pavanb018:privtmpl
Closed

Privtmpl#566
pavanb018 wants to merge 7 commits into
apache:masterfrom
pavanb018:privtmpl

Conversation

@pavanb018

Copy link
Copy Markdown
Contributor

Comments provided in PR 241 are addressed and the commits for those are in this PR.

@asfbot

Copy link
Copy Markdown

cloudstack-pull-rats #17 FAILURE
Looks like there's a problem with this pull request

@DaanHoogland

Copy link
Copy Markdown
Contributor

@pavanb018 You will have to add license headers to the new files

@asfbot

Copy link
Copy Markdown

cloudstack-pull-requests #712 SUCCESS
This pull request looks good

@asfbot

Copy link
Copy Markdown

cloudstack-pull-rats #19 SUCCESS
This pull request looks good

@asfbot

Copy link
Copy Markdown

cloudstack-pull-requests #714 SUCCESS
This pull request looks good

@pavanb018

Copy link
Copy Markdown
ContributorAuthor

test_project_private_template (integration.component.test_project_template.TestProjectPrivateTemplate) ... === TestName: test_project_private_template | Status : SUCCESS ===
ok


Ran 1 test in 216.074s

OK

@pavanb018

Copy link
Copy Markdown
ContributorAuthor

On Basic Zone:

Test Deploy Virtual Machine ... === TestName: test_deploy_vm_with_tags | Status : SUCCESS ===
ok


Ran 1 test in 34.365s

OK

@pavanb018

Copy link
Copy Markdown
ContributorAuthor

On Advanced Zone:

Test Deploy Virtual Machine ... === TestName: test_deploy_vm_with_tags | Status : SUCCESS ===
ok


Ran 1 test in 120.020s

OK

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use validate list to validate list_volumes

@asfbot

Copy link
Copy Markdown

cloudstack-pull-rats #20 SUCCESS
This pull request looks good

@asfbot

Copy link
Copy Markdown

cloudstack-pull-rats #21 SUCCESS
This pull request looks good

@asfbot

Copy link
Copy Markdown

cloudstack-pull-requests #715 SUCCESS
This pull request looks good

@asfbot

Copy link
Copy Markdown

cloudstack-pull-requests #716 SUCCESS
This pull request looks good

@wido

wido commented Jul 17, 2015

Copy link
Copy Markdown
Contributor

I think it looks good? But it depends on earlier PR's I think since it's only a test

remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closesapache#577
This closesapache#566
This closesapache#562
This closesapache#561
This closesapache#556
This closesapache#555
This closesapache#554
This closesapache#548
This closesapache#544
This closesapache#540
This closesapache#508
This closesapache#384
This closesapache#372
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closesapache#577
This closesapache#566
This closesapache#562
This closesapache#561
This closesapache#556
This closesapache#555
This closesapache#554
This closesapache#548
This closesapache#544
This closesapache#540
This closesapache#384
This closesapache#372
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closesapache#577
This closesapache#566
This closesapache#562
This closesapache#561
This closesapache#556
This closesapache#555
This closesapache#554
This closesapache#548
This closesapache#544
This closesapache#540
This closesapache#384
This closesapache#372
@rodrigo93

Copy link
Copy Markdown
Contributor

Why does this PR still open? Shouldn't be closed? Seems that has been resolved already...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@pavanb018@asfbot@DaanHoogland@wido@rodrigo93@nitt10prashant