CLOUDSTACK-8605: KVM: Config Drive and getVmIp support

[kishankavala]

• CLOUDSTACK-8324 added support for External DHCP/DNS support along with ConfigDrive for XenServer
• FS link: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=53740797
• This PR adds KVM support for config drive and getVmIpAddress assigned by external DHCP
• genisoimage package dependency is added for creating config drive ISO
• libguestfs is used to get IPAddress from guest VM. Linux: From dhcp leases file. Windows: From registry

[asfbot]

cloudstack-pull-rats #33 ABORTED

[asfbot]

cloudstack-pull-requests #728 UNSTABLE
Looks like there's a problem with this pull request

[kishankavala]

/var/lib/libvirt/images is used for local storage also.
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource#configure
_localStoragePath = (String)params.get("local.storage.path");
if (_localStoragePath == null) {
_localStoragePath = "/var/lib/libvirt/images/";
}

I'll update the patch to use _localStoragePath instead of hard-coded /var/lib/libvirt/images

[yadvr]

you'll need to add this to other cloud.spec files in packages/{centos7,fedora20,fedora21}

[asfbot]

cloudstack-pull-rats #73 SUCCESS
This pull request looks good

[asfbot]

cloudstack-pull-requests #771 UNSTABLE
Looks like there's a problem with this pull request

[asfbot]

cloudstack-pull-analysis #6 UNSTABLE
Looks like there's a problem with this pull request

[kishankavala]

@wido@bhaisaab Made the suggested changes

[wido]

Code-wise I'm not to happy. There are all kinds of assumptions about paths. mkisofs for example always being there in /usr/bin.

Using /tmp for temporary directories, who says that /tmp is big enough on every system? Always using /var/lib/libvirt to place the ISO? Why not fetch the local storage pool and figure out what the path is.

It's not guaranteerd that it will be /var/lib/libvirt/images on all systems.

Imho there are to many assumptions in the code which makes it fragile.

[remibergsma]

@kishankavala Any update on this?

[kishankavala]

Updated code to use local.storage.path config instead of hard-coded /var/lib/libvirt/images/. Local Storage pool is also created using same config. Removed /usr/bin path for mkisofs.
Other issue was regarding using /tmp for temporary directories. Should I change this also to use local storage path?

[kishankavala]

@remibergsma I've update the PR. There is still one issue open regarding the usage of /tmp

[asfbot]

cloudstack-pull-rats #337 ABORTED

[asfbot]

cloudstack-pull-requests #1032 ABORTED

[asfbot]

cloudstack-pull-analysis #269 UNSTABLE
Looks like there's a problem with this pull request

[remibergsma]

@kishankavala Thanks for the update! When you're ready, also be sure to ping @wido so he can have another look.

[yadvr]

LGTM.

[yadvr]

maybe rebase and fix any issues, to get Travis green before merging this once @wido can review this.

[asfbot]

cloudstack-pull-rats #540 SUCCESS
This pull request looks good

[asfbot]

cloudstack-pull-analysis #474 SUCCESS
This pull request looks good

[remibergsma]

@kishankavala Please remove the 4 merge commits, thanks.

[asfbot]

cloudstack-pull-rats #640 SUCCESS
This pull request looks good

[asfbot]

cloudstack-pull-analysis #579 ABORTED

[asfbot]

cloudstack-pull-analysis #585 SUCCESS
This pull request looks good

[remibergsma]

@kishankavala There are 5 merge commits now... please remove them.