Skip to content

CLOUDSTACK-8602. MigrateVirtualMachineWithVolume leaves old chain dat… - #548

Closed
likitha wants to merge 1 commit into
apache:masterfrom
likitha:CLOUDSTACK-8602
Closed

CLOUDSTACK-8602. MigrateVirtualMachineWithVolume leaves old chain dat…#548
likitha wants to merge 1 commit into
apache:masterfrom
likitha:CLOUDSTACK-8602

Conversation

@likitha

Copy link
Copy Markdown

…a for volume.

Update chain info of a volume after migration.

…a for volume.
Update chain info of a volume after migration.
@asfbot

Copy link
Copy Markdown

cloudstack-pull-requests #681 SUCCESS
This pull request looks good

@sateesh-chodapuneedi

Copy link
Copy Markdown
Member

LGTM.
Good to see this patch updating chain information for all 3 cases of storage migration,

  1. volume migration
  2. vm migration with storage within cluster
  3. vm migration across storage within cluster

@sureshanaparti

Copy link
Copy Markdown
Contributor

Code changes to update the volume chain info are perfect.

@DaanHoogland

Copy link
Copy Markdown
Contributor

code changes good or not, let's not accept any changes without (unit) tests any more.

@remibergsma

Copy link
Copy Markdown
Contributor

Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-).

remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closesapache#577
This closesapache#566
This closesapache#562
This closesapache#561
This closesapache#556
This closesapache#555
This closesapache#554
This closesapache#548
This closesapache#544
This closesapache#540
This closesapache#508
This closesapache#384
This closesapache#372
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closesapache#577
This closesapache#566
This closesapache#562
This closesapache#561
This closesapache#556
This closesapache#555
This closesapache#554
This closesapache#548
This closesapache#544
This closesapache#540
This closesapache#384
This closesapache#372
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
This closesapache#577
This closesapache#566
This closesapache#562
This closesapache#561
This closesapache#556
This closesapache#555
This closesapache#554
This closesapache#548
This closesapache#544
This closesapache#540
This closesapache#384
This closesapache#372
@yadvr

Copy link
Copy Markdown
Member

LGTM

yadvr pushed a commit that referenced this pull request Jan 20, 2021
…age creation Forms (#548)
Add storage policies field for DiskOffering, COmputeOffering and Primary storage creation Forms
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@likitha@asfbot@sateesh-chodapuneedi@sureshanaparti@DaanHoogland@remibergsma@yadvr