HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker…

[wchevreuil]

… is set in global config

[Apache9]

In general I do not like that we introduce a new init method but do not call it when verifying...

I think we should try to provide more things when constructing the StoreFileTracker. The current implementations are already lazy enough as we do not actually touch the storage, we just create some in memory objects...

So why not just pass in a RegionFileSystem for this case? Just like what we have done in the split/merge procedures.

 /**
* Used at master side when splitting/merging regions, as we do not have a Store, thus no
* StoreContext at master side.
*/
public static StoreFileTracker create(Configuration conf, TableDescriptor td,
ColumnFamilyDescriptor cfd, HRegionFileSystem regionFs) {
StoreContext ctx =
StoreContext.getBuilder().withColumnFamilyDescriptor(cfd).withRegionFileSystem(regionFs)
.withFamilyStoreDirectoryPath(regionFs.getStoreDir(cfd.getNameAsString())).build();
return StoreFileTrackerFactory.create(mergeConfigurations(conf, td, cfd), true, ctx);
}

Thanks.

[wchevreuil]

In general I do not like that we introduce a new init method but do not call it when verifying...

It's a mean to separate instantiation of SFT impls, from actual init logic. In this particular case, we need SFT impl specific logic about setting configs before we can effectively start a SFT tracker properly.

I think we should try to provide more things when constructing the StoreFileTracker. The current implementations are already lazy enough as we do not actually touch the storage, we just create some in memory objects...

So why not just pass in a RegionFileSystem for this case? Just like what we have done in the split/merge procedures.

 /**
* Used at master side when splitting/merging regions, as we do not have a Store, thus no
* StoreContext at master side.
*/
public static StoreFileTracker create(Configuration conf, TableDescriptor td,
ColumnFamilyDescriptor cfd, HRegionFileSystem regionFs) {
StoreContext ctx =
StoreContext.getBuilder().withColumnFamilyDescriptor(cfd).withRegionFileSystem(regionFs)
.withFamilyStoreDirectoryPath(regionFs.getStoreDir(cfd.getNameAsString())).build();
return StoreFileTrackerFactory.create(mergeConfigurations(conf, td, cfd), true, ctx);
}

Thanks.

We don't have store info at CreateTable procedure time, we don't even have the regions yet by then, so how can we create a RegionFileSystem?

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 36s	HBASE-26067 passed
+1 💚	compile	3m 42s	HBASE-26067 passed
+1 💚	checkstyle	1m 13s	HBASE-26067 passed
+1 💚	spotbugs	2m 19s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 12s	the patch passed
+1 💚	compile	3m 36s	the patch passed
+1 💚	javac	3m 36s	the patch passed
+1 💚	checkstyle	1m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 59s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 30s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		54m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3721
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux f5fbd9c17ac5 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / ab03ee1
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	5m 3s	HBASE-26067 passed
+1 💚	compile	1m 20s	HBASE-26067 passed
+1 💚	shadedjars	9m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 49s	the patch passed
+1 💚	compile	1m 22s	the patch passed
+1 💚	javac	1m 22s	the patch passed
+1 💚	shadedjars	9m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
-1 ❌	unit	215m 21s	hbase-server in the patch failed.
		255m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3721
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c1d09c78fdaf 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / ab03ee1
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/1/testReport/
Max. process+thread count	3213 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 24s	HBASE-26067 passed
+1 💚	compile	1m 5s	HBASE-26067 passed
+1 💚	shadedjars	9m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 10s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	9m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	222m 10s	hbase-server in the patch passed.
		256m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3721
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 818e07fa20ea 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / ab03ee1
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/1/testReport/
Max. process+thread count	3260 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

We don't have store info at CreateTable procedure time, we don't even have the regions yet by then, so how can we create a RegionFileSystem?

Yes, this is a problem. In the first place I thought maybe we could just create a default region and then create a region file system, but it seems to tricky and a bit ugly. So we should let the implementation class to know this. A possible way is to pass in a null StoreContext, and the implementation class should check whether the StoreContext is null, if so, then it should construct itself in the 'persist store tracker configurations' mode.

Or another possible way is to force every store file tracker implementation has a static method, for persisting the store file tracker configurations. We could have separated logic in this method, so normal code path does not need to deal with null StoreContext.

I think the latter one will be cleaner but not sure if we can force the implementation class has a static method at compile time. But at least, we could introduce a UT for checking this.

WDYT? Thanks.

[wchevreuil]

A possible way is to pass in a null StoreContext, and the implementation class should check whether the StoreContext is null, if so, then it should construct itself in the 'persist store tracker configurations' mode.

That could be an option, despite looking a bit hacky. Alternatively, we could ensure init() is called prior to start adding/loading/replacing store files. WDYT?

I think the latter one will be cleaner but not sure if we can force the implementation class has a static method at compile time.

That was exactly my first idea, but the lack of enforcement of static methods on implementations is a problem, IMO, which led me to the alternative solution.

But at least, we could introduce a UT for checking this.
I believe the UT I had added would catch this problem.

[Apache9]

The UT I mean is to check whether we have the static method for each implementation class. This is possible.
I could provide an example later.

I think this will be cleaner way. I also want to introduce a init method in the past when implementing migration store file tracker, as we will not always call load when migrating, but finally I just added a check in the StoreFileListFile, to avoid adding extra methods. For me I prefer we keep the interface simple, unless there are no other choices.

WDYT?

Thanks.

[wchevreuil]

I'm sorry @Apache9 , but why did you force push all these commits into the branch? I believe it had no conflicts with HBASE-26067 before.

[Apache9]

I just rebased HBASE-26067 against the newest master branch, and seems GitHub can not identify this type of rebase so it will show all the commits in the PR. You can do a cherry-pick to the newest HBASE-26067 and then do a force push to your branch.

Sorry for the inconvenience. In the future I will shout before doing the rebase to let others know.

[wchevreuil]

I just rebased HBASE-26067 against the newest master branch, and seems GitHub can not identify this type of rebase so it will show all the commits in the PR. You can do a cherry-pick to the newest HBASE-26067 and then do a force push to your branch.

Sorry for the inconvenience. In the future I will shout before doing the rebase to let others know.

No problem, just wanted to make sure on the reason. Let me do the cherry-pick.

[wchevreuil]

I'm not sure why github is showing all these additional commits, it should have the option to rebase.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 7s	HBASE-26067 passed
+1 💚	compile	3m 26s	HBASE-26067 passed
+1 💚	checkstyle	1m 0s	HBASE-26067 passed
+1 💚	spotbugs	2m 2s	HBASE-26067 passed
-0 ⚠️	patch	2m 11s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	3m 9s	the patch passed
+1 💚	javac	3m 9s	the patch passed
-0 ⚠️	checkstyle	1m 3s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 17s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		47m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3721
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux cece6ab30775 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / c4d7d28
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/8/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/8/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 59s	HBASE-26067 passed
+1 💚	compile	1m 21s	HBASE-26067 passed
+1 💚	shadedjars	9m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	HBASE-26067 passed
-0 ⚠️	patch	10m 6s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 32s	the patch passed
+1 💚	compile	1m 18s	the patch passed
+1 💚	javac	1m 18s	the patch passed
+1 💚	shadedjars	8m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	148m 41s	hbase-server in the patch passed.
		182m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3721
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 24a43b82013b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / c4d7d28
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/8/testReport/
Max. process+thread count	4109 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/8/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[joshelser]

Seems reasonable enough to me, but you two are much more down in the weeds than I.

[joshelser]

Maybe buildWithTrackerConfigs if you're returning the TableDescriptor instead of the TableDescriptorBuilder. IMO, i'd just return the Builder back and let the caller build() when they're ready.

[wchevreuil]

IMO, i'd just return the Builder back and let the caller build() when they're ready.

Yeah, I guess that would be better. WDYT, @Apache9 ?

[Apache9]

Just return void is enough. The upper layer could build it after calling this method.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	5m 30s	HBASE-26067 passed
+1 💚	compile	1m 29s	HBASE-26067 passed
+1 💚	shadedjars	9m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	HBASE-26067 passed
-0 ⚠️	patch	10m 38s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 14s	the patch passed
+1 💚	compile	1m 29s	the patch passed
+1 💚	javac	1m 29s	the patch passed
+1 💚	shadedjars	9m 42s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	the patch passed
		_ Other Tests _
+1 💚	unit	229m 6s	hbase-server in the patch passed.
		267m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/16/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3721
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b09f1fcf50ef 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / c4d7d28
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/16/testReport/
Max. process+thread count	3220 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/16/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache9]

OVerall LGTM.

The only thing is what Josh proposed, let's not return TableDescriptor for StoreFileTracker.updateWithTrackConfigs.

Thanks @wchevreuil for your patience.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 40s	HBASE-26067 passed
+1 💚	compile	4m 20s	HBASE-26067 passed
+1 💚	checkstyle	1m 21s	HBASE-26067 passed
+1 💚	spotbugs	2m 38s	HBASE-26067 passed
-0 ⚠️	patch	2m 48s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 1s	the patch passed
+1 💚	compile	4m 7s	the patch passed
+1 💚	javac	4m 7s	the patch passed
-0 ⚠️	checkstyle	1m 25s	hbase-server: The patch generated 5 new + 3 unchanged - 0 fixed = 8 total (was 3)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	24m 54s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		62m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/17/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3721
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux a60898d456e1 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / c4d7d28
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/17/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/17/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[joshelser]

Thanks for changing the TD->TDBuilder method return type! And thank you Duo for your continued help on reviews.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	5m 41s	HBASE-26067 passed
+1 💚	compile	1m 34s	HBASE-26067 passed
+1 💚	shadedjars	10m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 48s	HBASE-26067 passed
-0 ⚠️	patch	11m 19s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 43s	the patch passed
+1 💚	compile	1m 37s	the patch passed
+1 💚	javac	1m 37s	the patch passed
+1 💚	shadedjars	11m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	the patch passed
		_ Other Tests _
+1 💚	unit	153m 22s	hbase-server in the patch passed.
		193m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/17/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3721
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9dc663f47ebb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / c4d7d28
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/17/testReport/
Max. process+thread count	4119 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/17/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 18s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 17s	HBASE-26067 passed
+1 💚	compile	1m 4s	HBASE-26067 passed
+1 💚	shadedjars	9m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	HBASE-26067 passed
-0 ⚠️	patch	10m 2s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 8s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	9m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	220m 33s	hbase-server in the patch passed.
		253m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/17/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3721
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bafde08461d1 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / c4d7d28
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/17/testReport/
Max. process+thread count	3316 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3721/17/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.