HBASE-26454 CreateTableProcedure still relies on temp dir and renames… by wchevreuil · Pull Request #3845 · apache/hbase

wchevreuil · 2021-11-12T16:46:26Z

… when creating table FS layout

… when creating table FS layout Change-Id: I891a483d7e4e585ffea28b2b19188807bbb09f85

Apache-HBase · 2021-11-12T17:41:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 33s	HBASE-26067 passed
+1 💚	compile	3m 29s	HBASE-26067 passed
+1 💚	checkstyle	1m 11s	HBASE-26067 passed
+1 💚	spotbugs	2m 15s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 14s	the patch passed
+1 💚	compile	3m 24s	the patch passed
+1 💚	javac	3m 24s	the patch passed
-0 ⚠️	checkstyle	1m 12s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 36s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 23s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		54m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 6881b11b84d0 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-12T20:58:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	5m 19s	HBASE-26067 passed
+1 💚	compile	1m 21s	HBASE-26067 passed
+1 💚	shadedjars	9m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 3s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	shadedjars	9m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	the patch passed
		_ Other Tests _
-1 ❌	unit	215m 15s	hbase-server in the patch failed.
		251m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 95a590ed7572 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/testReport/
Max. process+thread count	2969 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-12T21:05:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 41s	HBASE-26067 passed
+1 💚	compile	1m 5s	HBASE-26067 passed
+1 💚	shadedjars	9m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 26s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	9m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
-1 ❌	unit	223m 27s	hbase-server in the patch failed.
		257m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7444e9421c12 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/testReport/
Max. process+thread count	3246 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser

Thanks for fixing this, Wellington. Looks like it matches CloneSnapshotProcedure as we'd expect.

It seems like org.apache.hadoop.hbase.master.TestMasterFileSystem.testCheckTempDir might be failing though. +1 when QA is happy.

Apache9

Do we need to implement rollback where we will delete the partial table directory?

wchevreuil · 2021-11-16T10:54:13Z

Do we need to implement rollback where we will delete the partial table directory?

We already delete pre-existing table dir on line on line #104.

Apache9 · 2021-11-16T10:59:15Z

Do we need to implement rollback where we will delete the partial table directory?
We already delete pre-existing table dir on line on line #104.

This is not the same thing, it is not about retry but about how to clean up the storage when the CreateTableProcedure fails.

But checked the code, we do not support rollback when we already arrive the WRITE_FS_LAYOUT state, so it should not be a problem.

Apache9 · 2021-11-16T11:14:01Z

The failed UT is related?

TestMasterFileSystem.testCheckTempDir

wchevreuil · 2021-11-16T11:50:31Z

The failed UT is related?
TestMasterFileSystem.testCheckTempDir

Yes, it's failing because it can't rename tabledir to temp:

...
2021-11-16T11:45:56,209 WARN [IPC Server handler 3 on 50183] namenode.FSDirRenameOp(182): DIR* FSDirectory.unprotectedRenameTo: failed to rename /user/wellingtonchevreuil/test-data/577b1635-a2e9-6d2d-0e93-e72c07fd3ba7/data/default/testCheckTempDir to /user/wellingtonchevreuil/test-data/577b1635-a2e9-6d2d-0e93-e72c07fd3ba7/.tmp/data/default/testCheckTempDir because destination's parent does not exist
...

I think this UT is invalid now that we don't need table temp dir. I'm gonna change it to reflect the current behaviour.

wchevreuil · 2021-11-16T11:53:03Z

Do we need to implement rollback where we will delete the partial table directory?
We already delete pre-existing table dir on line on line #104.
This is not the same thing, it is not about retry but about how to clean up the storage when the CreateTableProcedure fails.
But checked the code, we do not support rollback when we already arrive the WRITE_FS_LAYOUT state, so it should not be a problem.

Yeah, thought about adding a rollback logic here, but then thought it wouldn't be necessary as we do the check/cleanup every time in the beginning of the proc.

Apache9 · 2021-11-16T15:15:42Z

The failed UT is related?
TestMasterFileSystem.testCheckTempDir
Yes, it's failing because it can't rename tabledir to temp:
... 2021-11-16T11:45:56,209 WARN [IPC Server handler 3 on 50183] namenode.FSDirRenameOp(182): DIR* FSDirectory.unprotectedRenameTo: failed to rename /user/wellingtonchevreuil/test-data/577b1635-a2e9-6d2d-0e93-e72c07fd3ba7/data/default/testCheckTempDir to /user/wellingtonchevreuil/test-data/577b1635-a2e9-6d2d-0e93-e72c07fd3ba7/.tmp/data/default/testCheckTempDir because destination's parent does not exist ...
I think this UT is invalid now that we don't need table temp dir. I'm gonna change it to reflect the current behaviour.

Checked the usage, there are 3 places where we use it, in CreateTableProcedure, CloneSnapshotProcedure and DeleteTableProcedure.deleteFromFs. Since now we do not use temp directory for all these procedures any more, I think we could just remove this temp dir in MasterFileSystem?

wchevreuil · 2021-11-16T17:16:53Z

- assertTrue(fs.exists(archiveDir));
- }
+ // checks the temporary directory does not exist
+ assertFalse(fs.exists(tempNsDir));


We now make sure no temp dir was created for table namespace during the CreateTableProcedure run.

wchevreuil · 2021-11-16T17:24:12Z

The failed UT is related?
TestMasterFileSystem.testCheckTempDir
Yes, it's failing because it can't rename tabledir to temp:
... 2021-11-16T11:45:56,209 WARN [IPC Server handler 3 on 50183] namenode.FSDirRenameOp(182): DIR* FSDirectory.unprotectedRenameTo: failed to rename /user/wellingtonchevreuil/test-data/577b1635-a2e9-6d2d-0e93-e72c07fd3ba7/data/default/testCheckTempDir to /user/wellingtonchevreuil/test-data/577b1635-a2e9-6d2d-0e93-e72c07fd3ba7/.tmp/data/default/testCheckTempDir because destination's parent does not exist ...
I think this UT is invalid now that we don't need table temp dir. I'm gonna change it to reflect the current behaviour.
Checked the usage, there are 3 places where we use it, in CreateTableProcedure, CloneSnapshotProcedure and DeleteTableProcedure.deleteFromFs. Since now we do not use temp directory for all these procedures any more, I think we could just remove this temp dir in MasterFileSystem?

I think DeleteTableProcedure.deleteFromFs is still relying on temp dir. Let me change it.

Apache-HBase · 2021-11-16T18:10:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 25s	HBASE-26067 passed
+1 💚	compile	3m 32s	HBASE-26067 passed
+1 💚	checkstyle	1m 5s	HBASE-26067 passed
+1 💚	spotbugs	2m 14s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 3s	the patch passed
+1 💚	compile	3m 32s	the patch passed
+1 💚	javac	3m 32s	the patch passed
-0 ⚠️	checkstyle	1m 11s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 42s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 27s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		55m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux ff9ff720354f 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-16T20:19:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 51s	HBASE-26067 passed
+1 💚	compile	1m 15s	HBASE-26067 passed
+1 💚	shadedjars	8m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 35s	the patch passed
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
+1 💚	shadedjars	8m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	150m 24s	hbase-server in the patch passed.
		183m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux af54e9b41723 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/2/testReport/
Max. process+thread count	4098 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-16T20:36:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 29s	HBASE-26067 passed
+1 💚	compile	1m 8s	HBASE-26067 passed
+1 💚	shadedjars	8m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 10s	the patch passed
+1 💚	compile	1m 7s	the patch passed
+1 💚	javac	1m 7s	the patch passed
+1 💚	shadedjars	8m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	167m 22s	hbase-server in the patch passed.
		199m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1a65de5b5288 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/2/testReport/
Max. process+thread count	4944 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: Iff9d6121220200fb1a0a3bc4ee16e7476f508e3a temp Change-Id: I9d2fdf99a98498e12408dcddaf40f4e48e6a65d2

Apache-HBase · 2021-11-17T13:56:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 17s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 16s	HBASE-26067 passed
+1 💚	compile	3m 19s	HBASE-26067 passed
+1 💚	checkstyle	1m 7s	HBASE-26067 passed
+1 💚	spotbugs	2m 28s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 55s	the patch passed
+1 💚	compile	3m 18s	the patch passed
+1 💚	javac	3m 18s	the patch passed
-0 ⚠️	checkstyle	1m 15s	hbase-server: The patch generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0)
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	hadoopcheck	21m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 41s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		56m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux fc60184b359d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-17T17:21:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	6m 16s	HBASE-26067 passed
+1 💚	compile	1m 36s	HBASE-26067 passed
+1 💚	shadedjars	10m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 3s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 50s	the patch passed
+1 💚	compile	1m 38s	the patch passed
+1 💚	javac	1m 38s	the patch passed
+1 💚	shadedjars	11m 14s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 50s	the patch passed
		_ Other Tests _
-1 ❌	unit	218m 37s	hbase-server in the patch failed.
		261m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 47bcb02dc0f7 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/testReport/
Max. process+thread count	3256 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-17T17:50:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	5m 9s	HBASE-26067 passed
+1 💚	compile	1m 13s	HBASE-26067 passed
+1 💚	shadedjars	9m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 45s	the patch passed
+1 💚	compile	1m 14s	the patch passed
+1 💚	javac	1m 14s	the patch passed
+1 💚	shadedjars	9m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	the patch passed
		_ Other Tests _
-1 ❌	unit	250m 56s	hbase-server in the patch failed.
		289m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ff985926c1b2 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/testReport/
Max. process+thread count	3741 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: I312b0e5b77ec6012493f5dbb921f3333bdf1b503

wchevreuil · 2021-11-18T13:56:56Z

 */
 List<Path> getTableRootPaths(TableName tableName, boolean includeSnapshotPath)
 throws IOException {
- List<Path> paths = Lists.newArrayList(pathHelper.getTmpTableDir(tableName),


Found out this was creating table tmp dir on CreateTableProcedure.CREATE_TABLE_POST_OPERATION when ACL is enabled.

Apache-HBase · 2021-11-18T14:45:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	3m 58s	HBASE-26067 passed
+1 💚	compile	3m 11s	HBASE-26067 passed
+1 💚	checkstyle	1m 3s	HBASE-26067 passed
+1 💚	spotbugs	2m 8s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 46s	the patch passed
+1 💚	compile	3m 10s	the patch passed
+1 💚	javac	3m 10s	the patch passed
-0 ⚠️	checkstyle	1m 6s	hbase-server: The patch generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0)
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	hadoopcheck	19m 24s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 17s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		49m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 5ad8675cd2bb 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/4/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-18T18:03:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	5m 13s	HBASE-26067 passed
+1 💚	compile	1m 19s	HBASE-26067 passed
+1 💚	shadedjars	9m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 2s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	shadedjars	9m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	212m 26s	hbase-server in the patch passed.
		248m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d449db9f1636 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/4/testReport/
Max. process+thread count	2939 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-18T18:42:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	5m 25s	HBASE-26067 passed
+1 💚	compile	1m 16s	HBASE-26067 passed
+1 💚	shadedjars	9m 55s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 46s	the patch passed
+1 💚	compile	1m 14s	the patch passed
+1 💚	javac	1m 14s	the patch passed
+1 💚	shadedjars	9m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	247m 29s	hbase-server in the patch passed.
		285m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3845
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 441d9e70c035 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `36b6088`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/4/testReport/
Max. process+thread count	3779 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: I39e38a58c676b51fb47c7377acc3575d5e30198d

Apache-HBase · 2021-11-19T12:17:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 4s	#3845 does not apply to HBASE-26067. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#3845
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/5/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-19T12:17:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 3s	#3845 does not apply to HBASE-26067. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#3845
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/5/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-19T12:18:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	patch	0m 4s	#3845 does not apply to HBASE-26067. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem	Report/Notes
GITHUB PR	#3845
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3845/5/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

apache#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <elserj@apache.org> Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>

#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9HBASE-25988 Store the store file list by a file #3578) commit 6e05376HBASE-26079 Use StoreFileTracker when splitting and merging #3617) commit 090b2feHBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656) commit 0ee1689HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666) commit 2052e80HBASE-26248 Should find a suitable way to let users specify the store… #3665) commit 5ff0f98HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681) commit fc4f6d1HBASE-26280 HBASE-26280 Use store file tracker when snapshoting #3685) commit 06db852HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721) commit e4e7cf8HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774) commit 08d1171HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749) commit 8bec26eHBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700) commit a288365HBASE-26271: Cleanup the broken store files under data directory #3786) commit d00b5faHBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845) commit 771e552HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1HBASE-26265 Update ref guide to mention the new store file tracker im… #3942) commit 755b3b4HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998) commit 39c42c7HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010) commit 6e1f5b7HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006) commit f1dd865HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034) commit 8fbc9a2HBASE-26674 Should modify filesCompacting under storeWriteLock #4040) commit 5aa0fd2HBASE-26675 Data race on Compactor.writer #4035) commit 3021c58HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055) commit a8b68c9HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054) commit dffeb8eHBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080) commit b265fe5HBASE-26673 Implement a shell command for change SFT implementation #4113) commit 4cdb380HBASE-26640 Reimplement master local region initialization to better … #4111) commit 77bb153HBASE-26707: Reduce number of renames during bulkload (#4066) #4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082) commit d3629bbHBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226) commit 541d748HBASE-26881 Backport HBASE-25368 to branch-2 (#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <elserj@apache.org> Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>

apache#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org> Change-Id: I029bf5061620ea236456dbac4b8897b8ad94c202

HBASE-26454 CreateTableProcedure still relies on temp dir and renames…
5847e93
… when creating table FS layout Change-Id: I891a483d7e4e585ffea28b2b19188807bbb09f85

wchevreuil requested review from Apache9, joshelser and saintstack November 12, 2021 16:46

joshelser reviewed Nov 13, 2021
View reviewed changes

Apache9 reviewed Nov 13, 2021
View reviewed changes

Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java Outdated

Apache9 approved these changes Nov 16, 2021
View reviewed changes

wchevreuil commented Nov 16, 2021
View reviewed changes

adjusting TestMasterFileSystem UTs
22b207f
Change-Id: Iff9d6121220200fb1a0a3bc4ee16e7476f508e3a temp Change-Id: I9d2fdf99a98498e12408dcddaf40f4e48e6a65d2

wchevreuil force-pushed the HBASE-26454 branch from f6c0658 to 22b207fCompare November 17, 2021 12:59

fixing UT failure
c2a4db6
Change-Id: I312b0e5b77ec6012493f5dbb921f3333bdf1b503

wchevreuil commented Nov 18, 2021
View reviewed changes

Apache9 approved these changes Nov 18, 2021
View reviewed changes

fixing checkstyles and whitespaces
97f4969
Change-Id: I39e38a58c676b51fb47c7377acc3575d5e30198d

wchevreuil merged commit 0ad3556 into apache:HBASE-26067Nov 19, 2021

Apache9 pushed a commit that referenced this pull request Nov 27, 2021
HBASE-26454CreateTableProcedure still relies on temp dir and renames… (
d24e09d
#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Apache9 pushed a commit that referenced this pull request Dec 6, 2021
HBASE-26454CreateTableProcedure still relies on temp dir and renames… (
4aa3f47
#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Apache9 pushed a commit that referenced this pull request Dec 17, 2021
HBASE-26454CreateTableProcedure still relies on temp dir and renames… (
d00bb63
#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

asfgit pushed a commit that referenced this pull request Dec 22, 2021
HBASE-26454CreateTableProcedure still relies on temp dir and renames… (
d00b5fa
#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Apache9 pushed a commit that referenced this pull request Jan 1, 2022
HBASE-26454CreateTableProcedure still relies on temp dir and renames… (
79fb093
#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Apache9 pushed a commit that referenced this pull request Jan 2, 2022
HBASE-26454CreateTableProcedure still relies on temp dir and renames… (
b3c61ef
#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Apache9 pushed a commit that referenced this pull request Jan 2, 2022
HBASE-26454CreateTableProcedure still relies on temp dir and renames… (
ff45cbf
#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

Apache9 pushed a commit that referenced this pull request Jan 4, 2022
HBASE-26454CreateTableProcedure still relies on temp dir and renames… (
48e2891
#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 18, 2022
HBASE-26454 CreateTableProcedure still relies on temp dir and renames… (
d99e284
apache#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

apurtell mentioned this pull request Mar 18, 2022
Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5 #4241
Merged

apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 19, 2022
HBASE-26454 CreateTableProcedure still relies on temp dir and renames… (
4cd78b8
apache#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 25, 2022
HBASE-26454 CreateTableProcedure still relies on temp dir and renames… (
0c1c094
apache#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
HBASE-26454 CreateTableProcedure still relies on temp dir and renames… (
062ee1d
apache#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

apurtell pushed a commit that referenced this pull request Mar 26, 2022
HBASE-26454CreateTableProcedure still relies on temp dir and renames… (
6a794e3
#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org>

vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
HBASE-26454 CreateTableProcedure still relies on temp dir and renames… (
4647f5c
apache#3845) Signed-off-by: Duo Zhang <zhangduo@apache.org> Change-Id: I029bf5061620ea236456dbac4b8897b8ad94c202

Uh oh!

Conversation

wchevreuil commented Nov 12, 2021

Uh oh!

Apache-HBase commented Nov 12, 2021

Uh oh!

Apache-HBase commented Nov 12, 2021

Uh oh!

Apache-HBase commented Nov 12, 2021

Uh oh!

joshelser left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wchevreuil commented Nov 16, 2021

Uh oh!

Apache9 commented Nov 16, 2021

Uh oh!

Apache9 commented Nov 16, 2021

Uh oh!

wchevreuil commented Nov 16, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wchevreuil commented Nov 16, 2021

Uh oh!

Apache9 commented Nov 16, 2021

Uh oh!

wchevreuilNov 16, 2021

Choose a reason for hiding this comment

Uh oh!

wchevreuil commented Nov 16, 2021

Uh oh!

Apache-HBase commented Nov 16, 2021

Uh oh!

Apache-HBase commented Nov 16, 2021

Uh oh!

Apache-HBase commented Nov 16, 2021

Uh oh!

Apache-HBase commented Nov 17, 2021

Uh oh!

Apache-HBase commented Nov 17, 2021

Uh oh!

Apache-HBase commented Nov 17, 2021

Uh oh!

wchevreuilNov 18, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Apache-HBase commented Nov 18, 2021

Uh oh!

Apache-HBase commented Nov 18, 2021

Uh oh!

Apache-HBase commented Nov 18, 2021

Uh oh!

Apache-HBase commented Nov 19, 2021

Uh oh!

Apache-HBase commented Nov 19, 2021

Uh oh!

Apache-HBase commented Nov 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wchevreuil commented Nov 16, 2021•
edited
Loading

wchevreuilNov 18, 2021•
edited
Loading