Skip to content

HBASE-26280 Use store file tracker when snapshoting - #3685

Merged
Apache9 merged 1 commit into
apache:HBASE-26067from
Apache9:HBASE-26280
Sep 17, 2021
Merged

HBASE-26280 Use store file tracker when snapshoting#3685
Apache9 merged 1 commit into
apache:HBASE-26067from
Apache9:HBASE-26280

Conversation

@Apache9

@Apache9Apache9 commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@Apache9Apache9 self-assigned this Sep 15, 2021
@Apache9

Apache9 commented Sep 15, 2021

Copy link
Copy Markdown
ContributorAuthor

There is a TODO in the code for adding support for mob test. It is too late in China so I have to go to sleep...

Will address it tomorrow.

@Apache-HBase

Apache-HBase commented Sep 15, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 14sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 24sHBASE-26067 passed
+1 💚compile1m 3sHBASE-26067 passed
+1 💚shadedjars9m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 7sthe patch passed
+1 💚compile1m 4sthe patch passed
+1 💚javac1m 4sthe patch passed
+1 💚shadedjars9m 2spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
-1 ❌unit11m 4shbase-server in the patch failed.
43m 40s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3685
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 25f372d914d3 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/testReport/
Max. process+thread count642 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 15, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 55sHBASE-26067 passed
+1 💚compile1m 17sHBASE-26067 passed
+1 💚shadedjars10m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 48sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 53sthe patch passed
+1 💚compile1m 29sthe patch passed
+1 💚javac1m 29sthe patch passed
+1 💚shadedjars9m 37spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43sthe patch passed
_ Other Tests _
-1 ❌unit9m 42shbase-server in the patch failed.
45m 30s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3685
Optional Testsjavac javadoc unit shadedjars compile
unameLinux eab431529f52 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/testReport/
Max. process+thread count743 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 15, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 2sHBASE-26067 passed
+1 💚compile3m 15sHBASE-26067 passed
+1 💚checkstyle1m 5sHBASE-26067 passed
+1 💚spotbugs2m 13sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 41sthe patch passed
+1 💚compile3m 16sthe patch passed
-0 ⚠️javac3m 16shbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
-0 ⚠️checkstyle1m 5shbase-server: The patch generated 5 new + 47 unchanged - 0 fixed = 52 total (was 47)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck18m 26sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs2m 17sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
47m 44s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3685
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux c30ec2849633 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser
joshelser reviewed Sep 15, 2021
View reviewed changes

@joshelserjoshelser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you have the MOB stuff pending, but this looks great so far. Nice and simple given the approach.

@Apache-HBase

Apache-HBase commented Sep 16, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-26067 Compile Tests _
+1 💚mvninstall3m 46sHBASE-26067 passed
+1 💚compile3m 11sHBASE-26067 passed
+1 💚checkstyle1m 3sHBASE-26067 passed
+1 💚spotbugs2m 2sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 39sthe patch passed
+1 💚compile3m 9sthe patch passed
+1 💚javac3m 9sthe patch passed
-0 ⚠️checkstyle1m 3shbase-server: The patch generated 1 new + 74 unchanged - 4 fixed = 75 total (was 78)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck18m 9sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs2m 15sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
46m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3685
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 92d0399c94d4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 16, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚mvninstall5m 17sHBASE-26067 passed
+1 💚compile1m 19sHBASE-26067 passed
+1 💚shadedjars9m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 45sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 58sthe patch passed
+1 💚compile1m 19sthe patch passed
+1 💚javac1m 19sthe patch passed
+1 💚shadedjars9m 7spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 42sthe patch passed
_ Other Tests _
-1 ❌unit231m 6shbase-server in the patch failed.
267m 11s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3685
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d79457c0a2d3 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/testReport/
Max. process+thread count3366 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 16, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 1sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 49sHBASE-26067 passed
+1 💚compile1m 19sHBASE-26067 passed
+1 💚shadedjars10m 54sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 48sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall5m 24sthe patch passed
+1 💚compile1m 26sthe patch passed
+1 💚javac1m 26sthe patch passed
+1 💚shadedjars10m 23spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 48sthe patch passed
_ Other Tests _
-1 ❌unit257m 6shbase-server in the patch failed.
297m 52s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3685
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 77c625479f83 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/testReport/
Max. process+thread count3315 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil requested changes Sep 16, 2021
View reviewed changes
Comment thread...rver/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
@Apache-HBase

Apache-HBase commented Sep 16, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 24sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 20sHBASE-26067 passed
+1 💚compile3m 22sHBASE-26067 passed
+1 💚checkstyle1m 13sHBASE-26067 passed
+1 💚spotbugs2m 14sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile3m 22sthe patch passed
+1 💚javac3m 22sthe patch passed
-0 ⚠️checkstyle1m 11shbase-server: The patch generated 1 new + 72 unchanged - 6 fixed = 73 total (was 78)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck20m 26sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs2m 25sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
52m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3685
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 9b82d9b459e5 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 16, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 5sHBASE-26067 passed
+1 💚compile1m 0sHBASE-26067 passed
+1 💚shadedjars8m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 44sthe patch passed
+1 💚compile1m 1sthe patch passed
+1 💚javac1m 1sthe patch passed
+1 💚shadedjars8m 18spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
-1 ❌unit159m 2shbase-server in the patch failed.
189m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3685
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ff9ae54590e7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/3/testReport/
Max. process+thread count4915 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 16, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚mvninstall6m 0sHBASE-26067 passed
+1 💚compile1m 35sHBASE-26067 passed
+1 💚shadedjars10m 38sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 0sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall5m 44sthe patch passed
+1 💚compile1m 37sthe patch passed
+1 💚javac1m 37sthe patch passed
+1 💚shadedjars10m 41spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 52sthe patch passed
_ Other Tests _
+1 💚unit248m 41shbase-server in the patch passed.
290m 13s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3685
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 8a401b974f1e 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/3/testReport/
Max. process+thread count2877 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Apache9 commented Sep 16, 2021

Copy link
Copy Markdown
ContributorAuthor

@wchevreuil@joshelser PTAL. Thanks.

@Apache-HBase

Apache-HBase commented Sep 16, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 25sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 6sHBASE-26067 passed
+1 💚compile3m 12sHBASE-26067 passed
+1 💚checkstyle1m 5sHBASE-26067 passed
+1 💚spotbugs2m 8sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall3m 38sthe patch passed
+1 💚compile3m 13sthe patch passed
+1 💚javac3m 13sthe patch passed
+1 💚checkstyle1m 3shbase-server: The patch generated 0 new + 72 unchanged - 6 fixed = 72 total (was 78)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck18m 12sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs2m 18sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
47m 34s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3685
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux f27dd9a7568e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 16, 2021

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚mvninstall5m 1sHBASE-26067 passed
+1 💚compile1m 18sHBASE-26067 passed
+1 💚shadedjars9m 12sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 49sthe patch passed
+1 💚compile1m 18sthe patch passed
+1 💚javac1m 18sthe patch passed
+1 💚shadedjars9m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 42sthe patch passed
_ Other Tests _
-1 ❌unit214m 21shbase-server in the patch failed.
249m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3685
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d3b62539581f 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/4/testReport/
Max. process+thread count3510 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 16, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 4sHBASE-26067 passed
+1 💚compile1m 4sHBASE-26067 passed
+1 💚shadedjars9m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile1m 2sthe patch passed
+1 💚javac1m 2sthe patch passed
+1 💚shadedjars9m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37sthe patch passed
_ Other Tests _
+1 💚unit246m 29shbase-server in the patch passed.
279m 30s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3685
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c0d48b722af4 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 6581fef
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/4/testReport/
Max. process+thread count3094 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3685/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit ab03ee1 into apache:HBASE-26067Sep 17, 2021
Apache9 added a commit that referenced this pull request Oct 5, 2021
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
c4d7d28
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Oct 14, 2021
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
be5a148
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Oct 21, 2021
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
e77d31b
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Nov 6, 2021
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
08ba5e9
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Nov 9, 2021
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
f8b1894
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Nov 27, 2021
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
c705d80
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Dec 6, 2021
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
97c68be
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Dec 17, 2021
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
60ceccb
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
asfgit pushed a commit that referenced this pull request Dec 22, 2021
@Apache9@joshelser
HBASE-26280Use store file tracker when snapshoting (#3685)
fc4f6d1
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Jan 1, 2022
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
d439884
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Jan 2, 2022
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
2269b19
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Jan 2, 2022
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
aec8f79
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
Apache9 added a commit that referenced this pull request Jan 4, 2022
@Apache9
HBASE-26280Use store file tracker when snapshoting (#3685)
b812a27
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 18, 2022
@Apache9@apurtell
HBASE-26280 Use store file tracker when snapshoting (apache#3685)
5bd366d
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
@apurtellapurtell mentioned this pull request Mar 18, 2022
Merged
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 19, 2022
@Apache9@apurtell
HBASE-26280 Use store file tracker when snapshoting (apache#3685)
a237263
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 25, 2022
@Apache9@apurtell
HBASE-26280 Use store file tracker when snapshoting (apache#3685)
469b243
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
@Apache9@apurtell
HBASE-26280 Use store file tracker when snapshoting (apache#3685)
1e127f6
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
apurtell added a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
@apurtell
HBASE-26826 Backport StoreFileTracker (HBASE-26067, HBASE-26584, and …
4e80f0e
…others) to branch-2.5
Previous cherry picks:
commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578)
commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617)
commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656)
commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666)
commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665)
commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681)
commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685)
commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721)
commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774)
commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749)
commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700)
commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786)
commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845)
commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942)
commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998)
commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010)
commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006)
commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034)
commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040)
commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035)
commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055)
commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054)
commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080)
commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113)
commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111)
commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082)
commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226)
commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267)
Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.
Signed-off-by: Josh Elser <elserj@apache.org>
Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit that referenced this pull request Mar 26, 2022
@Apache9@apurtell
HBASE-26280Use store file tracker when snapshoting (#3685)
4ae866f
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
apurtell added a commit that referenced this pull request Mar 26, 2022
@apurtell
HBASE-26826Backport StoreFileTracker (HBASE-26067,HBASE-26584, and …
6902cb2
…others) to branch-2.5
Previous cherry picks:
commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9HBASE-25988 Store the store file list by a file #3578)
commit 6e05376HBASE-26079 Use StoreFileTracker when splitting and merging #3617)
commit 090b2feHBASE-26224HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656)
commit 0ee1689HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666)
commit 2052e80HBASE-26248 Should find a suitable way to let users specify the store… #3665)
commit 5ff0f98HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681)
commit fc4f6d1HBASE-26280HBASE-26280 Use store file tracker when snapshoting #3685)
commit 06db852HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721)
commit e4e7cf8HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774)
commit 08d1171HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749)
commit 8bec26eHBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700)
commit a288365HBASE-26271: Cleanup the broken store files under data directory #3786)
commit d00b5faHBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845)
commit 771e552HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1HBASE-26265 Update ref guide to mention the new store file tracker im… #3942)
commit 755b3b4HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998)
commit 39c42c7HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010)
commit 6e1f5b7HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006)
commit f1dd865HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034)
commit 8fbc9a2HBASE-26674 Should modify filesCompacting under storeWriteLock #4040)
commit 5aa0fd2HBASE-26675 Data race on Compactor.writer #4035)
commit 3021c58HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055)
commit a8b68c9HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054)
commit dffeb8eHBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080)
commit b265fe5HBASE-26673 Implement a shell command for change SFT implementation #4113)
commit 4cdb380HBASE-26640 Reimplement master local region initialization to better … #4111)
commit 77bb153HBASE-26707: Reduce number of renames during bulkload (#4066) #4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082)
commit d3629bbHBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226)
commit 541d748HBASE-26881 Backport HBASE-25368 to branch-2 (#4267)
Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.
Signed-off-by: Josh Elser <elserj@apache.org>
Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@Apache9Josh Elser
HBASE-26280 Use store file tracker when snapshoting (apache#3685)
fb4997a
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
* Fix broken JUnit parameterization
* Also adds an one-liner fix to HBTU to be smarter when dropping tables.
Change-Id: I11bed0526715781d14476207e60ffa13cdbcdeba
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshelserjoshelserjoshelser left review comments
@wchevreuilwchevreuilwchevreuil approved these changes

Assignees

@Apache9Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Apache9@Apache-HBase@joshelser@wchevreuil