HBASE-26264 Add more checks to prevent misconfiguration on store file… by Apache9 · Pull Request #3681 · apache/hbase

Apache9 · 2021-09-14T14:46:53Z

… tracker

Apache-HBase · 2021-09-14T15:35:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 24s	HBASE-26067 passed
+1 💚	compile	3m 14s	HBASE-26067 passed
+1 💚	checkstyle	1m 4s	HBASE-26067 passed
+1 💚	spotbugs	2m 7s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	3m 6s	the patch passed
+1 💚	javac	3m 6s	the patch passed
+1 💚	checkstyle	1m 1s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 18s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
-1 ❌	spotbugs	2m 19s	hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		47m 56s

Reason	Tests
FindBugs	module:hbase-server
	Load of known null value in org.apache.hadoop.hbase.regionserver.storefiletracker.StoreFileTrackerFactory.checkForModifyTable(Configuration, TableDescriptor, TableDescriptor) At StoreFileTrackerFactory.java:in org.apache.hadoop.hbase.regionserver.storefiletracker.StoreFileTrackerFactory.checkForModifyTable(Configuration, TableDescriptor, TableDescriptor) At StoreFileTrackerFactory.java:[line 239]
	Non-virtual method call in org.apache.hadoop.hbase.regionserver.storefiletracker.StoreFileTrackerFactory.checkForModifyTable(Configuration, TableDescriptor, TableDescriptor) passes null for non-null parameter of checkForNewFamily(Configuration, TableDescriptor, ColumnFamilyDescriptor) At StoreFileTrackerFactory.java:TableDescriptor, TableDescriptor) passes null for non-null parameter of checkForNewFamily(Configuration, TableDescriptor, ColumnFamilyDescriptor) At StoreFileTrackerFactory.java:[line 239]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3681
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 5e09d5fbb730 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `989028b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotbugs	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser

No issues with changes as-is. Just one suggestion about the unit test additions, but not intending to block merging.

Apache-HBase · 2021-09-14T18:06:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	5m 0s	HBASE-26067 passed
+1 💚	compile	1m 22s	HBASE-26067 passed
+1 💚	shadedjars	8m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 49s	the patch passed
+1 💚	compile	1m 23s	the patch passed
+1 💚	javac	1m 23s	the patch passed
+1 💚	shadedjars	9m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	the patch passed
		_ Other Tests _
-1 ❌	unit	162m 33s	hbase-server in the patch failed.
		198m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3681
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 99f9f05d54ef 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `989028b`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/testReport/
Max. process+thread count	3819 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-14T19:22:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 45s	HBASE-26067 passed
+1 💚	compile	1m 11s	HBASE-26067 passed
+1 💚	shadedjars	9m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 22s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	9m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
-1 ❌	unit	237m 8s	hbase-server in the patch failed.
		274m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3681
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e484a4a9b914 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `989028b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/testReport/
Max. process+thread count	4193 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

… tracker

Apache-HBase · 2021-09-15T02:33:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	0m 1s	Docker failed to build yetus/hbase:92fe6090c2.

Subsystem	Report/Notes
GITHUB PR	#3681
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/2/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-15T03:52:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	9m 34s	HBASE-26067 passed
+1 💚	compile	3m 13s	HBASE-26067 passed
+1 💚	checkstyle	1m 5s	HBASE-26067 passed
+1 💚	spotbugs	2m 5s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	3m 8s	the patch passed
+1 💚	javac	3m 8s	the patch passed
+1 💚	checkstyle	1m 2s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	22m 31s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 16s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		60m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3681
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 6866f3722142 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `989028b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-15T05:48:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 12s	HBASE-26067 passed
+1 💚	compile	1m 13s	HBASE-26067 passed
+1 💚	shadedjars	8m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 17s	the patch passed
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
+1 💚	shadedjars	8m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
-1 ❌	unit	145m 9s	hbase-server in the patch failed.
		176m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3681
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e9d3d7c96de2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `989028b`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/3/testReport/
Max. process+thread count	4251 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-15T06:02:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	3m 48s	HBASE-26067 passed
+1 💚	compile	1m 1s	HBASE-26067 passed
+1 💚	shadedjars	8m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 50s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	8m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	159m 4s	hbase-server in the patch passed.
		190m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3681
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3de2d9a1eabf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `989028b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/3/testReport/
Max. process+thread count	4455 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-15T11:30:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	3m 46s	HBASE-26067 passed
+1 💚	compile	3m 19s	HBASE-26067 passed
+1 💚	checkstyle	1m 1s	HBASE-26067 passed
+1 💚	spotbugs	2m 4s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 37s	the patch passed
+1 💚	compile	3m 14s	the patch passed
+1 💚	javac	3m 14s	the patch passed
+1 💚	checkstyle	1m 1s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 21s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 59s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		52m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3681
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux fd1fc092c109 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `989028b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-15T13:40:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 48s	HBASE-26067 passed
+1 💚	compile	1m 14s	HBASE-26067 passed
+1 💚	shadedjars	8m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 29s	the patch passed
+1 💚	compile	1m 17s	the patch passed
+1 💚	javac	1m 17s	the patch passed
+1 💚	shadedjars	8m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	149m 16s	hbase-server in the patch passed.
		182m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3681
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cfc9494db54b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `989028b`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/4/testReport/
Max. process+thread count	4056 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-09-15T13:49:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-26067 Compile Tests _
+1 💚	mvninstall	4m 39s	HBASE-26067 passed
+1 💚	compile	1m 8s	HBASE-26067 passed
+1 💚	shadedjars	9m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	HBASE-26067 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 55s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	8m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	156m 50s	hbase-server in the patch passed.
		191m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3681
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f27b7e9c2233 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-26067 / `989028b`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/4/testReport/
Max. process+thread count	4349 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3681/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2021-09-15T14:59:21Z

Again, 3 +1s but a failed pre commit check... Let me merge. Thanks @joshelser

… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

… tracker (apache#3681) Signed-off-by: Josh Elser <elserj@apache.org>

… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

… tracker (apache#3681) Signed-off-by: Josh Elser <elserj@apache.org>

…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578) commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617) commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656) commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666) commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665) commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681) commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685) commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721) commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774) commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749) commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700) commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786) commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845) commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942) commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998) commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010) commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006) commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034) commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040) commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035) commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055) commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054) commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080) commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113) commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111) commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082) commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226) commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <elserj@apache.org> Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>

… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

…others) to branch-2.5 Previous cherry picks: commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic commit 43b40e9HBASE-25988 Store the store file list by a file #3578) commit 6e05376HBASE-26079 Use StoreFileTracker when splitting and merging #3617) commit 090b2feHBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656) commit 0ee1689HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666) commit 2052e80HBASE-26248 Should find a suitable way to let users specify the store… #3665) commit 5ff0f98HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681) commit fc4f6d1HBASE-26280 HBASE-26280 Use store file tracker when snapshoting #3685) commit 06db852HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721) commit e4e7cf8HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774) commit 08d1171HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749) commit 8bec26eHBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700) commit a288365HBASE-26271: Cleanup the broken store files under data directory #3786) commit d00b5faHBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845) commit 771e552HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot commit f16b7b1HBASE-26265 Update ref guide to mention the new store file tracker im… #3942) commit 755b3b4HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998) commit 39c42c7HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010) commit 6e1f5b7HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006) commit f1dd865HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034) commit 8fbc9a2HBASE-26674 Should modify filesCompacting under storeWriteLock #4040) commit 5aa0fd2HBASE-26675 Data race on Compactor.writer #4035) commit 3021c58HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055) commit a8b68c9HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054) commit dffeb8eHBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080) commit b265fe5HBASE-26673 Implement a shell command for change SFT implementation #4113) commit 4cdb380HBASE-26640 Reimplement master local region initialization to better … #4111) commit 77bb153HBASE-26707: Reduce number of renames during bulkload (#4066) #4122) commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082) commit d3629bbHBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226) commit 541d748HBASE-26881 Backport HBASE-25368 to branch-2 (#4267) Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks. Signed-off-by: Josh Elser <elserj@apache.org> Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>

… tracker (apache#3681) Change-Id: I7c899348d7ecb12abca611d46d86eee4919b3bd0 Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 requested a review from wchevreuil September 14, 2021 14:46

Apache9 self-assigned this Sep 14, 2021

Apache9 requested a review from joshelser September 14, 2021 14:55

joshelser approved these changes Sep 14, 2021
View reviewed changes

Comment thread...t/java/org/apache/hadoop/hbase/regionserver/storefiletracker/TestChangeStoreFileTracker.java

HBASE-26264 Add more checks to prevent misconfiguration on store file…
675e0d3
… tracker

Apache9 force-pushed the HBASE-26264 branch from 2332a26 to 675e0d3Compare September 15, 2021 02:31

Apache9 merged commit 6581fef into apache:HBASE-26067Sep 15, 2021

Apache9 added a commit that referenced this pull request Oct 5, 2021
HBASE-26264Add more checks to prevent misconfiguration on store file…
150d995
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Oct 14, 2021
HBASE-26264Add more checks to prevent misconfiguration on store file…
767a3e1
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Oct 21, 2021
HBASE-26264Add more checks to prevent misconfiguration on store file…
8662d91
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Nov 6, 2021
HBASE-26264Add more checks to prevent misconfiguration on store file…
0e82ecb
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

BukrosSzabolcs pushed a commit to BukrosSzabolcs/hbase that referenced this pull request Nov 8, 2021
HBASE-26264 Add more checks to prevent misconfiguration on store file…
4fa03c3
… tracker (apache#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Nov 9, 2021
HBASE-26264Add more checks to prevent misconfiguration on store file…
825543a
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Nov 27, 2021
HBASE-26264Add more checks to prevent misconfiguration on store file…
70906cf
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Dec 6, 2021
HBASE-26264Add more checks to prevent misconfiguration on store file…
33079f3
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Dec 17, 2021
HBASE-26264Add more checks to prevent misconfiguration on store file…
16d0551
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Dec 22, 2021
HBASE-26264Add more checks to prevent misconfiguration on store file…
5ff0f98
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Jan 1, 2022
HBASE-26264Add more checks to prevent misconfiguration on store file…
f2150c6
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Jan 2, 2022
HBASE-26264Add more checks to prevent misconfiguration on store file…
21c0387
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Jan 2, 2022
HBASE-26264Add more checks to prevent misconfiguration on store file…
d28a229
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Apache9 added a commit that referenced this pull request Jan 4, 2022
HBASE-26264Add more checks to prevent misconfiguration on store file…
dcaea11
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 18, 2022
HBASE-26264 Add more checks to prevent misconfiguration on store file…
9d37bae
… tracker (apache#3681) Signed-off-by: Josh Elser <elserj@apache.org>

apurtell mentioned this pull request Mar 18, 2022
Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5 #4241
Merged

apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 19, 2022
HBASE-26264 Add more checks to prevent misconfiguration on store file…
6bbc4e8
… tracker (apache#3681) Signed-off-by: Josh Elser <elserj@apache.org>

apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 25, 2022
HBASE-26264 Add more checks to prevent misconfiguration on store file…
fc4a4be
… tracker (apache#3681) Signed-off-by: Josh Elser <elserj@apache.org>

apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
HBASE-26264 Add more checks to prevent misconfiguration on store file…
9d5dd03
… tracker (apache#3681) Signed-off-by: Josh Elser <elserj@apache.org>

apurtell pushed a commit that referenced this pull request Mar 26, 2022
HBASE-26264Add more checks to prevent misconfiguration on store file…
9ed3f3f
… tracker (#3681) Signed-off-by: Josh Elser <elserj@apache.org>

Navigation Menu

Uh oh!

HBASE-26264 Add more checks to prevent misconfiguration on store file… - #3681

HBASE-26264 Add more checks to prevent misconfiguration on store file…#3681
Apache9 merged 1 commit into
apache:HBASE-26067from
Apache9:HBASE-26264

Apache9 commented Sep 14, 2021

Uh oh!

Apache-HBase commented Sep 14, 2021

Uh oh!

joshelser left a comment

Uh oh!

Uh oh!

Apache-HBase commented Sep 14, 2021

Uh oh!

Apache-HBase commented Sep 14, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache9 commented Sep 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Apache9 commented Sep 14, 2021

Uh oh!

Apache-HBase commented Sep 14, 2021

Uh oh!

joshelser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Apache-HBase commented Sep 14, 2021

Uh oh!

Apache-HBase commented Sep 14, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache-HBase commented Sep 15, 2021

Uh oh!

Apache9 commented Sep 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants