Skip to content

HBASE-26386 Refactor StoreFileTracker implementations to expose the s… - #3774

Merged
Apache9 merged 1 commit into
apache:HBASE-26067from
Apache9:HBASE-26386
Oct 21, 2021
Merged

HBASE-26386 Refactor StoreFileTracker implementations to expose the s…#3774
Apache9 merged 1 commit into
apache:HBASE-26067from
Apache9:HBASE-26386

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

…et method

@Apache9Apache9 self-assigned this Oct 20, 2021
@Apache9

Copy link
Copy Markdown
ContributorAuthor

It turns out that we still need to use StoreFileTrackerBase in MigrationStoreFileTracker so the refactoring is just a small one...

PTAL @wchevreuil

Thanks.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 58sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 1sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 12sHBASE-26067 passed
+1 💚compile3m 16sHBASE-26067 passed
+1 💚checkstyle1m 11sHBASE-26067 passed
+1 💚spotbugs2m 28sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 32sthe patch passed
+1 💚compile3m 37sthe patch passed
+1 💚javac3m 37sthe patch passed
+1 💚checkstyle1m 13shbase-server: The patch generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck21m 23sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs2m 25sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
53m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3774
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux a7830994ee6a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / d3556bf
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 44sHBASE-26067 passed
+1 💚compile1m 12sHBASE-26067 passed
+1 💚shadedjars8m 37sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 45sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 33sthe patch passed
+1 💚compile1m 13sthe patch passed
+1 💚javac1m 13sthe patch passed
+1 💚shadedjars8m 58spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 45sthe patch passed
_ Other Tests _
+1 💚unit146m 19shbase-server in the patch passed.
179m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3774
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 2709254d0c08 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / d3556bf
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/testReport/
Max. process+thread count4094 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+1 💚mvninstall4m 25sHBASE-26067 passed
+1 💚compile1m 5sHBASE-26067 passed
+1 💚shadedjars8m 48sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 42sHBASE-26067 passed
_ Patch Compile Tests _
+1 💚mvninstall4m 1sthe patch passed
+1 💚compile1m 6sthe patch passed
+1 💚javac1m 6sthe patch passed
+1 💚shadedjars8m 38spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 36sthe patch passed
_ Other Tests _
+1 💚unit157m 51shbase-server in the patch passed.
189m 52s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3774
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b47852496c92 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / d3556bf
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/testReport/
Max. process+thread count5090 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3774/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Apache9 merged commit 86836d4 into apache:HBASE-26067Oct 21, 2021
Apache9 added a commit that referenced this pull request Oct 21, 2021
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Nov 6, 2021
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Nov 9, 2021
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Nov 27, 2021
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Dec 6, 2021
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Dec 17, 2021
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
asfgit pushed a commit that referenced this pull request Dec 22, 2021
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Jan 1, 2022
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Jan 2, 2022
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Jan 2, 2022
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Apache9 added a commit that referenced this pull request Jan 4, 2022
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 18, 2022
…et method (apache#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 19, 2022
…et method (apache#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 25, 2022
…et method (apache#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
…et method (apache#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell added a commit to apurtell/hbase that referenced this pull request Mar 26, 2022
…others) to branch-2.5
Previous cherry picks:
commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9 HBASE-25988 Store the store file list by a file apache#3578)
commit 6e05376 HBASE-26079 Use StoreFileTracker when splitting and merging apache#3617)
commit 090b2fe HBASE-26224 HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… apache#3656)
commit 0ee1689 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table apache#3666)
commit 2052e80 HBASE-26248 Should find a suitable way to let users specify the store… apache#3665)
commit 5ff0f98 HBASE-26264 Add more checks to prevent misconfiguration on store file… apache#3681)
commit fc4f6d1 HBASE-26280 HBASE-26280 Use store file tracker when snapshoting apache#3685)
commit 06db852 HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… apache#3721)
commit e4e7cf8 HBASE-26386 Refactor StoreFileTracker implementations to expose the s… apache#3774)
commit 08d1171 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl apache#3749)
commit 8bec26e HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… apache#3700)
commit a288365 HBASE-26271: Cleanup the broken store files under data directory apache#3786)
commit d00b5fa HBASE-26454 CreateTableProcedure still relies on temp dir and renames… apache#3845)
commit 771e552 HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1 HBASE-26265 Update ref guide to mention the new store file tracker im… apache#3942)
commit 755b3b4 HBASE-26585 Add SFT configuration to META table descriptor when creating META apache#3998)
commit 39c42c7 HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… apache#4010)
commit 6e1f5b7 HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading apache#4006)
commit f1dd865 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… apache#4034)
commit 8fbc9a2 HBASE-26674 Should modify filesCompacting under storeWriteLock apache#4040)
commit 5aa0fd2 HBASE-26675 Data race on Compactor.writer apache#4035)
commit 3021c58 HBASE-26700 The way we bypass broken track file is not enough in Stor… apache#4055)
commit a8b68c9 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… apache#4054)
commit dffeb8e HBASE-26587 Introduce a new Admin API to change SFT implementation (#… apache#4080)
commit b265fe5 HBASE-26673 Implement a shell command for change SFT implementation apache#4113)
commit 4cdb380 HBASE-26640 Reimplement master local region initialization to better … apache#4111)
commit 77bb153 HBASE-26707: Reduce number of renames during bulkload (apache#4066) apache#4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous apache#4082)
commit d3629bb HBASE-26837 Set SFT config when creating TableDescriptor in TestClone… apache#4226)
commit 541d748 HBASE-26881 Backport HBASE-25368 to branch-2 (apache#4267)
Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.
Signed-off-by: Josh Elser <elserj@apache.org>
Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
apurtell pushed a commit that referenced this pull request Mar 26, 2022
…et method (#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
apurtell added a commit that referenced this pull request Mar 26, 2022
…others) to branch-2.5
Previous cherry picks:
commit 6aaef89 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic
commit 43b40e9HBASE-25988 Store the store file list by a file #3578)
commit 6e05376HBASE-26079 Use StoreFileTracker when splitting and merging #3617)
commit 090b2feHBASE-26224HBASE-26224 Introduce a MigrationStoreFileTracker to support migratin… #3656)
commit 0ee1689HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table #3666)
commit 2052e80HBASE-26248 Should find a suitable way to let users specify the store… #3665)
commit 5ff0f98HBASE-26264 Add more checks to prevent misconfiguration on store file… #3681)
commit fc4f6d1HBASE-26280HBASE-26280 Use store file tracker when snapshoting #3685)
commit 06db852HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… #3721)
commit e4e7cf8HBASE-26386 Refactor StoreFileTracker implementations to expose the s… #3774)
commit 08d1171HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl #3749)
commit 8bec26eHBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configur… #3700)
commit a288365HBASE-26271: Cleanup the broken store files under data directory #3786)
commit d00b5faHBASE-26454 CreateTableProcedure still relies on temp dir and renames… #3845)
commit 771e552HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot
commit f16b7b1HBASE-26265 Update ref guide to mention the new store file tracker im… #3942)
commit 755b3b4HBASE-26585 Add SFT configuration to META table descriptor when creating META #3998)
commit 39c42c7HBASE-26639 The implementation of TestMergesSplitsAddToTracker is pro… #4010)
commit 6e1f5b7HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading #4006)
commit f1dd865HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor… #4034)
commit 8fbc9a2HBASE-26674 Should modify filesCompacting under storeWriteLock #4040)
commit 5aa0fd2HBASE-26675 Data race on Compactor.writer #4035)
commit 3021c58HBASE-26700 The way we bypass broken track file is not enough in Stor… #4055)
commit a8b68c9HBASE-26690 Modify FSTableDescriptors to not rely on renaming when wr… #4054)
commit dffeb8eHBASE-26587 Introduce a new Admin API to change SFT implementation (#… #4080)
commit b265fe5HBASE-26673 Implement a shell command for change SFT implementation #4113)
commit 4cdb380HBASE-26640 Reimplement master local region initialization to better … #4111)
commit 77bb153HBASE-26707: Reduce number of renames during bulkload (#4066) #4122)
commit a4b192e HBASE-26611 Changing SFT implementation on disabled table is dangerous #4082)
commit d3629bbHBASE-26837 Set SFT config when creating TableDescriptor in TestClone… #4226)
commit 541d748HBASE-26881 Backport HBASE-25368 to branch-2 (#4267)
Fixups for precommit error prone, checkstyle, and javadoc warnings after applying cherry picks.
Signed-off-by: Josh Elser <elserj@apache.org>
Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…et method (apache#3774)
Change-Id: I81358ccea535cf5d31e3b8d6a5529ef1e37956bd
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@wchevreuil