Skip to content

HBASE-28187 NPE when flushing a non-existing column family - #5553

Closed
guluo2016 wants to merge 110 commits into
apache:masterfrom
guluo2016:hbase_flush_issue
Closed

HBASE-28187 NPE when flushing a non-existing column family#5553
guluo2016 wants to merge 110 commits into
apache:masterfrom
guluo2016:hbase_flush_issue

Conversation

@guluo2016

@guluo2016guluo2016 commented Nov 30, 2023

Copy link
Copy Markdown
Member

Details see: HBASE-28187

And even worse, although this flush can be terminated by exception or manually，we are still unable to operate this region because of RegionTooBusyException.

@Apache-HBase

Apache-HBase commented Nov 30, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 48sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 57smaster passed
+1 💚compile4m 0smaster passed
+1 💚checkstyle0m 48smaster passed
+1 💚spotless1m 0sbranch has no errors when running spotless:check.
+1 💚spotbugs2m 20smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 2sthe patch passed
-1 ❌compile3m 50shbase-server in the patch failed.
-0 ⚠️javac3m 50shbase-server in the patch failed.
+1 💚checkstyle0m 56sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 55sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚spotless0m 59spatch has no errors when running spotless:check.
+1 💚spotbugs2m 34sthe patch passed
_ Other Tests _
+1 💚asflicense0m 13sThe patch does not generate ASF License warnings.
46m 40s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5553
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 10ce71b9b054 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 44eb408
Default JavaEclipse Adoptium-11.0.17+8
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
Max. process+thread count79 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/1/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 30, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall2m 34smaster passed
+1 💚compile0m 41smaster passed
+1 💚shadedjars4m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 25smaster passed
_ Patch Compile Tests _
+1 💚mvninstall2m 22sthe patch passed
+1 💚compile0m 40sthe patch passed
+1 💚javac0m 40sthe patch passed
+1 💚shadedjars4m 43spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 24sthe patch passed
_ Other Tests _
+1 💚unit228m 45shbase-server in the patch passed.
250m 9s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5553
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f521882cce3a 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 44eb408
Default JavaTemurin-1.8.0_352-b08
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/1/testReport/
Max. process+thread count4185 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Nov 30, 2023

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 56smaster passed
+1 💚compile1m 3smaster passed
+1 💚shadedjars6m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 28smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 7sthe patch passed
+1 💚compile1m 5sthe patch passed
+1 💚javac1m 5sthe patch passed
+1 💚shadedjars6m 19spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 33sthe patch passed
_ Other Tests _
+1 💚unit271m 6shbase-server in the patch passed.
300m 11s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5553
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 00d3c8a13347 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 44eb408
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/1/testReport/
Max. process+thread count4699 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasaniand others added 3 commits November 30, 2023 21:09
@virajjasani
Revert "HBASE-28204 Canary can take lot more time If region starts wi…
7f3e400
…th delete markers (apache#5522)"
This reverts commit ce9eabe.
@bbeaudreault
HBASE-28222 Leak in ExportSnapshot during verifySnapshot on S3A (apac…
02217e1
…he#5554)
Revert "HBASE-12819 ExportSnapshot doesn't close FileSystem instances"
This reverts commit ee32eeb
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@Apache9
HBASE-28212 Addendum fix TestShell (apache#5555)
7dd4d0c
We added a new field in Procedure so the json output is also changed
thus we need to change the assertion
@Apache9

Apache9 commented Dec 2, 2023

Copy link
Copy Markdown
Contributor

Looking at the jira description, I think we should add the check at master side? We should reject the request at very beginning.

hiping-techand others added 3 commits December 4, 2023 15:51
@hiping-techlvhaiping.lhp
HBASE-28226 Add logic to check for RegionStateNode null pointer in Fl…
8631714
…ushRegionProcedure (apache#5548)
Co-authored-by: lvhaiping.lhp <lvhaiping.lhp@alibaba-inc.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@Apache9
HBASE-28199 Phase I: Suspend TRSP and SCP when updating meta (apache#…
cf798ad
…5520)
Signed-off-by: Yu Li <liyu@apache.org>
@vinayakphegde
HBASE-28209: Create a jmx metrics to expose the oldWALs directory size (
bc0f7a4
apache#5528)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@guluo2016

guluo2016 commented Dec 4, 2023

Copy link
Copy Markdown
MemberAuthor

Looking at the jira description, I think we should add the check at master side? We should reject the request at very beginning.

This can only partially solve the problem.

There is a scenario, the problem is still exists.

  1. We create a RegionObserver
  2. We obtain HRegion object in method prePut
  3. We can flush this region with a non-existing family by calling flushcache() directly
  4. Finally, we still get NPE, and the region woule fall into busying forever (RegionTooBusyException)

For example:

@OverridepublicvoidprePut(ObserverContext<RegionCoprocessorEnvironment> c, Putput, WALEditedit) throwsIOException {
HRegionregion = (HRegion) c.getEnvironment().getRegion()
region.flushcache(Arrays.asList("non-family".getBytes()), false, FlushLifeCycleTracker.DUMMY);
}

@guluo2016

guluo2016 commented Dec 4, 2023

Copy link
Copy Markdown
MemberAuthor

In this PR, I set the result of flush with non-existing family to successful.

Mybe we can set the result of flush with non-existing family to FlushResult.Result.CANNOT_FLUSH ?

@Apache9

Apache9 commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

For user request from Admin interface or shell, I think we should reject the request and give users a clear error message, this should be done first.

On the CP part, I'm neutral on whether we should deal with the problem. CP is a low level API only expected to be used by experts, so it is the CP's author's duty to not break HBase by wrong input. Of course, I think it is also OK to make our code more robust if it does not introduce overhead or complicate logic. But as you said, we still need to discuss how to deal with the problem, at least I do not think returning success is the correct way...

rmdmattinglyand others added 10 commits December 4, 2023 09:25
@rmdmattingly
HBASE-28215: region reopen procedure batching/throttling (apache#5534)
25e9228
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
@bbeaudreault
HBASE-28206 [JDK17] JVM crashes intermittently on aarch64 (apache#5561)
6e421e9
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@Apache9
HBASE-28248 Race between RegionRemoteProcedureBase and rollback opera…
82a2ce1
…tion could lead to ROLLEDBACK state be persisent to procedure store (apache#5567)
Signed-off-by: GeorryHuang <huangzhuoyue@apache.org>
Signed-off-by: Yi Mei <myimeiyi@gmail.com>
@wchevreuil
HBASE-28251 [SFT] Add description for specifying SFT impl during snap…
25c639f
…shot recovery (apache#5570)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
@zhuyaogai
HBASE-28190 Add slow sync log rolling test in TestAsyncLogRolling. (a…
78c5ac3
…pache#5507)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@stoty
HBASE-28252 Add sun.net.dns and sun.net.util to the JDK11+ module exp…
5503962
…orts in the hbase script (apache#5571)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
@stoty
HBASE-28247 Add java.base/sun.net.dns and java.base/sun.net.util expo…
f406c6b
…rt to jdk11 JVM test flags (apache#5569)
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
@hiping-techlvhaiping.lhp
HBASE-28241 The snapshot operation encountered an NPE and failed. (ap…
3d11712
…ache#5560)
Fixed the check for an ongoing Snapshot before proceeding with the merge/split region operation.
Co-authored-by: lvhaiping.lhp <lvhaiping.lhp@alibaba-inc.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Hui Ruan <huiruan@apache.org>
@Apache9
HBASE-28244 ProcedureTestingUtility.restart is broken sometimes after…
29bfc61
… HBASE-28199 (apache#5563)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@guluo2016
flush failed-fast if there are non-existing families at client side
74405ea
@guluo2016

guluo2016 commented Dec 13, 2023

Copy link
Copy Markdown
MemberAuthor

For user request from Admin interface or shell, I think we should reject the request and give users a clear error message, this should be done first.

On the CP part, I'm neutral on whether we should deal with the problem. CP is a low level API only expected to be used by experts, so it is the CP's author's duty to not break HBase by wrong input. Of course, I think it is also OK to make our code more robust if it does not introduce overhead or complicate logic. But as you said, we still need to discuss how to deal with the problem, at least I do not think returning success is the correct way...

Thanks for your repla, I update this PR.
At client side, i have added check if column family exists and it will return error as early as possible when having non-existing family.
And at region side, I alse have added check column family exists and it will return CANNOT_FLUSH for making hbase code more robust.
Thanks again.

@Apache-HBase

Apache-HBase commented Dec 13, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 51smaster passed
+1 💚compile3m 9smaster passed
+1 💚checkstyle0m 55smaster passed
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
+1 💚spotbugs2m 14smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
-1 ❌compile2m 20shbase-server in the patch failed.
-0 ⚠️javac2m 20shbase-server in the patch failed.
+1 💚checkstyle0m 52sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck9m 30sPatch does not cause any errors with Hadoop 3.2.4 3.3.6.
+1 💚spotless0m 42spatch has no errors when running spotless:check.
+1 💚spotbugs2m 29sthe patch passed
_ Other Tests _
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
36m 46s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5553
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 876f63abf57f 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 29bfc61
Default JavaEclipse Adoptium-11.0.17+8
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
Max. process+thread count77 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 13, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 40smaster passed
+1 💚compile1m 20smaster passed
+1 💚shadedjars6m 10sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 49smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 7sthe patch passed
+1 💚compile1m 13sthe patch passed
+1 💚javac1m 13sthe patch passed
+1 💚shadedjars5m 52spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43sthe patch passed
_ Other Tests _
+1 💚unit1m 53shbase-client in the patch passed.
-1 ❌unit258m 36shbase-server in the patch failed.
289m 23s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5553
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 96639fe87543 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 29bfc61
Default JavaEclipse Adoptium-11.0.17+8
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/testReport/
Max. process+thread count4716 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Dec 13, 2023

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 10smaster passed
+1 💚compile1m 9smaster passed
+1 💚shadedjars6m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 39sthe patch passed
+1 💚compile1m 8sthe patch passed
+1 💚javac1m 8sthe patch passed
+1 💚shadedjars6m 17spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 45sthe patch passed
_ Other Tests _
+1 💚unit1m 37shbase-client in the patch passed.
-1 ❌unit262m 37shbase-server in the patch failed.
291m 52s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5553
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0693a000f8b3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 29bfc61
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/testReport/
Max. process+thread count4709 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreaultand others added 14 commits February 5, 2024 08:26
@bbeaudreault
HBASE-28338 Bounded leak of FSDataInputStream buffers from checksum s…
256f10b
…witching (apache#5660)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@Apache9
HBASE-25051 DIGEST based auth broken for rpc based ConnectionRegistry (…
16de74c
…apache#5631)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
@rmdmattingly
HBASE-27687 Enhance quotas to consume blockBytesScanned rather than r…
afbf2ad
…esponse size (apache#5654)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
@stoty
HBASE-28345 Close HBase connection on exit from HBase Shell (apache#5665
3656293
)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
@rmdmattingly
HBASE-27800: Add support for default user quotas (apache#5666)
275d928
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
@anmolnar
HBASE-28337 Positive connection test in TestShadeSaslAuthenticationPr…
e85557a
…ovider runs with Kerberos instead of Shade authentication (apache#5659)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
@rmdmattingly
HBASE-28349 Count atomic operations against read quotas (apache#5668)
98eb3e0
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
@dependabot
HBASE-28355 Bump cryptography in /dev-support/git-jira-release-audit (a…
b3ffc4a
…pache#5663)
Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.6 to 42.0.0.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.6...42.0.0)
---
updated-dependencies:
- dependency-name: cryptography
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@chrajeshbabu
HBASE-28341 [JDK17] Fix Failure TestLdapHttpServer (apache#5672)
3ccf655
Co-authored-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
@mihir6692
HBASE-28204 : Region Canary can take lot more time If any region (exc…
3e281bd
…ept the first region) starts with delete markers (apache#5675)
Signed-off-by: David Manning <david.manning@salesforce.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
@mihir6692
HBASE-28357 MoveWithAck#isSuccessfulScan for Region movement should u…
e2ff158
…se Region End Key for limiting scan to one region only. (apache#5677)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
@mihir6692
HBASE-28356 RegionServer Canary should use Scan just like Region Cana…
a4002d6
…ry with option to enable Raw Scan (apache#5676)
Signed-off-by: David Manning <david.manning@salesforce.com>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
@stoty
HBASE-28353 Close HBase connection on implicit exit from HBase shell (a…
9656006
…pache#5673)
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
@anmolnar
HBASE-28340. Use all Zk client properties that is found in HBase conf (…
d925754
…apache#5669)
Signed-off-by: Balazs Meszaros <meszibali@apache.org>
@Apache-HBase

Apache-HBase commented Feb 16, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 47sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 57smaster passed
+1 💚compile3m 12smaster passed
+1 💚checkstyle0m 54smaster passed
+1 💚spotless0m 44sbranch has no errors when running spotless:check.
+1 💚spotbugs2m 15smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 42sthe patch passed
-1 ❌compile2m 23shbase-server in the patch failed.
-0 ⚠️javac2m 23shbase-server in the patch failed.
+1 💚checkstyle0m 53sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck4m 51sPatch does not cause any errors with Hadoop 3.3.6.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs2m 31sthe patch passed
_ Other Tests _
+1 💚asflicense0m 20sThe patch does not generate ASF License warnings.
35m 10s
SubsystemReport/Notes
DockerClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5553
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux 40ab80f74cf7 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d925754
Default JavaEclipse Adoptium-11.0.17+8
compilehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
Max. process+thread count82 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/console
versionsgit=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 16, 2024

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 11sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 59smaster passed
+1 💚compile1m 0smaster passed
+1 💚shadedjars5m 26sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 37smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 40sthe patch passed
+1 💚compile1m 1sthe patch passed
+1 💚javac1m 1sthe patch passed
+1 💚shadedjars5m 23spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
+1 💚unit1m 33shbase-client in the patch passed.
+1 💚unit213m 45shbase-server in the patch passed.
241m 43s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5553
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 62440f041430 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d925754
Default JavaEclipse Adoptium-11.0.17+8
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/testReport/
Max. process+thread count5096 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Feb 16, 2024

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 21sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 45smaster passed
+1 💚compile0m 54smaster passed
+1 💚shadedjars5m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall2m 25sthe patch passed
+1 💚compile0m 54sthe patch passed
+1 💚javac0m 54sthe patch passed
+1 💚shadedjars5m 31spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 34sthe patch passed
_ Other Tests _
+1 💚unit1m 22shbase-client in the patch passed.
-1 ❌unit242m 12shbase-server in the patch failed.
269m 43s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5553
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ea233e17b0bf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d925754
Default JavaTemurin-1.8.0_352-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/testReport/
Max. process+thread count5388 (vs. ulimit of 30000)
modulesC: hbase-client hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5553/3/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@chrajeshbabu

chrajeshbabu commented Feb 17, 2024

Copy link
Copy Markdown
Contributor

@guluo2016 latest code cannot be build with this patch. Please rebase the patch.

dependabotBotand others added 9 commits February 18, 2024 18:31
@dependabot
HBASE-28378 Bump cryptography in /dev-support/git-jira-release-audit (a…
96a447f
…pache#5687)
Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.0 to 42.0.2.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@42.0.0...42.0.2)
---
updated-dependencies:
- dependency-name: cryptography
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
@anchal246
HBASE-28142 Region Server Logs getting spammed with warning when stor…
b5175ba
…efile has no reader
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
@Kerasoneselina.yan
HBASE-28238 rpcservice should perform some important admin operation …
5398b13
…to priority ADMIN_QOS (apache#5558)
HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS (apache#5558)
Co-authored-by: selina.yan <selina.yan@huolala.cn>
@guluo2016
NPE when flushing a non-existing column family
e23a7e7
@guluo2016
Update incorrect assertions
8daf232
@guluo2016
Update assertions
6bc73ca
@guluo2016
flush failed-fast if there are non-existing families at client side
8ceb8f0
@guluo2016
Merge branch 'hbase_flush_issue' ofhttps://github.com/guluo2016/hbase…
3f2106c
…into hbase_flush_issue
@guluo2016
update
ac16dfe
@guluo2016

guluo2016 commented Feb 19, 2024

Copy link
Copy Markdown
MemberAuthor

@chrajeshbabu thanks for your comments, The update has been made in a new PR #5692

@guluo2016
guluo2016 deleted the hbase_flush_issue branch July 31, 2024 03:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

20 participants

@guluo2016@Apache-HBase@Apache9@chrajeshbabu@virajjasani@bbeaudreault@hiping-tech@vinayakphegde@rmdmattingly@wchevreuil@zhuyaogai@stoty@NihalJain@jackyhobingo@anmolnar@jbewing@apurtell@zhaomoran@charlesconnell@liuwenjing17