Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14712][ML]spark.ml.LogisticRegressionModel.toString should sum… - #12491
[SPARK-14712][ML]spark.ml.LogisticRegressionModel.toString should sum…#12491hujy wants to merge 4 commits into
Conversation
| def __repr__(self): | ||
| return self._call_java("toString") | ||
There was a problem hiding this comment.
I think Python style asks for two new lines here (try running ./dev/lint-python locally :))
holdenk
commented
Apr 19, 2016
Thanks for taking the initiative on this PR - at first glance it seems like this approach might not quite work but its easier to tell with some tests - could you add a test case and run it locally? You add your test in LogisticRegressionSuite.scala for the scala test. As well you may find the linter tools ./dev/lint-scala & ./dev/lint-python to be useful :) |
| import org.apache.hadoop.fs.Path | ||
| import org.apache.spark.SparkException | ||
| import org.apache.spark.{SparkException} |
| threshold=0.5, thresholds=None, probabilityCol="probability", | ||
| rawPredictionCol="rawPrediction", standardization=True, weightCol=None): | ||
| rawPredictionCol="rawPrediction", standardization=True, weightCol=None, | ||
| numFeatures=0, numClasses=0): |
There was a problem hiding this comment.
We should not expose numFeatures and numClasses as params which can be set by users. It should be property of **Model and be get directly from Scala by self._call_java("numFeatures").
hujy
commented
May 13, 2016
ok with test |
| @Since("1.6.0") | ||
| override def write: MLWriter = new LogisticRegressionModel.LogisticRegressionModelWriter(this) | ||
| @Since("2.0.0") |
There was a problem hiding this comment.
We will need to update this since :)
| return BinaryLogisticRegressionSummary(java_blr_summary) | ||
| @since("2.0.0") | ||
| def __repr__(self): |
There was a problem hiding this comment.
It might make sense to include this in the docstring since it might be useful for people to see how to use it :)
holdenk
commented
Oct 7, 2016
To get this tested we will need a committer to say so. Maybe @jkbradley who created the JIRA can take a look / add you to the whitelist. |
holdenk
commented
Oct 16, 2016
jkbradley
commented
Jan 4, 2017
@hujy Sorry for the delay! ok to test |
SparkQA
commented
Jan 4, 2017
Test build #3520 has finished for PR 12491 at commit
|
HyukjinKwon
commented
May 11, 2017
@hujy Would you fix the test failure? If it is inactive, I would rather like to suggest to close this. |
jiayue-zhang
commented
Aug 3, 2017
## What changes were proposed in this pull request? This PR proposes to close PRs ... - inactive to the review comments more than a month - WIP and inactive more than a month - with Jenkins build failure but inactive more than a month - suggested to be closed and no comment against that - obviously looking inappropriate (e.g., Branch 0.5) To make sure, I left a comment for each PR about a week ago and I could not have a response back from the author in these PRs below: Closesapache#11129Closesapache#12085Closesapache#12162Closesapache#12419Closesapache#12420Closesapache#12491Closesapache#13762Closesapache#13837Closesapache#13851Closesapache#13881Closesapache#13891Closesapache#13959Closesapache#14091Closesapache#14481Closesapache#14547Closesapache#14557Closesapache#14686Closesapache#15594Closesapache#15652Closesapache#15850Closesapache#15914Closesapache#15918Closesapache#16285Closesapache#16389Closesapache#16652Closesapache#16743Closesapache#16893Closesapache#16975Closesapache#17001Closesapache#17088Closesapache#17119Closesapache#17272Closesapache#17971 Added: Closesapache#17778Closesapache#17303Closesapache#17872 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#18017 from HyukjinKwon/close-inactive-prs.
What changes were proposed in this pull request?
SPARK-14712
spark.mllib LogisticRegressionModel overrides toString to print a little model info. We should do the same in spark.ml and override repr in pyspark.
How was this patch tested?
LogisticRegressionSuite.scala