Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14926] [ML] OneVsRest labelMetadata uses incorrect name - #13762
Closed
josh-howes wants to merge 1 commit into
Closed
[SPARK-14926] [ML] OneVsRest labelMetadata uses incorrect name#13762josh-howes wants to merge 1 commit into
josh-howes wants to merge 1 commit into
Conversation
mengxr
commented
Jun 21, 2016
Contributor
@josh-howes Did you try compiling the code? |
jkbradley
commented
Aug 29, 2016
Member
Ping |
SparkQA
commented
Sep 6, 2016
Test build #3251 has finished for PR 13762 at commit
|
josh-howesforce-pushed
the
Bugfix/SPARK-14926-One_vs_Rest-labelMetadata
branch
from
September 8, 2016 10:05
bd510ec to
b4badaeComparejosh-howes
commented
Sep 8, 2016
ContributorAuthor
@SparkQA build |
srowen
commented
Sep 12, 2016
Member
I think we should close this PR. |
josh-howes
commented
Sep 12, 2016
ContributorAuthor
I recently pushed a change to this but @SparkQA didn't kick off an automated build. Is that because I squashed my commits? |
srowen
commented
Sep 12, 2016
Member
Jenkins test this please |
SparkQA
commented
Sep 12, 2016
Test build #65256 has finished for PR 13762 at commit
|
jkbradley
left a comment
Member
There was a problem hiding this comment.
Also, could you please add a line to a unit test to verify that the predictionCol has the correct metadata? Thank you!
| // output label and label metadata as prediction | ||
| val predictionMetadata = new MetadataBuilder() | ||
| .withMetadata(labelMetadata) | ||
| .putString("name", predictionCol.name) |
Member
There was a problem hiding this comment.
This should go through the standard ML attribute constructors to modify labelMetadata:
val predictionMetadata = Attribute.fromMetadata(labelMetadata)
.withName($(predictionCol))
.toMetadata()
SparkQA
commented
Oct 7, 2016
Test build #3299 has finished for PR 13762 at commit
|
HyukjinKwon
commented
May 11, 2017
Member
Hi @josh-howes is it still active? If so, please address the comments above. Otherwise, I would rather like to propose to close this. |
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This PR proposes to close PRs ... - inactive to the review comments more than a month - WIP and inactive more than a month - with Jenkins build failure but inactive more than a month - suggested to be closed and no comment against that - obviously looking inappropriate (e.g., Branch 0.5) To make sure, I left a comment for each PR about a week ago and I could not have a response back from the author in these PRs below: Closesapache#11129Closesapache#12085Closesapache#12162Closesapache#12419Closesapache#12420Closesapache#12491Closesapache#13762Closesapache#13837Closesapache#13851Closesapache#13881Closesapache#13891Closesapache#13959Closesapache#14091Closesapache#14481Closesapache#14547Closesapache#14557Closesapache#14686Closesapache#15594Closesapache#15652Closesapache#15850Closesapache#15914Closesapache#15918Closesapache#16285Closesapache#16389Closesapache#16652Closesapache#16743Closesapache#16893Closesapache#16975Closesapache#17001Closesapache#17088Closesapache#17119Closesapache#17272Closesapache#17971 Added: Closesapache#17778Closesapache#17303Closesapache#17872 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#18017 from HyukjinKwon/close-inactive-prs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contribution is my original work and I license the work to the project under the project's open source license.
What changes were proposed in this pull request?
OneVsRestModel applies labelMetadata to the output column, but the metadata could contain the wrong name. The attribute name was modified to match predictionCol.
How was this patch tested?
Manual Tests