Skip to content

[SPARK-20494] Implement UDF array_unique in Spark with codegen - #17778

Closed
janewangfb wants to merge 1 commit into
apache:masterfrom
janewangfb:array_unique_3
Closed

[SPARK-20494] Implement UDF array_unique in Spark with codegen#17778
janewangfb wants to merge 1 commit into
apache:masterfrom
janewangfb:array_unique_3

Conversation

@janewangfb

@janewangfbjanewangfb commented Apr 27, 2017

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Add UDF array_unique which return a new array with all the duplicated elements in the original array removed.

How was this patch tested?

Added various unittests in collectionExpressionsSuite.scala and also in spark-shell, created tables with columns of array type and inserted values with duplicated array elements, ran queries with UDF and verified the results.

@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@HyukjinKwon

Copy link
Copy Markdown
Member

Hi @janewangfb, it looks we need a JIRA, better PR title and PR description. Please check out http://spark.apache.org/contributing.html.

@srowen

Copy link
Copy Markdown
Member

Why does this need to be added? If it isn't a standard function somewhere it probably doesn't need to be in Spark

@janewangfb

Copy link
Copy Markdown
ContributorAuthor

@srowen We have array_contains UDF. I think it is nice to have one that removes all the duplicated elements.

@janewangfbjanewangfb changed the title Add array_unique UDF[SPARK-20494] Implement UDF array_unique in Spark with codegenApr 27, 2017
@srowen

Copy link
Copy Markdown
Member

@janewangfb that's because array_contains is a Hive function

@srowen

Copy link
Copy Markdown
Member

We should close this

@srowensrowen mentioned this pull request May 17, 2017
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
## What changes were proposed in this pull request?
This PR proposes to close PRs ...
- inactive to the review comments more than a month
- WIP and inactive more than a month
- with Jenkins build failure but inactive more than a month
- suggested to be closed and no comment against that
- obviously looking inappropriate (e.g., Branch 0.5)
To make sure, I left a comment for each PR about a week ago and I could not have a response back from the author in these PRs below:
Closesapache#11129Closesapache#12085Closesapache#12162Closesapache#12419Closesapache#12420Closesapache#12491Closesapache#13762Closesapache#13837Closesapache#13851Closesapache#13881Closesapache#13891Closesapache#13959Closesapache#14091Closesapache#14481Closesapache#14547Closesapache#14557Closesapache#14686Closesapache#15594Closesapache#15652Closesapache#15850Closesapache#15914Closesapache#15918Closesapache#16285Closesapache#16389Closesapache#16652Closesapache#16743Closesapache#16893Closesapache#16975Closesapache#17001Closesapache#17088Closesapache#17119Closesapache#17272Closesapache#17971
Added:
Closesapache#17778Closesapache#17303Closesapache#17872
## How was this patch tested?
N/A
Author: hyukjinkwon <gurwls223@gmail.com>
Closesapache#18017 from HyukjinKwon/close-inactive-prs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@janewangfb@AmplabJenkins@HyukjinKwon@srowen