Uh oh!
There was an error while loading. Please reload this page.
[SPARK-20608] allow standby namenodes in spark.yarn.access.namenodes - #17872
[SPARK-20608] allow standby namenodes in spark.yarn.access.namenodes#17872charliechen211 wants to merge 3 commits into
Conversation
AmplabJenkins
commented
May 5, 2017
Can one of the admins verify this patch? |
charliechen211
commented
May 5, 2017
@srowen@jerryshao@steveloughran This is the latest PR. #17870 is deprecated. |
| } catch { | ||
| case e: StandbyException => | ||
| logWarning(s"Namenode ${dst} is in state standby", e) | ||
| case e: RemoteException => |
There was a problem hiding this comment.
I'd suggested adding a handler for UnknownHostException too, but now I think that could hide problems with client config. Best to leave as is.
steveloughran
commented
May 5, 2017
at a glance, patch LGTM. |
| dstFs.addDelegationTokens(tokenRenewer, tmpCreds) | ||
| } catch { | ||
| case e: StandbyException => | ||
| logWarning(s"Namenode ${dst} is in state standby", e) |
There was a problem hiding this comment.
It's not accurate to say "Namenode" here, because we may configure to other non-HDFS.
There was a problem hiding this comment.
hum..Here is actually fetching tokens from hadoopFS, including in hadoopFSCredentialProvider, which means it's exactly HDFS?
There was a problem hiding this comment.
Hadoop compatible FS doesn't equal to HDFS, we can configure to wasb, adls and others. Also wasb and adls support fetching delegation tokens from common FS API, so we should avoid mentioning Namenode which is only existed in HDFS.
There was a problem hiding this comment.
Also for the below "RemoteException", how do you know "RemoteException" is exactly a standby exception?
There was a problem hiding this comment.
In our tests, there are two possible exceptions when yarn.spark.access.namenodes=hdfs://activeNamenode,hdfs://standbyNamenode
- Caused by: org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.ipc.StandbyException): Operation category WRITE is not supported in state standby
- Caused by: org.apache.hadoop.ipc.StandbyException: Operation category WRITE is not supported in state standby
Maybe RemoteException should be caught by better way.
There was a problem hiding this comment.
What I mean is that if "RemoteException" is caused by others, it is not correct to log as "Namenode ${dst} is in state standby".
There was a problem hiding this comment.
You are right. I will refactor the exception log.
There was a problem hiding this comment.
I refactored it. Please review and give some more advices :)
…rom standby namenodes
| import org.apache.hadoop.conf.Configuration | ||
| import org.apache.hadoop.fs.{FileSystem, Path} | ||
| import org.apache.hadoop.ipc.RemoteException | ||
| import org.apache.hadoop.ipc.StandbyException |
There was a problem hiding this comment.
This two line of imports can be merged into one line.
jerryshao
commented
May 8, 2017
charliechen211
commented
May 8, 2017
@jerryshao done. |
srowen
commented
May 12, 2017
I think @vanzin is saying this is not the right change |
vanzin
commented
May 12, 2017
Yes, I already explained in the discussion in the bug. The very fact you're getting an exception from the standby namenode means you're not actually getting the delegation token. Which makes this change pointless. |
## What changes were proposed in this pull request? This PR proposes to close PRs ... - inactive to the review comments more than a month - WIP and inactive more than a month - with Jenkins build failure but inactive more than a month - suggested to be closed and no comment against that - obviously looking inappropriate (e.g., Branch 0.5) To make sure, I left a comment for each PR about a week ago and I could not have a response back from the author in these PRs below: Closesapache#11129Closesapache#12085Closesapache#12162Closesapache#12419Closesapache#12420Closesapache#12491Closesapache#13762Closesapache#13837Closesapache#13851Closesapache#13881Closesapache#13891Closesapache#13959Closesapache#14091Closesapache#14481Closesapache#14547Closesapache#14557Closesapache#14686Closesapache#15594Closesapache#15652Closesapache#15850Closesapache#15914Closesapache#15918Closesapache#16285Closesapache#16389Closesapache#16652Closesapache#16743Closesapache#16893Closesapache#16975Closesapache#17001Closesapache#17088Closesapache#17119Closesapache#17272Closesapache#17971 Added: Closesapache#17778Closesapache#17303Closesapache#17872 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#18017 from HyukjinKwon/close-inactive-prs.
Related Jira:
https://issues.apache.org/jira/browse/SPARK-20608
Descriptions:
See PR (in branch-2.1): #17870