Uh oh!
There was an error while loading. Please reload this page.
[SPARK-16412][SQL][WIP] Generate Java code that gets an array in each column of CachedBatch when DataFrame.cache() is called - #14091
Closed
kiszk wants to merge 4 commits into
Closed
[SPARK-16412][SQL][WIP] Generate Java code that gets an array in each column of CachedBatch when DataFrame.cache() is called#14091kiszk wants to merge 4 commits into
kiszk wants to merge 4 commits into
Conversation
SparkQA
commented
Jul 7, 2016
Test build #61913 has finished for PR 14091 at commit
|
remove duplicated final attribute at method declaration
SparkQA
commented
Aug 8, 2016
Test build #63350 has finished for PR 14091 at commit
|
HyukjinKwon
commented
May 11, 2017
Member
Hi @kiszk, I just wonder if it is still WIP (just for curiosity). |
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This PR proposes to close PRs ... - inactive to the review comments more than a month - WIP and inactive more than a month - with Jenkins build failure but inactive more than a month - suggested to be closed and no comment against that - obviously looking inappropriate (e.g., Branch 0.5) To make sure, I left a comment for each PR about a week ago and I could not have a response back from the author in these PRs below: Closesapache#11129Closesapache#12085Closesapache#12162Closesapache#12419Closesapache#12420Closesapache#12491Closesapache#13762Closesapache#13837Closesapache#13851Closesapache#13881Closesapache#13891Closesapache#13959Closesapache#14091Closesapache#14481Closesapache#14547Closesapache#14557Closesapache#14686Closesapache#15594Closesapache#15652Closesapache#15850Closesapache#15914Closesapache#15918Closesapache#16285Closesapache#16389Closesapache#16652Closesapache#16743Closesapache#16893Closesapache#16975Closesapache#17001Closesapache#17088Closesapache#17119Closesapache#17272Closesapache#17971 Added: Closesapache#17778Closesapache#17303Closesapache#17872 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#18017 from HyukjinKwon/close-inactive-prs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Waiting #11956 to be merged.
This PR generates Java code to directly get an array of each column from
CachedBatchwhenDataFrame.cache()is called. This is done in whole stage code generation.When DataFrame.cache()
is called, data is stored as column-oriented storage (columnar cache) inCachedBatch`. This PR avoid conversion from column-oriented storage to row-oriented storage. This PR handles an array type that is stored into a column.This PR generates code both for row-oriented storage and column-oriented storage only if
InMemoryColumnarTableScanexists in a plan sub-tree. A decision is performed by checking an given iterator isColumnaIteratorat runtimeThis PR generates Java code for columnar cache only if types in all columns, which are accessed in operations, are primitive or an array
I will add benchmark suites into here
Motivating example
Generated code
Before applying this PR
After applying this PR
How was this patch tested?
Added new tests into
DataFrameCacheSuite.scala