Skip to content

[SPARK-16253][SQL] make spark sql compatible with hive sql that using… - #14686

Closed
zenglinxi0615 wants to merge 1 commit into
apache:branch-1.6from
zenglinxi0615:v1.6.2
Closed

[SPARK-16253][SQL] make spark sql compatible with hive sql that using…#14686
zenglinxi0615 wants to merge 1 commit into
apache:branch-1.6from
zenglinxi0615:v1.6.2

Conversation

@zenglinxi0615

Copy link
Copy Markdown

What changes were proposed in this pull request?

make spark sql compatible with hive sql that using python script transform like using 'xxx.py'

How was this patch tested?

manual tests

@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

// for compatibility with hive
// if the script is a python/bash/... file, we should make it executable
if (new File(script).exists) {
new File(script).setExecutable(true)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this create a huge security hole? Especially because we are not resetting this to its old state.

@zenglinxi0615

Copy link
Copy Markdown
Author

Have you tried it on spark 1.6.2?

@yongliangliu

yongliangliu commented Aug 19, 2016

Copy link
Copy Markdown

I know how to deal with it.
i used the fllow code like this

add file /temp/test.py;
select transform(var1) using '/temp/test.py' as (var1_new) from test_table;

the error is "Error: /bin/bash: test.py: command not found"
but when i use this and do not change the source code ,it's work,i was so stupid.

add file /temp/test.py;
select transform(var1) using 'python /temp/test.py' as (var1_new) from test_table;

so there is not bug and no need to change source code

@zenglinxi0615

zenglinxi0615 commented Sep 1, 2016

Copy link
Copy Markdown
Author

sorry for long time no response.
yes, you are right, when you can change the sql from using '/temp/test.py' to using 'python /temp/test.py', there's no need for changing the spark source code.
However, this patch is used for the case when there are already many hive sql which using '/temp/test.py', it cost too much time for modifing these hive sql, so we want to make spark sql compatible with hive sql that using python script transform like using 'xxx.py'.

@HyukjinKwon

Copy link
Copy Markdown
Member

@zenglinxi0615 Is it still active? I wonder if there is any argument against #14686 (comment). Otherwise, I would rather like to suggest to close this.

@HyukjinKwonHyukjinKwon mentioned this pull request May 17, 2017
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
## What changes were proposed in this pull request?
This PR proposes to close PRs ...
- inactive to the review comments more than a month
- WIP and inactive more than a month
- with Jenkins build failure but inactive more than a month
- suggested to be closed and no comment against that
- obviously looking inappropriate (e.g., Branch 0.5)
To make sure, I left a comment for each PR about a week ago and I could not have a response back from the author in these PRs below:
Closesapache#11129Closesapache#12085Closesapache#12162Closesapache#12419Closesapache#12420Closesapache#12491Closesapache#13762Closesapache#13837Closesapache#13851Closesapache#13881Closesapache#13891Closesapache#13959Closesapache#14091Closesapache#14481Closesapache#14547Closesapache#14557Closesapache#14686Closesapache#15594Closesapache#15652Closesapache#15850Closesapache#15914Closesapache#15918Closesapache#16285Closesapache#16389Closesapache#16652Closesapache#16743Closesapache#16893Closesapache#16975Closesapache#17001Closesapache#17088Closesapache#17119Closesapache#17272Closesapache#17971
Added:
Closesapache#17778Closesapache#17303Closesapache#17872
## How was this patch tested?
N/A
Author: hyukjinkwon <gurwls223@gmail.com>
Closesapache#18017 from HyukjinKwon/close-inactive-prs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@zenglinxi0615@AmplabJenkins@yongliangliu@HyukjinKwon@hvanhovell