Uh oh!
There was an error while loading. Please reload this page.
[SPARK-4452][SPARK-11293][Core][BRANCH-1.6] Shuffle data structures can starve others on the same thread for memory - #13027
Closed
lianhuiwang wants to merge 3 commits into
Closed
Conversation
lianhuiwang
commented
May 10, 2016
ContributorAuthor
SparkQA
commented
May 10, 2016
Test build #58238 has finished for PR 13027 at commit
|
zzcclp
commented
May 11, 2016
Contributor
This pr is great for us, solved some ExecutorLost problems for branch-1.6. |
zzcclp
commented
May 12, 2016
Contributor
ping @davies@JoshRosen |
zzcclp
commented
May 18, 2016
Contributor
@davies , could you review this pr and merge it? |
davies
commented
May 18, 2016
Contributor
@lianhuiwang This is not a fix for bug or regression in 1.6, so we may not merge this into 1.6. We could re-visit this if we plan to have another release for 1.6. |
lianhuiwang
commented
May 19, 2016
ContributorAuthor
@davies Thanks. Many people said they need it for 1.6 in issue, So I submit this PR. |
davies
commented
May 19, 2016
Contributor
@lianhuiwang This PR is useful, other people could easily patch it by themselves, thanks for it. |
SparkQA
commented
May 23, 2016
Test build #59141 has finished for PR 13027 at commit
|
tgravescs
commented
Jun 27, 2016
Contributor
@davies Why haven't we pulled this into branch 1.6? can we upmerge and pull in so that if we do 1.6.3 its there? |
davies
commented
Jun 27, 2016
Contributor
@tgravescs For minor releases, we (the community) usually do not put much effort on the QA, it's risky to pull in large change (like this one) it. At least, I don't have enough confidence to merge this one. Sorry for that. |
maropu added a commit
to maropu/spark
that referenced
this pull request
Apr 23, 2017
Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238
peter-toth pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues). // Open PRs whose JIRA tickets have been already closed Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625 // Open PRs whose JIRA tickets does not exist and they are not minor issues Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238 N/A Author: Takeshi Yamamuro <yamamuro@apache.org> Closesapache#17734 from maropu/resolved_pr. Change-Id: Id2e590aa7283fe5ac01424d30a40df06da6098b5
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues). // Open PRs whose JIRA tickets have been already closed Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625 // Open PRs whose JIRA tickets does not exist and they are not minor issues Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238 ## How was this patch tested? N/A Author: Takeshi Yamamuro <yamamuro@apache.org> Closesapache#17734 from maropu/resolved_pr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is for the branch-1.6 version of the commits PR #10024.
In #9241 It implemented a mechanism to call spill() on those SQL operators that support spilling if there is not enough memory for execution.
But ExternalSorter and AppendOnlyMap in Spark core are not worked. So this PR make them benefit from #9241. Now when there is not enough memory for execution, it can get memory by spilling ExternalSorter and AppendOnlyMap in Spark core.
How was this patch tested?
unit tests