Uh oh!
There was an error while loading. Please reload this page.
[SPARK-16827][Shuffle] add disk spill bytes to UnsafeExternalSorter - #15616
Closed
dreamworks007 wants to merge 1 commit into
Closed
[SPARK-16827][Shuffle] add disk spill bytes to UnsafeExternalSorter#15616dreamworks007 wants to merge 1 commit into
dreamworks007 wants to merge 1 commit into
Conversation
rxin
commented
Oct 25, 2016
Contributor
cc @JoshRosen |
dreamworks007
commented
Oct 25, 2016
Author
ping |
SparkQA
commented
Oct 26, 2016
Test build #3373 has finished for PR 15616 at commit
|
dreamworks007force-pushed
the
oss_spill_metrics
branch
from
October 31, 2016 06:44
cbf933d to
f363d61Comparedreamworks007
commented
Oct 31, 2016
Author
@JoshRosen - could you take a look ? |
dreamworks007
commented
Nov 2, 2016
Author
ping ... @JoshRosen |
dreamworks007
commented
Dec 1, 2016
Author
ping .. |
vanzin
commented
Dec 2, 2016
Contributor
@rxin you closed the related bug, does that mean this patch is not needed or does the bug need to be reopened? |
JoshRosen
commented
Dec 6, 2016
Contributor
Is there any way to add a test for this? |
maropu added a commit
to maropu/spark
that referenced
this pull request
Apr 23, 2017
Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238
peter-toth pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues). // Open PRs whose JIRA tickets have been already closed Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625 // Open PRs whose JIRA tickets does not exist and they are not minor issues Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238 N/A Author: Takeshi Yamamuro <yamamuro@apache.org> Closesapache#17734 from maropu/resolved_pr. Change-Id: Id2e590aa7283fe5ac01424d30a40df06da6098b5
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues). // Open PRs whose JIRA tickets have been already closed Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625 // Open PRs whose JIRA tickets does not exist and they are not minor issues Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238 ## How was this patch tested? N/A Author: Takeshi Yamamuro <yamamuro@apache.org> Closesapache#17734 from maropu/resolved_pr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
disk spill bytes metrics was disabled due to #15347. This PR adds that metrics.
How was this patch tested?
Integration test with the following query:
val sqlString = """
SELECT a.target_id AS userid
FROM table_a a
JOIN table_b b
ON a.ds = '2016-07-15'
AND b.ds = '2016-07-15'
AND a.source_id = b.id"""
hc.sql(sqlString).count()
in 1.6, in stage 2 , it does not have spill bytes metrics reporting, and in 2.0 (with my change) , in stage 2, it has the spill bytes metrics reported
Spark 1.6 -
Spark 2.0 -
