Uh oh!
There was an error while loading. Please reload this page.
[SPARK-16495] [MLlib]Add ADMM optimizer in mllib package - #14473
[SPARK-16495] [MLlib]Add ADMM optimizer in mllib package#14473ZunwenYou wants to merge 1 commit into
Conversation
AmplabJenkins
commented
Aug 3, 2016
Can one of the admins verify this patch? |
ZunwenYou
commented
Aug 4, 2016
@MLnick please have a look at this. |
sethah
commented
Aug 5, 2016
@ZunwenYou Would you mind addressing the comments in the JIRA first? Adding a new optimization algorithm to an API that is now deprecated definitely warrants more high level discussion before code review should proceed, IMO. |
MLnick
commented
Aug 5, 2016
@ZunwenYou sorry if I was not clear on the JIRA. I said there that this should probably be done as a Spark package external to the core initially. That way you can gather some user feedback and performance numbers etc. If this is to be implemented within Spark then as Seth mentions it makes more sense to go into the It would also need some performance comparisons to the current optimizer options. |
ZunwenYou
commented
Aug 5, 2016
@MLnick You are right. We have apply ADMM to Sparse Logistic Regression with L1 norm in some CTR applications, the data sets of these applications almost consist of 10 million dimension and 100 million samples. Actually, ADMM's LR is fast than SGD on large scale data. I can provide some performance comparisons to SGD or OWLQN on our data set,but I wonder if the performance comparisons are convinced because our data set is private. Do you have any idea about data set for preformance comparisons? |
MLnick
commented
Aug 5, 2016
I'd recommend (a) generate some data; and/or (b) take a look at some larger public datasets (or samples thereof) such as Criteo (https://www.kaggle.com/c/criteo-display-ad-challenge/data) or Avito (https://www.kaggle.com/c/avito-context-ad-clicks/data) |
debasish83
commented
Dec 26, 2016
ADMM is already available as a breeze solver (BFGS, OWLQN, NonlinearMinimizer) which is integrated with ml/mllib...It will be great if you can look into it and let me know if you need pointers in running comparisons with OWLQN: |
Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues). // Open PRs whose JIRA tickets have been already closed Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625 // Open PRs whose JIRA tickets does not exist and they are not minor issues Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238 N/A Author: Takeshi Yamamuro <yamamuro@apache.org> Closesapache#17734 from maropu/resolved_pr. Change-Id: Id2e590aa7283fe5ac01424d30a40df06da6098b5
## What changes were proposed in this pull request? This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues). // Open PRs whose JIRA tickets have been already closed Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625 // Open PRs whose JIRA tickets does not exist and they are not minor issues Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238 ## How was this patch tested? N/A Author: Takeshi Yamamuro <yamamuro@apache.org> Closesapache#17734 from maropu/resolved_pr.
Alternating Direction Method of Multipliers (ADMM) is well suited to distributed convex optimization, and in particular to large-scale problems arising in statistics, machine learning, and related areas.
Details can be found in the S. Boyd's paper.
JIRA Issue: https://issues.apache.org/jira/browse/SPARK-16495