Skip to content

[SPARK-15980] [SQL] Support Stata-like tabulation of values in a single column, optionally with weights - #13614

Closed
shafiquejamal wants to merge 4 commits into
apache:masterfrom
shafiquejamal:crosstab
Closed

[SPARK-15980] [SQL] Support Stata-like tabulation of values in a single column, optionally with weights#13614
shafiquejamal wants to merge 4 commits into
apache:masterfrom
shafiquejamal:crosstab

Conversation

@shafiquejamal

Copy link
Copy Markdown

What changes were proposed in this pull request?

See JIRA ticket: https://issues.apache.org/jira/browse/SPARK-15890

How was this patch tested?

Test is included.

I suspect that the changes in the /dev/pr-deps directory should not have been committed, but I would think that the .gitignore file would have prevented this.

@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@HyukjinKwon

HyukjinKwon commented Jun 12, 2016

Copy link
Copy Markdown
Member

I think it will be nicer if the title of this PR follows https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

@shafiquejamal

Copy link
Copy Markdown
Author

Hello, I read the rules at the link before creating the Jira ticket and pull request, and I think I am in compliance. Can you please tell me which point at that link I have not complied with? Thanks.

@sadikovi

Copy link
Copy Markdown

@shafiquejamal
The PR title should be of the form [SPARK-xxxx] [COMPONENT] Title, where SPARK-xxxx is the relevant JIRA number, COMPONENT is one of the PR categories shown at https://spark-prs.appspot.com/ and Title may be the JIRA's title or a more specific title describing the PR itself.

@shafiquejamal

shafiquejamal commented Jun 12, 2016

Copy link
Copy Markdown
Author

Ok, I'll edit this to make the title correct. Thanks.

@shafiquejamalshafiquejamal changed the title Support Stata-like tabulation of values in a single column, optionally with weights[SPARK-15980] [SQL] Support Stata-like tabulation of values in a single column, optionally with weightsJun 12, 2016
@shafiquejamal

Copy link
Copy Markdown
Author

Hello, just wanted to know what else I should do in order for this PR to be accepted. Thanks.

@srowen

Copy link
Copy Markdown
Member

This PR looks like it has some problems. It adds some deps files that are unrelated. Generally you'd want to argue that this functionality is important enough to justify the burden of maintaining it as an API. I'm not (yet) sure it is.

@maropumaropu mentioned this pull request Apr 23, 2017
peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues).
// Open PRs whose JIRA tickets have been already closed
Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625
// Open PRs whose JIRA tickets does not exist and they are not minor issues
Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238
N/A
Author: Takeshi Yamamuro <yamamuro@apache.org>
Closesapache#17734 from maropu/resolved_pr.
Change-Id: Id2e590aa7283fe5ac01424d30a40df06da6098b5
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
## What changes were proposed in this pull request?
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues).
// Open PRs whose JIRA tickets have been already closed
Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625
// Open PRs whose JIRA tickets does not exist and they are not minor issues
Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238
## How was this patch tested?
N/A
Author: Takeshi Yamamuro <yamamuro@apache.org>
Closesapache#17734 from maropu/resolved_pr.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@shafiquejamal@AmplabJenkins@HyukjinKwon@sadikovi@srowen