Skip to content

[SPARK-20131][DStream][Test] Flaky Test: org.apache.spark.streaming.StreamingContextSuite - #17463

Closed
uncleGen wants to merge 2 commits into
apache:masterfrom
uncleGen:SPARK-20131
Closed

[SPARK-20131][DStream][Test] Flaky Test: org.apache.spark.streaming.StreamingContextSuite#17463
uncleGen wants to merge 2 commits into
apache:masterfrom
uncleGen:SPARK-20131

Conversation

@uncleGen

@uncleGenuncleGen commented Mar 29, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

do not stop the SparkContext in another separate thread.

How was this patch tested?

Jenkins.

@srowen

srowen commented Mar 29, 2017

Copy link
Copy Markdown
Member

I'm just curious why this solves the problem? if the problem is that the streaming context doesn't shut down or doesn't shut down quickly, then I'd suspect that it's not because shutting down SparkContext is the slow part, but I'm not sure.

@SparkQA

SparkQA commented Mar 29, 2017

Copy link
Copy Markdown

Test build #75340 has finished for PR 17463 at commit 89d1d35.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Mar 29, 2017

Copy link
Copy Markdown

Test build #75342 has finished for PR 17463 at commit c68c285.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@uncleGen

uncleGen commented Apr 1, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@srowen It's hard to say it's because shutting down SparkContext is the slow part, and we can improve this case by avoiding stopping SparkContext in a separate thread.
cc @zsxwing

@srowen

srowen commented Apr 1, 2017

Copy link
Copy Markdown
Member

Hm, I'm not sure. For example, what if the error is that the context is never stopped? maybe assert that awaitTerminationOrTimeout is true to also check this? In my experience it's the streaming context that can take a while to stop because it has to wait for batches. It's not 'graceful' in this test though, but I've certainly seen it fail to stop quickly.

@srowen

srowen commented Apr 7, 2017

Copy link
Copy Markdown
Member

I think I'd close this one as I don't think it is necessarily fixing the problem, and might mask one.

@zsxwing

zsxwing commented Apr 11, 2017

Copy link
Copy Markdown
Member

Could you close this one, please? I submitted #17610 to fix the root issue.

@maropumaropu mentioned this pull request Apr 23, 2017
Closed
maropu added a commit to maropu/spark that referenced this pull request Apr 23, 2017
@maropu
Closesapache#12835
559854f
Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238
asfgit pushed a commit that referenced this pull request Apr 24, 2017
@maropu@srowen
[BUILD] Close stale PRs
e9f9715
## What changes were proposed in this pull request?
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues).
// Open PRs whose JIRA tickets have been already closed
Closes#11785Closes#13027Closes#13614Closes#13761Closes#15197Closes#14006Closes#12576Closes#15447Closes#13259Closes#15616Closes#14473Closes#16638Closes#16146Closes#17269Closes#17313Closes#17418Closes#17485Closes#17551Closes#17463Closes#17625
// Open PRs whose JIRA tickets does not exist and they are not minor issues
Closes#10739Closes#15193Closes#15344Closes#14804Closes#16993Closes#17040Closes#15180Closes#17238
## How was this patch tested?
N/A
Author: Takeshi Yamamuro <yamamuro@apache.org>
Closes#17734 from maropu/resolved_pr.
peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
@maropuMingjie Tang
[BUILD] Close stale PRs
982bf88
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues).
// Open PRs whose JIRA tickets have been already closed
Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625
// Open PRs whose JIRA tickets does not exist and they are not minor issues
Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238
N/A
Author: Takeshi Yamamuro <yamamuro@apache.org>
Closesapache#17734 from maropu/resolved_pr.
Change-Id: Id2e590aa7283fe5ac01424d30a40df06da6098b5
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
@maropu@zifeif2
[BUILD] Close stale PRs
46744e5
## What changes were proposed in this pull request?
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues).
// Open PRs whose JIRA tickets have been already closed
Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625
// Open PRs whose JIRA tickets does not exist and they are not minor issues
Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238
## How was this patch tested?
N/A
Author: Takeshi Yamamuro <yamamuro@apache.org>
Closesapache#17734 from maropu/resolved_pr.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@uncleGen@srowen@SparkQA@zsxwing