Uh oh!
There was an error while loading. Please reload this page.
[SPARK-13015][MLlib][DOC] Replace example code in mllib-data-types.md using include_example - #14006
Closed
yinxusen wants to merge 12 commits into
Closed
[SPARK-13015][MLlib][DOC] Replace example code in mllib-data-types.md using include_example#14006yinxusen wants to merge 12 commits into
yinxusen wants to merge 12 commits into
Conversation
SparkQA
commented
Jun 30, 2016
Test build #61580 has finished for PR 14006 at commit
|
yinxusen
commented
Jul 1, 2016
ContributorAuthor
| .map { |l, i| i } | ||
| raise "Start indices amount is not equal to end indices amount, see #{@file}." \ | ||
| raise "Start indices amount is not equal to end indices amount, see #{@file}, #{@snippet_label}." \ |
Contributor
There was a problem hiding this comment.
I'd prefer
... see #{@file} [labeled=#{@snippet_label}].
Otherwise the label itself might be mistaken for a file path.
SparkQA
commented
Jul 1, 2016
Test build #61601 has finished for PR 14006 at commit
|
SparkQA
commented
Jul 4, 2016
Test build #61703 has finished for PR 14006 at commit
|
SparkQA
commented
Jul 8, 2016
Test build #61994 has finished for PR 14006 at commit
|
yinxusen
commented
Jul 8, 2016
ContributorAuthor
holdenk
commented
Oct 7, 2016
Contributor
Hi @yinxusen thanks for working on this - can you update it against the latest master? I'm all for switching our examples to be more include based and the improved error messages during doc builds for invalid includes seems helpful for developers :) |
yinxusen
commented
Oct 7, 2016
ContributorAuthor
@holdenk I'll update a version ASAP |
SparkQA
commented
Oct 7, 2016
Test build #66533 has finished for PR 14006 at commit
|
maropu added a commit
to maropu/spark
that referenced
this pull request
Apr 23, 2017
Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238
peter-toth pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues). // Open PRs whose JIRA tickets have been already closed Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625 // Open PRs whose JIRA tickets does not exist and they are not minor issues Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238 N/A Author: Takeshi Yamamuro <yamamuro@apache.org> Closesapache#17734 from maropu/resolved_pr. Change-Id: Id2e590aa7283fe5ac01424d30a40df06da6098b5
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This pr proposed to close stale PRs. Currently, we have 400+ open PRs and there are some stale PRs whose JIRA tickets have been already closed and whose JIRA tickets does not exist (also, they seem not to be minor issues). // Open PRs whose JIRA tickets have been already closed Closesapache#11785Closesapache#13027Closesapache#13614Closesapache#13761Closesapache#15197Closesapache#14006Closesapache#12576Closesapache#15447Closesapache#13259Closesapache#15616Closesapache#14473Closesapache#16638Closesapache#16146Closesapache#17269Closesapache#17313Closesapache#17418Closesapache#17485Closesapache#17551Closesapache#17463Closesapache#17625 // Open PRs whose JIRA tickets does not exist and they are not minor issues Closesapache#10739Closesapache#15193Closesapache#15344Closesapache#14804Closesapache#16993Closesapache#17040Closesapache#15180Closesapache#17238 ## How was this patch tested? N/A Author: Takeshi Yamamuro <yamamuro@apache.org> Closesapache#17734 from maropu/resolved_pr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For Scala/Python code, I add imports inside each function, which is easy to control those codes. Java import doesn't support that, so I leave them with duplications.
BTW The
tallSkinnyQRin both Scala and Java failed when I ran the code. I'll look into them soon.How was this patch tested?
Tested manually by running new example code, and generating docs with jekyll build.