Skip to content

[SPARK-17176][WEB UI]set default task sort column to "Status" - #14739

Closed
cenyuhai wants to merge 1 commit into
apache:masterfrom
cenyuhai:SPARK-17176
Closed

[SPARK-17176][WEB UI]set default task sort column to "Status"#14739
cenyuhai wants to merge 1 commit into
apache:masterfrom
cenyuhai:SPARK-17176

Conversation

@cenyuhai

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Task are sorted by "Index" in Stage Page, but user are always concerned about tasks which are failed(see error messages) or still running (maybe it is skewed). When there are too many tasks, it is too slow to sort. So it is better to set the default sort column to ”Status“.

@SparkQA

Copy link
Copy Markdown

Test build #64160 has finished for PR 14739 at commit c1f3c9e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen

Copy link
Copy Markdown
Member

I think this has come up before and not been accepted. This happens to have the desired behavior because "FAILED" comes before "RUNNING". It doesn't sort by ID as a secondary key. It's a behavior change and most other things in Spark and elsewhere sort by ID. It's easy to sort by status.

@cenyuhai

cenyuhai commented Aug 21, 2016

Copy link
Copy Markdown
ContributorAuthor

@srowen YES, "FAILED" will come before "RUNNING".That is what I want, because we want to know why task will fail more than the need to sort by ID, "Errors" are more import than the informations of the runnning tasks, because if there are too many failed tasks, there must be something wrong with the application.
ID is just a unique identifier for task, in the most cases, we don't care about it.But we will care about why tasks will fail, why tasks are running such a long time.
When there are too many tasks, it is not easy to sort by status, it is very slow.

@srowen

Copy link
Copy Markdown
Member

I can see that argument, but it would be consistent with other parts of Spark and other UIs. If for some reason we had a new state that sorted before "FAILED" this wouldn't work. Users can easily sort tasks too.

@cenyuhai

cenyuhai commented Aug 23, 2016

Copy link
Copy Markdown
ContributorAuthor

@srowen can we make it an option, default by "Index", users can choose "Status" or anything else?
Now the pagination is by jquery datatable, not by server side. When tasks are more than 10,000, It will start to become slower. If not happened in production environment, I would not have opened this PR, users advised me to sort by status.

@jiangxb1987

Copy link
Copy Markdown
Contributor

@srowen should we close this?

@srowensrowen mentioned this pull request Jun 25, 2017
@gatorsmile

Copy link
Copy Markdown
Member

Really appreciate your contribution! Sorry, based on the comment, we might need to close this PR, but please submit more PRs in the future. Thanks again!

zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
## What changes were proposed in this pull request?
This PR proposes to close stale PRs, mostly the same instances with apache#18017
I believe the author in apache#14807 removed his account.
Closesapache#7075Closesapache#8927Closesapache#9202Closesapache#9366Closesapache#10861Closesapache#11420Closesapache#12356Closesapache#13028Closesapache#13506Closesapache#14191Closesapache#14198Closesapache#14330Closesapache#14807Closesapache#15839Closesapache#16225Closesapache#16685Closesapache#16692Closesapache#16995Closesapache#17181Closesapache#17211Closesapache#17235Closesapache#17237Closesapache#17248Closesapache#17341Closesapache#17708Closesapache#17716Closesapache#17721Closesapache#17937
Added:
Closesapache#14739Closesapache#17139Closesapache#17445Closesapache#18042Closesapache#18359
Added:
Closesapache#16450Closesapache#16525Closesapache#17738
Added:
Closesapache#16458Closesapache#16508Closesapache#17714
Added:
Closesapache#17830Closesapache#14742
## How was this patch tested?
N/A
Author: hyukjinkwon <gurwls223@gmail.com>
Closesapache#18417 from HyukjinKwon/close-stale-pr.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cenyuhai@SparkQA@srowen@jiangxb1987@gatorsmile