Skip to content

[INFRA] Close stale PRs - #18417

Closed
HyukjinKwon wants to merge 1 commit into
apache:masterfrom
HyukjinKwon:close-stale-pr
Closed

[INFRA] Close stale PRs#18417
HyukjinKwon wants to merge 1 commit into
apache:masterfrom
HyukjinKwon:close-stale-pr

Conversation

@HyukjinKwon

@HyukjinKwonHyukjinKwon commented Jun 25, 2017

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR proposes to close stale PRs, mostly the same instances with #18017

I believe the author in #14807 removed his account.

Closes#7075
Closes#8927
Closes#9202
Closes#9366
Closes#10861
Closes#11420
Closes#12356
Closes#13028
Closes#13506
Closes#14191
Closes#14198
Closes#14330
Closes#14807
Closes#15839
Closes#16225
Closes#16685
Closes#16692
Closes#16995
Closes#17181
Closes#17211
Closes#17235
Closes#17237
Closes#17248
Closes#17341
Closes#17708
Closes#17716
Closes#17721
Closes#17937

Added:
Closes#14739
Closes#17139
Closes#17445
Closes#18042
Closes#18359

Added:
Closes#16450
Closes#16525
Closes#17738

Added:
Closes#16458
Closes#16508
Closes#17714

Added:
Closes#17830
Closes#14742

How was this patch tested?

N/A

@HyukjinKwon

HyukjinKwon commented Jun 25, 2017

Copy link
Copy Markdown
MemberAuthor

Please let me know if any author is active on any PR. Let me take them out. I picked up inclusively. My point here is to close PRs inactive to review comments and only leave PRs that wait for a review. Leave any comment if it is in a progress in any way. If missed, I guess picking up the commits and opening new one would be welcome in many cases (I guess the author can't reopen if it is closed by ASF account but I think it does not mean not to propose the change again).

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

cc @srowen, @vanzin, @gatorsmile and @jiangxb1987 who I believe are interested in this PR. Could you take a look please?

@SparkQA

Copy link
Copy Markdown

Test build #78580 has finished for PR 18417 at commit 6cdf056.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen

Copy link
Copy Markdown
Member

Suggest adding:
#14739
#17139
#17445
#18042
#18359

@jiangxb1987

Copy link
Copy Markdown
Contributor

Let's keep the following PRs open, because I believe they're good to have and the authors will soon be responding:
#15405
#17401
#17716

Also, I'd suggest we add the following PRs to the list:
#16450
#16525
#17738

Thanks!

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

I added all suggested one and took out 15405 and 17401 per requested. I guess the author should be responsive and I took out 17716 before. I think it is unfair to take out this again.

@imatiach-msft

imatiach-msft commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

can you please keep 17084 open? thanks!

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

Sure.

@jiangxb1987

Copy link
Copy Markdown
Contributor

Please add the following:
#16458
#16508
#17714

Thanks!

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

Added.

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

14957 was taken out as closed.

@gatorsmile

Copy link
Copy Markdown
Member

Three more PRs?
#17830
#14742
#17211

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

Sure.

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

(17211 is a dupe)

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

12257 was taken out as closed.

@ScrapCodes

Copy link
Copy Markdown
Member

15258 can also be taken out

@HyukjinKwon

Copy link
Copy Markdown
MemberAuthor

Sure, I did.

@srowen

Copy link
Copy Markdown
Member

Merged this pass to master

@HyukjinKwon
HyukjinKwon deleted the close-stale-pr branch January 2, 2018 03:38
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
## What changes were proposed in this pull request?
This PR proposes to close stale PRs, mostly the same instances with apache#18017
I believe the author in apache#14807 removed his account.
Closesapache#7075Closesapache#8927Closesapache#9202Closesapache#9366Closesapache#10861Closesapache#11420Closesapache#12356Closesapache#13028Closesapache#13506Closesapache#14191Closesapache#14198Closesapache#14330Closesapache#14807Closesapache#15839Closesapache#16225Closesapache#16685Closesapache#16692Closesapache#16995Closesapache#17181Closesapache#17211Closesapache#17235Closesapache#17237Closesapache#17248Closesapache#17341Closesapache#17708Closesapache#17716Closesapache#17721Closesapache#17937
Added:
Closesapache#14739Closesapache#17139Closesapache#17445Closesapache#18042Closesapache#18359
Added:
Closesapache#16450Closesapache#16525Closesapache#17738
Added:
Closesapache#16458Closesapache#16508Closesapache#17714
Added:
Closesapache#17830Closesapache#14742
## How was this patch tested?
N/A
Author: hyukjinkwon <gurwls223@gmail.com>
Closesapache#18417 from HyukjinKwon/close-stale-pr.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@HyukjinKwon@SparkQA@srowen@jiangxb1987@imatiach-msft@gatorsmile@ScrapCodes