Skip to content

[SPARK-19869][SQL]move table related ddl from ddl.scala to tables.scala - #17211

Closed
windpiger wants to merge 3 commits into
apache:masterfrom
windpiger:moveToTables
Closed

[SPARK-19869][SQL]move table related ddl from ddl.scala to tables.scala#17211
windpiger wants to merge 3 commits into
apache:masterfrom
windpiger:moveToTables

Conversation

@windpiger

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

move table related ddl from ddl.scala to tables.scala

How was this patch tested?

N/A

@SparkQA

Copy link
Copy Markdown

Test build #74209 has finished for PR 17211 at commit c31ae7f.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@windpiger

Copy link
Copy Markdown
ContributorAuthor

cc @cloud-fan

@SparkQA

Copy link
Copy Markdown

Test build #74210 has finished for PR 17211 at commit ac79b05.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@@ -167,599 +153,6 @@ case class DescribeDatabaseCommand(
}
}

@gatorsmilegatorsmileMar 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining commands are database only. We can move the database related commands to org.apache.spark.sql.execution.command.databases.scala.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok~ thanks, another problem is now the lines of tables.scala is 1594, this is too large, should we need to split it to reduce the lines of a file?

@gatorsmile

Copy link
Copy Markdown
Member

This change might cause people hard to track the change history. Maybe we can close this PR?

@HyukjinKwonHyukjinKwon mentioned this pull request Jun 25, 2017
@gatorsmile

Copy link
Copy Markdown
Member

We are closing it due to inactivity. please do reopen if you want to push it forward. Thanks!

zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
## What changes were proposed in this pull request?
This PR proposes to close stale PRs, mostly the same instances with apache#18017
I believe the author in apache#14807 removed his account.
Closesapache#7075Closesapache#8927Closesapache#9202Closesapache#9366Closesapache#10861Closesapache#11420Closesapache#12356Closesapache#13028Closesapache#13506Closesapache#14191Closesapache#14198Closesapache#14330Closesapache#14807Closesapache#15839Closesapache#16225Closesapache#16685Closesapache#16692Closesapache#16995Closesapache#17181Closesapache#17211Closesapache#17235Closesapache#17237Closesapache#17248Closesapache#17341Closesapache#17708Closesapache#17716Closesapache#17721Closesapache#17937
Added:
Closesapache#14739Closesapache#17139Closesapache#17445Closesapache#18042Closesapache#18359
Added:
Closesapache#16450Closesapache#16525Closesapache#17738
Added:
Closesapache#16458Closesapache#16508Closesapache#17714
Added:
Closesapache#17830Closesapache#14742
## How was this patch tested?
N/A
Author: hyukjinkwon <gurwls223@gmail.com>
Closesapache#18417 from HyukjinKwon/close-stale-pr.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@windpiger@SparkQA@gatorsmile