Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19952][SQL] Remove various analysis exceptions - #17716
Closed
hvanhovell wants to merge 2 commits into
Closed
Conversation
hvanhovell
commented
Apr 21, 2017
| case _: NoSuchTableException => | ||
| u.failAnalysis(s"Table or view not found: ${tableIdentWithDb.unquotedString}") | ||
| // If the database is defined and that database is not found, throw an AnalysisException. | ||
| if (!tableIdentWithDb.database.exists(catalog.databaseExists)) { |
ContributorAuthor
There was a problem hiding this comment.
Perhaps we should move this into catalog.lookupRelation and attach the location here.
Contributor
There was a problem hiding this comment.
how about
try {
catalog.lookupRelation(tableIdentWithDb)
} catch {
case a: AnalysisException => u.failAnalysis(a.message)
}
ContributorAuthor
There was a problem hiding this comment.
Yeah, could work. This change is also causing the tests to fail, so I am revisiting it.
hvanhovell
commented
Apr 21, 2017
ContributorAuthor
SparkQA
commented
Apr 21, 2017
Test build #76031 has finished for PR 17716 at commit
|
SparkQA
commented
Apr 21, 2017
Test build #76039 has finished for PR 17716 at commit
|
| private def assertNoSuchTable(query: String): Unit = { | ||
| intercept[NoSuchTableException] { | ||
| intercept[AnalysisException] { |
Member
There was a problem hiding this comment.
AnalysisException is a pretty general Exception in Spark SQL. The future refactoring might introduce bugs without trigger any test case failure.
Could we check the error messages?
HyukjinKwon
commented
Jun 2, 2017
Member
@hvanhovell, how is it going? |
jiangxb1987
commented
Jun 25, 2017
Contributor
ping @hvanhovell Are you still working on this? |
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This PR proposes to close stale PRs, mostly the same instances with apache#18017 I believe the author in apache#14807 removed his account. Closesapache#7075Closesapache#8927Closesapache#9202Closesapache#9366Closesapache#10861Closesapache#11420Closesapache#12356Closesapache#13028Closesapache#13506Closesapache#14191Closesapache#14198Closesapache#14330Closesapache#14807Closesapache#15839Closesapache#16225Closesapache#16685Closesapache#16692Closesapache#16995Closesapache#17181Closesapache#17211Closesapache#17235Closesapache#17237Closesapache#17248Closesapache#17341Closesapache#17708Closesapache#17716Closesapache#17721Closesapache#17937 Added: Closesapache#14739Closesapache#17139Closesapache#17445Closesapache#18042Closesapache#18359 Added: Closesapache#16450Closesapache#16525Closesapache#17738 Added: Closesapache#16458Closesapache#16508Closesapache#17714 Added: Closesapache#17830Closesapache#14742 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#18417 from HyukjinKwon/close-stale-pr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We currently have quite a few analysis exception subclasses, the problem with these is that they are not well supported throughout Spark (in pySpark for example) and that the added value is limited. This PR removes the
no such objectand thealready existsexceptions, and replaces them by a factory methods that create analysis exceptions with the required error messages.How was this patch tested?
Modified existing tests.