Skip to content

[SPARK-20013][SQL]merge renameTable to alterTable in ExternalCatalog - #17721

Closed
windpiger wants to merge 1 commit into
apache:masterfrom
windpiger:mergeAlterRenameTable
Closed

[SPARK-20013][SQL]merge renameTable to alterTable in ExternalCatalog#17721
windpiger wants to merge 1 commit into
apache:masterfrom
windpiger:mergeAlterRenameTable

Conversation

@windpiger

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

merge renameTable to alterTable in ExternalCatalog has some reasons:

In Hive, we rename a Table by alterTable
Currently when we create / rename a managed table, we should get the defaultTablePath for them in ExternalCatalog, then we have two defaultTablePath logic in its two subclass HiveExternalCatalog and InMemoryCatalog, additionally there is also a defaultTablePath in SessionCatalog, so till now we have three defaultTablePath in three classes.
we'd better to unify them up to SessionCatalog
To unify them, we should move some logic from ExternalCatalog to SessionCatalog, renameTable is one of this.

while limit to the simple parameters in renameTable

 def renameTable(db: String, oldName: String, newName: String): Unit

even if we move the defaultTablePath logic to SessionCatalog, we can not pass it to renameTable.

So we can merge the renameTable to alterTable, and rename it in alterTable.

How was this patch tested?

delete some tests in ExternalCatalogSuite which already existed in SessionCatalogSuite,
and move some other tests in ExternalCatalogSuite which does not exist in SessionCatalogSuite

@SparkQA

Copy link
Copy Markdown

Test build #76038 has finished for PR 17721 at commit 2ea645c.

  • This patch fails Scala style tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@hvanhovell

Copy link
Copy Markdown
Contributor

@windpiger could you make sure that the freshly added events still work after this change.

@HyukjinKwon

Copy link
Copy Markdown
Member

ping @windpiger

@HyukjinKwonHyukjinKwon mentioned this pull request Jun 25, 2017
@gatorsmile

Copy link
Copy Markdown
Member

We are closing it due to inactivity. please do reopen if you want to push it forward. Thanks!

zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
## What changes were proposed in this pull request?
This PR proposes to close stale PRs, mostly the same instances with apache#18017
I believe the author in apache#14807 removed his account.
Closesapache#7075Closesapache#8927Closesapache#9202Closesapache#9366Closesapache#10861Closesapache#11420Closesapache#12356Closesapache#13028Closesapache#13506Closesapache#14191Closesapache#14198Closesapache#14330Closesapache#14807Closesapache#15839Closesapache#16225Closesapache#16685Closesapache#16692Closesapache#16995Closesapache#17181Closesapache#17211Closesapache#17235Closesapache#17237Closesapache#17248Closesapache#17341Closesapache#17708Closesapache#17716Closesapache#17721Closesapache#17937
Added:
Closesapache#14739Closesapache#17139Closesapache#17445Closesapache#18042Closesapache#18359
Added:
Closesapache#16450Closesapache#16525Closesapache#17738
Added:
Closesapache#16458Closesapache#16508Closesapache#17714
Added:
Closesapache#17830Closesapache#14742
## How was this patch tested?
N/A
Author: hyukjinkwon <gurwls223@gmail.com>
Closesapache#18417 from HyukjinKwon/close-stale-pr.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@windpiger@SparkQA@hvanhovell@HyukjinKwon@gatorsmile