Uh oh!
There was an error while loading. Please reload this page.
[SPARK-20013][SQL]add a newTablePath parameter for renameTable in ExternalCatalog - #17341
Closed
windpiger wants to merge 3 commits into
Closed
[SPARK-20013][SQL]add a newTablePath parameter for renameTable in ExternalCatalog#17341windpiger wants to merge 3 commits into
windpiger wants to merge 3 commits into
Conversation
windpiger
commented
Mar 18, 2017
| catalog.dropTable("db2", "unknown_table", ignoreIfNotExists = true, purge = false) | ||
| } | ||
| test("rename table") { |
windpiger
commented
Mar 18, 2017
| assert(catalog.listTables("db2").toSet == Set("tblone", "tbl2")) | ||
| } | ||
| test("rename table when database/table does not exist") { |
windpiger
commented
Mar 18, 2017
| } | ||
| } | ||
| test("rename table when destination table already exists") { |
ContributorAuthor
There was a problem hiding this comment.
move to SessionCatalogSuite
windpiger
commented
Mar 18, 2017
| assert(!exists(db.locationUri)) | ||
| } | ||
| test("create/drop/rename table should create/delete/rename the directory") { |
ContributorAuthor
There was a problem hiding this comment.
move to SessionCatalogSuite
SparkQA
commented
Mar 18, 2017
Test build #74784 has finished for PR 17341 at commit
|
SparkQA
commented
Mar 18, 2017
Test build #74785 has finished for PR 17341 at commit
|
windpiger
commented
Mar 19, 2017
ContributorAuthor
gatorsmile
commented
Jun 14, 2017
Member
Maybe we can close this one at first and revisit it later? |
gatorsmile
commented
Jun 27, 2017
Member
We are closing it due to inactivity. please do reopen if you want to push it forward. Thanks! |
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This PR proposes to close stale PRs, mostly the same instances with apache#18017 I believe the author in apache#14807 removed his account. Closesapache#7075Closesapache#8927Closesapache#9202Closesapache#9366Closesapache#10861Closesapache#11420Closesapache#12356Closesapache#13028Closesapache#13506Closesapache#14191Closesapache#14198Closesapache#14330Closesapache#14807Closesapache#15839Closesapache#16225Closesapache#16685Closesapache#16692Closesapache#16995Closesapache#17181Closesapache#17211Closesapache#17235Closesapache#17237Closesapache#17248Closesapache#17341Closesapache#17708Closesapache#17716Closesapache#17721Closesapache#17937 Added: Closesapache#14739Closesapache#17139Closesapache#17445Closesapache#18042Closesapache#18359 Added: Closesapache#16450Closesapache#16525Closesapache#17738 Added: Closesapache#16458Closesapache#16508Closesapache#17714 Added: Closesapache#17830Closesapache#14742 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#18417 from HyukjinKwon/close-stale-pr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently when we create / rename a managed table, we should get the defaultTablePath for them in ExternalCatalog, then we have two defaultTablePath logic in its two subclass HiveExternalCatalog and InMemoryCatalog, additionally there is also a defaultTablePath in SessionCatalog, so till now we have three defaultTablePath in three classes.
we'd better to unify them up to SessionCatalog
To unify them, we should move some logic from ExternalCatalog to SessionCatalog, renameTable is one of this.
while limit to the simple parameters in renameTable
even if we move the defaultTablePath logic to SessionCatalog, we can not pass it to renameTable.
So we can add a newTablePath parameter for renameTable in ExternalCatalog
How was this patch tested?
delete some tests in ExternalCatalogSuite which already existed in SessionCatalogSuite,
and move some other tests in ExternalCatalogSuite which does not exist in SessionCatalogSuite