Skip to content

HBASE-26441: Add metrics for BrokenStoreFileCleaner - #3861

Closed
BukrosSzabolcs wants to merge 33 commits into
apache:HBASE-26067from
BukrosSzabolcs:HBASE-26441
Closed

HBASE-26441: Add metrics for BrokenStoreFileCleaner#3861
BukrosSzabolcs wants to merge 33 commits into
apache:HBASE-26067from
BukrosSzabolcs:HBASE-26441

Conversation

@BukrosSzabolcs

Copy link
Copy Markdown
Contributor

add rs metricsfor BrokenStoreFileCleaner
aggregate the rs metrics on master for easier access

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 27sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall5m 22sHBASE-26067 passed
+1 💚compile5m 54sHBASE-26067 passed
+1 💚checkstyle1m 44sHBASE-26067 passed
+1 💚spotbugs7m 44sHBASE-26067 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 53sthe patch passed
+1 💚compile5m 45sthe patch passed
+1 💚cc5m 45sthe patch passed
-0 ⚠️javac0m 31shbase-hadoop-compat generated 6 new + 97 unchanged - 6 fixed = 103 total (was 103)
-0 ⚠️checkstyle0m 14shbase-hadoop-compat: The patch generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0)
-0 ⚠️checkstyle1m 17shbase-server: The patch generated 6 new + 101 unchanged - 0 fixed = 107 total (was 101)
-0 ⚠️whitespace0m 0sThe patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck25m 6sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚hbaseprotoc2m 20sthe patch passed
+1 💚spotbugs8m 10sthe patch passed
_ Other Tests _
+1 💚asflicense0m 36sThe patch does not generate ASF License warnings.
82m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 937a6a688928 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 36b6088
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-hadoop-compat.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 40sHBASE-26067 passed
+1 💚compile2m 33sHBASE-26067 passed
+1 💚shadedjars8m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 19sHBASE-26067 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall4m 27sthe patch passed
+1 💚compile2m 36sthe patch passed
+1 💚javac2m 36sthe patch passed
+1 💚shadedjars8m 14spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 16sthe patch passed
_ Other Tests _
+1 💚unit1m 1shbase-protocol-shaded in the patch passed.
+1 💚unit0m 40shbase-hadoop-compat in the patch passed.
+1 💚unit143m 44shbase-server in the patch passed.
182m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b44c6c4a036f 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 36b6088
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/testReport/
Max. process+thread count4212 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 5sHBASE-26067 passed
+1 💚compile2m 12sHBASE-26067 passed
+1 💚shadedjars8m 22sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 15sHBASE-26067 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall3m 57sthe patch passed
+1 💚compile2m 6sthe patch passed
+1 💚javac2m 6sthe patch passed
+1 💚shadedjars8m 18spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 12sthe patch passed
_ Other Tests _
+1 💚unit0m 48shbase-protocol-shaded in the patch passed.
+1 💚unit0m 39shbase-hadoop-compat in the patch passed.
+1 💚unit151m 20shbase-server in the patch passed.
188m 6s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 4ad85545fbed 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 36b6088
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/testReport/
Max. process+thread count4284 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


/**
* Increment the deleted files counter
* @param deletes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits: avoid empty javadoc element, it will lead to a checkstyle warning.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out!

String FAILED_DELETES_DESC =
"Number of files BrokenStoreFileCleaner tried but failed to delete";
String RUNS = "BrokenStoreFileCleanerRuns";
String RUNS_DESC = "Number of time the BrokenStoreFileCleaner chore run";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number of times?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

required uint64 runtime = 2;
optional uint64 deleted_files = 3;
optional uint64 failed_deletes = 4;
required uint32 runs = 5;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the above metrics class we use long to runs, why here we change to use uint32 instead of uint64?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how it ended up as uint32. Changing it to uint64.

returns(GetLiveRegionServersResponse);

/** Report BrokenStoreFileCleaner chore metrics to master */
rpc ReportBrokenStoreFileCleanerUsage(BrokenStoreFileCleanerUsageRequest)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth a separated method? How do we report the metrics for other background tasks on region server to master?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we do not report metrics. I do this here for 2 reasons:

  • Convenience. Aggregating the rs metrics is possible and usually done by queries from the db, storing aggregated metrics here is for ease of use.
  • Preparing things for the next PR where I'll add logic to store the reported metrics in-memory and extend the REST service to allow checking these values without having to access the metrics db.

@Apache9

Copy link
Copy Markdown
Contributor

Any updates here?

Thanks.

Apache9and others added 14 commits November 27, 2021 22:53
…racking logic
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
…g from different store file tracker implementations (apache#3656)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…iptor when creating table (apache#3666)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
… file tracker implementation (apache#3665)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
… tracker (apache#3681)
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
apache#3721)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
…et method (apache#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
… impl (apache#3749)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
…ations to TableDescriptor for existing tables (apache#3700)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
…he#3786)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
@Apache9

Copy link
Copy Markdown
Contributor

I've rebased HBASE-26067 to the newest master. For addressing the UT problem so we can run most of UTs in the nightly job.

Please rebase the PR.

Thanks.

wchevreuiland others added 3 commits December 2, 2021 14:38
)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
add rs metricsfor BrokenStoreFileCleaner
aggregate the rs metrics on master for easier access
@BukrosSzabolcs

Copy link
Copy Markdown
ContributorAuthor

@Apache9 Sorry for the slow response I was sick

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 1sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 35sMaven dependency ordering for branch
+1 💚mvninstall4m 31sHBASE-26067 passed
+1 💚compile5m 32sHBASE-26067 passed
+1 💚checkstyle1m 34sHBASE-26067 passed
+1 💚spotbugs7m 23sHBASE-26067 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 16sthe patch passed
+1 💚compile5m 29sthe patch passed
+1 💚cc5m 29sthe patch passed
-0 ⚠️javac0m 28shbase-hadoop-compat generated 5 new + 98 unchanged - 5 fixed = 103 total (was 103)
-0 ⚠️checkstyle0m 13shbase-hadoop-compat: The patch generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0)
-0 ⚠️checkstyle1m 11shbase-server: The patch generated 6 new + 101 unchanged - 3 fixed = 107 total (was 104)
-0 ⚠️whitespace0m 0sThe patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck21m 26sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚hbaseprotoc2m 4sthe patch passed
+1 💚spotbugs7m 56sthe patch passed
_ Other Tests _
+1 💚asflicense0m 33sThe patch does not generate ASF License warnings.
73m 30s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux b3fd22f0847c 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / d24e09d
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-hadoop-compat.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-hadoop-compat.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 37sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall5m 19sHBASE-26067 passed
+1 💚compile2m 43sHBASE-26067 passed
+1 💚shadedjars9m 9sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 16sHBASE-26067 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall5m 4sthe patch passed
+1 💚compile2m 42sthe patch passed
+1 💚javac2m 42sthe patch passed
+1 💚shadedjars9m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 15sthe patch passed
_ Other Tests _
+1 💚unit1m 4shbase-protocol-shaded in the patch passed.
+1 💚unit0m 46shbase-hadoop-compat in the patch passed.
+1 💚unit211m 38shbase-server in the patch passed.
255m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d55a106303cf 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / d24e09d
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/testReport/
Max. process+thread count3521 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall5m 16sHBASE-26067 passed
+1 💚compile2m 36sHBASE-26067 passed
+1 💚shadedjars10m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 23sHBASE-26067 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall5m 7sthe patch passed
+1 💚compile2m 38sthe patch passed
+1 💚javac2m 38sthe patch passed
+1 💚shadedjars10m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 23sthe patch passed
_ Other Tests _
+1 💚unit0m 57shbase-protocol-shaded in the patch passed.
+1 💚unit0m 51shbase-hadoop-compat in the patch passed.
-1 ❌unit264m 40shbase-server in the patch failed.
309m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsjavac javadoc unit shadedjars compile
unameLinux eb9a6b953b11 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / d24e09d
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/testReport/
Max. process+thread count3153 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
Contributor

@Apache9 Sorry for the slow response I was sick

Oh, sorry...
No horry, hope you are well~

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 6sHBASE-26067 passed
+1 💚compile5m 17sHBASE-26067 passed
+1 💚checkstyle1m 34sHBASE-26067 passed
+1 💚spotbugs6m 37sHBASE-26067 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile5m 9sthe patch passed
+1 💚cc5m 9sthe patch passed
+1 💚javac5m 9sthe patch passed
-0 ⚠️checkstyle1m 7shbase-server: The patch generated 1 new + 101 unchanged - 3 fixed = 102 total (was 104)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck19m 23sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚hbaseprotoc2m 1sthe patch passed
+1 💚spotbugs7m 14sthe patch passed
_ Other Tests _
+1 💚asflicense0m 40sThe patch does not generate ASF License warnings.
67m 43s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 2f4f6b28feb7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / d24e09d
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall4m 30sHBASE-26067 passed
+1 💚compile2m 35sHBASE-26067 passed
+1 💚shadedjars8m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 18sHBASE-26067 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 27sthe patch passed
+1 💚compile2m 33sthe patch passed
+1 💚javac2m 33sthe patch passed
+1 💚shadedjars8m 19spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 16sthe patch passed
_ Other Tests _
+1 💚unit1m 2shbase-protocol-shaded in the patch passed.
+1 💚unit0m 39shbase-hadoop-compat in the patch passed.
+1 💚unit145m 35shbase-server in the patch passed.
184m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a0d645606ff8 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / d24e09d
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/3/testReport/
Max. process+thread count3825 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 22sHBASE-26067 passed
+1 💚compile2m 17sHBASE-26067 passed
+1 💚shadedjars9m 5sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 14sHBASE-26067 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 3sthe patch passed
+1 💚compile2m 14sthe patch passed
+1 💚javac2m 14sthe patch passed
+1 💚shadedjars8m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 12sthe patch passed
_ Other Tests _
+1 💚unit0m 53shbase-protocol-shaded in the patch passed.
+1 💚unit0m 37shbase-hadoop-compat in the patch passed.
+1 💚unit152m 40shbase-server in the patch passed.
190m 28s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 43ef1232605d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / d24e09d
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/3/testReport/
Max. process+thread count4164 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9and others added 14 commits December 7, 2021 00:00
…racking logic
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
…g from different store file tracker implementations (apache#3656)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
…iptor when creating table (apache#3666)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
… file tracker implementation (apache#3665)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
… tracker (apache#3681)
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Reviewed-by: Josh Elser <elserj@apache.org>
apache#3721)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
…et method (apache#3774)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
… impl (apache#3749)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
…ations to TableDescriptor for existing tables (apache#3700)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
…he#3786)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
Signed-off-by: Wellington Ramos Chevreuil <wchevreuil@apache.org>
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 57sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall4m 26sHBASE-26067 passed
+1 💚compile5m 20sHBASE-26067 passed
+1 💚checkstyle1m 35sHBASE-26067 passed
+1 💚spotbugs7m 1sHBASE-26067 passed
-0 ⚠️patch2m 32sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 12sthe patch passed
+1 💚compile5m 17sthe patch passed
+1 💚cc5m 17sthe patch passed
+1 💚javac5m 17sthe patch passed
-0 ⚠️checkstyle1m 13shbase-server: The patch generated 1 new + 101 unchanged - 3 fixed = 102 total (was 104)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck21m 11sPatch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚hbaseprotoc2m 0sthe patch passed
+1 💚spotbugs7m 32sthe patch passed
_ Other Tests _
+1 💚asflicense0m 34sThe patch does not generate ASF License warnings.
76m 37s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
unameLinux 8e359fd6e758 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 4aa3f47
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 41sHBASE-26067 passed
+1 💚compile2m 36sHBASE-26067 passed
+1 💚shadedjars8m 27sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 19sHBASE-26067 passed
-0 ⚠️patch10m 23sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall4m 27sthe patch passed
+1 💚compile2m 35sthe patch passed
+1 💚javac2m 35sthe patch passed
+1 💚shadedjars8m 18spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 16sthe patch passed
_ Other Tests _
+1 💚unit1m 2shbase-protocol-shaded in the patch passed.
+1 💚unit0m 40shbase-hadoop-compat in the patch passed.
+1 💚unit142m 44shbase-server in the patch passed.
182m 5s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsjavac javadoc unit shadedjars compile
unameLinux bd2cf384e862 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 4aa3f47
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/4/testReport/
Max. process+thread count4076 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 37sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-26067 Compile Tests _
+0 🆗mvndep0m 28sMaven dependency ordering for branch
+1 💚mvninstall3m 51sHBASE-26067 passed
+1 💚compile2m 7sHBASE-26067 passed
+1 💚shadedjars8m 19sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sHBASE-26067 passed
-0 ⚠️patch10m 4sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall3m 54sthe patch passed
+1 💚compile2m 11sthe patch passed
+1 💚javac2m 11sthe patch passed
+1 💚shadedjars8m 20spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 10sthe patch passed
_ Other Tests _
+1 💚unit0m 45shbase-protocol-shaded in the patch passed.
+1 💚unit0m 38shbase-hadoop-compat in the patch passed.
+1 💚unit158m 16shbase-server in the patch passed.
200m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3861
JIRA IssueHBASE-26441
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3e26c9f26043 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionHBASE-26067 / 4aa3f47
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/4/testReport/
Max. process+thread count4920 (vs. ulimit of 30000)
modulesC: hbase-protocol-shaded hbase-hadoop-compat hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3861/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@BukrosSzabolcs

Copy link
Copy Markdown
ContributorAuthor

@Apache9 The failing unit test is unrelated it works just fine for me. Do you have any other feedback or can we wrap this up?

@Apache9
Apache9 deleted the branch apache:HBASE-26067May 4, 2022 05:01
@Apache9Apache9 closed this May 4, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@BukrosSzabolcs@Apache-HBase@Apache9@wchevreuil@GeorryHuang