Skip to content

fix(Docs) redirect and deprecate old metrics pages - #14602

Merged
sergical merged 7 commits into
masterfrom
sergiydybskiy/devex-102-deprecated-generic-metrics-pages
Aug 11, 2025
Merged

fix(Docs) redirect and deprecate old metrics pages#14602
sergical merged 7 commits into
masterfrom
sergiydybskiy/devex-102-deprecated-generic-metrics-pages

Conversation

@sergical

@sergicalsergical commented Aug 8, 2025

Copy link
Copy Markdown
Member

DESCRIBE YOUR PR

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@linear

linearBot commented Aug 8, 2025

Copy link
Copy Markdown

@vercel

vercelBot commented Aug 8, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
develop-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 8, 2025 10:49pm
sentry-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 8, 2025 10:49pm

@codecov

codecovBot commented Aug 8, 2025

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 566 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle nameSizeChange
sentry-docs-edge-server-array-push351.69kB142 bytes (0.04%) ⬆️
sentry-docs-client-array-push9.85MB-6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs12.37MB-702 bytes (-0.01%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-edge-server-array-push

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
src/middleware.js142 bytes206.97kB0.07%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
static/chunks/pages/_app-*.js-3 bytes882.71kB-0.0%
static/chunks/8321-*.js-3 bytes425.87kB-0.0%
server/middleware-*.js5.55kB6.55kB555.3% ⚠️
server/middleware-*.js-5.55kB1.0kB-84.74%
static/k4k4zm8BolyAGsPtCwT7o/_buildManifest.js(New)684 bytes684 bytes100.0% 🚀
static/k4k4zm8BolyAGsPtCwT7o/_ssgManifest.js(New)77 bytes77 bytes100.0% 🚀
static/Y_Ge8RttZxzBllCkofes7/_buildManifest.js(Deleted)-684 bytes0 bytes-100.0% 🗑️
static/Y_Ge8RttZxzBllCkofes7/_ssgManifest.js(Deleted)-77 bytes0 bytes-100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
1729.js-3 bytes1.77MB-0.0%
../instrumentation.js-3 bytes1.1MB-0.0%
9523.js-3 bytes1.08MB-0.0%
../app/[[...path]]/page.js.nft.json-231 bytes744.23kB-0.03%
../app/platform-redirect/page.js.nft.json-231 bytes744.14kB-0.03%
../app/sitemap.xml/route.js.nft.json-231 bytes741.61kB-0.03%

@codeowner-assignment
codeowner-assignmentBot requested review from a teamAugust 8, 2025 20:42
cursor[bot]

This comment was marked as outdated.

Comment threadsrc/middleware.ts Outdated
Comment on lines 1648 to 1649
to: '//concepts/key-terms/tracing/span-metrics/',
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The Android metrics redirect URL in `src/middleware.ts` has an extra leading slash, causing it to become a protocol-relative URL and redirect to a non-existent external domain.
  • Description: The redirect configuration for /platforms/android/metrics/ incorrectly specifies the destination as //concepts/key-terms/tracing/span-metrics/. The double slash // causes the URL constructor to create a protocol-relative URL. This results in an attempt to redirect users to an external, non-existent domain like https://concepts/... instead of the intended internal documentation page. This breaks the redirect functionality for users trying to access the deprecated Android metrics documentation.
  • Suggested fix: In src/middleware.ts, change the to value for the Android metrics redirect from '//concepts/key-terms/tracing/span-metrics/' to '/concepts/key-terms/tracing/span-metrics/'. This will make it a standard relative path, consistent with other redirects in the file.
    severity: 0.6, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

Comment threadsrc/middleware.ts
Comment threadsrc/middleware.ts

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@sergical
sergical merged commit 731278e into masterAug 11, 2025
15 checks passed
@sergical
sergical deleted the sergiydybskiy/devex-102-deprecated-generic-metrics-pages branch August 11, 2025 13:51
codyde added a commit that referenced this pull request Aug 13, 2025
* 'master' of https://github.com/getsentry/sentry-docs: (22 commits)
Fix incorrectly placed comma (#14592)
fix(devservices): Typo in devservices docs (#14636)
ref(ourlogs): Add log size limit (#14635)
Document undocumented php prefix option (#14634)
getsentry/relay@7958273
Unreal Engine: Update plugin docs (#14624)
feat: Update min js sdk version for logging and update console logging snippet (#14614)
feat: [Unreal] Add transaction and span set_data documentation (#14599)
feat(js): Add `ignoreSpans` documentation to Options page (#14572)
fix(js/browser): Amend user IP + `sendDefaultPii` change to v10 migration guide (#14609)
fix: Fix broken AI banner due to invalid syntax (#14627)
feat(partners)add-enablement-docs (#14095)
Fix image path issue & add test coverage for new lightbox (#14616)
feat(seer): update GHE setup to work with seer (#14617)
fix(replay): Document searchable properties `screen` and alias `screens` (#14603)
Update image handling (#14564)
Update using-hooks.mdx (#14605)
Godot: Document `disabled-in-editor-play` option (#14438)
fix(Docs) redirect and deprecate old metrics pages (#14602)
fix(relay): Update projects.mdx (#14606)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 27, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sergical@chargome