Inject trace context into AWS Step Functions input

[DylanLovesCoffee]

What Does This Do

Adds an instrumentation for AWS SDK Step Functions. This enables tracing for when a Lambda function invokes a Step Function. Trace context is injected into the Step Function's StartExecutionRequest/StartSyncExecutionRequest.Input object.

Example of traced step function in the Serverless org: app

The Logs to Traces Reducer will read the trace context from the Step Function logs and create a span for the Step Function.

Motivation

Continues the work done in Python and NodeJS.

Additional Notes

Screenshots of feature:

Contributor Checklist

• Format the title according the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any usefull labels
• Squash your commits prior merging or merge using GitHub's Squash and merge
• Don't use close, fix or any linking keywords when referencing an issue.
  Use solves instead, and assign the PR milestone to the issue
• Update the public documentation in case of new configuration flag or behavior

Jira ticket: [SVLS-5249](https://datadoghq.atlassian.net/browse/SVLS-5249)

[amarziali]

Using reflection is not efficient and should be avoided. Instead, MethodHandles can be used.
The pull request lacks also of a minimum test coverage. Test must be added

[pr-commenter]

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	dylan/sfn-trace-ctx
git_commit_date	1739895801	1739897266
git_commit_sha	0ba7b76	0f304c7
release_version	1.47.0-SNAPSHOT~0ba7b76f47	1.47.0-SNAPSHOT~0f304c70e2

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739899723	1739899723
ci_job_id	812393942	812393942
ci_pipeline_id	56180929	56180929
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-pf96l-bk-project-304-concurrent-0-gjr7nd5n 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-pf96l-bk-project-304-concurrent-0-gjr7nd5n 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~0f304c70e2, baseline=1.47.0-SNAPSHOT~0ba7b76f47
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046545
Total [baseline] (10.481 s) : 0, 10480652
Agent [candidate] (1.039 s) : 0, 1039401
Total [candidate] (10.404 s) : 0, 10404299
section appsec
Agent [baseline] (1.19 s) : 0, 1190476
Total [baseline] (10.77 s) : 0, 10770225
Agent [candidate] (1.186 s) : 0, 1186132
Total [candidate] (10.793 s) : 0, 10792992
section iast
Agent [baseline] (1.178 s) : 0, 1178280
Total [baseline] (11.118 s) : 0, 11117690
Agent [candidate] (1.177 s) : 0, 1177372
Total [candidate] (11.072 s) : 0, 11072120
section profiling
Agent [baseline] (1.267 s) : 0, 1266717
Total [baseline] (10.897 s) : 0, 10897019
Agent [candidate] (1.273 s) : 0, 1273115
Total [candidate] (10.942 s) : 0, 10942347

Loading

• baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	appsec	1.19 s	143.931 ms (13.8%)
Agent	iast	1.178 s	131.735 ms (12.6%)
Agent	profiling	1.267 s	220.172 ms (21.0%)
Total	tracing	10.481 s	-
Total	appsec	10.77 s	289.573 ms (2.8%)
Total	iast	11.118 s	637.038 ms (6.1%)
Total	profiling	10.897 s	416.367 ms (4.0%)

• candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.039 s	-
Agent	appsec	1.186 s	146.731 ms (14.1%)
Agent	iast	1.177 s	137.971 ms (13.3%)
Agent	profiling	1.273 s	233.714 ms (22.5%)
Total	tracing	10.404 s	-
Total	appsec	10.793 s	388.694 ms (3.7%)
Total	iast	11.072 s	667.822 ms (6.4%)
Total	profiling	10.942 s	538.048 ms (5.2%)

gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~0f304c70e2, baseline=1.47.0-SNAPSHOT~0ba7b76f47
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.382 ms) : 0, 722382
BytebuddyAgent [candidate] (716.243 ms) : 0, 716243
GlobalTracer [baseline] (240.886 ms) : 0, 240886
GlobalTracer [candidate] (239.144 ms) : 0, 239144
AppSec [baseline] (55.76 ms) : 0, 55760
AppSec [candidate] (55.169 ms) : 0, 55169
Remote Config [baseline] (706.304 µs) : 0, 706
Remote Config [candidate] (699.777 µs) : 0, 700
Telemetry [baseline] (11.489 ms) : 0, 11489
Telemetry [candidate] (12.98 ms) : 0, 12980
section appsec
BytebuddyAgent [baseline] (739.239 ms) : 0, 739239
BytebuddyAgent [candidate] (736.343 ms) : 0, 736343
GlobalTracer [baseline] (238.36 ms) : 0, 238360
GlobalTracer [candidate] (236.875 ms) : 0, 236875
AppSec [baseline] (177.686 ms) : 0, 177686
AppSec [candidate] (177.874 ms) : 0, 177874
Remote Config [baseline] (677.253 µs) : 0, 677
Remote Config [candidate] (659.977 µs) : 0, 660
Telemetry [baseline] (8.301 ms) : 0, 8301
Telemetry [candidate] (8.268 ms) : 0, 8268
IAST [baseline] (21.728 ms) : 0, 21728
IAST [candidate] (21.623 ms) : 0, 21623
section iast
BytebuddyAgent [baseline] (841.327 ms) : 0, 841327
BytebuddyAgent [candidate] (839.209 ms) : 0, 839209
GlobalTracer [baseline] (231.326 ms) : 0, 231326
GlobalTracer [candidate] (232.179 ms) : 0, 232179
AppSec [baseline] (57.754 ms) : 0, 57754
AppSec [candidate] (57.894 ms) : 0, 57894
Remote Config [baseline] (617.929 µs) : 0, 618
Remote Config [candidate] (627.842 µs) : 0, 628
Telemetry [baseline] (8.77 ms) : 0, 8770
Telemetry [candidate] (8.888 ms) : 0, 8888
IAST [baseline] (23.008 ms) : 0, 23008
IAST [candidate] (23.321 ms) : 0, 23321
section profiling
ProfilingAgent [baseline] (96.867 ms) : 0, 96867
ProfilingAgent [candidate] (97.644 ms) : 0, 97644
BytebuddyAgent [baseline] (710.447 ms) : 0, 710447
BytebuddyAgent [candidate] (715.131 ms) : 0, 715131
GlobalTracer [baseline] (351.783 ms) : 0, 351783
GlobalTracer [candidate] (352.779 ms) : 0, 352779
AppSec [baseline] (55.592 ms) : 0, 55592
AppSec [candidate] (54.898 ms) : 0, 54898
Remote Config [baseline] (682.048 µs) : 0, 682
Remote Config [candidate] (681.871 µs) : 0, 682
Telemetry [baseline] (8.968 ms) : 0, 8968
Telemetry [candidate] (9.046 ms) : 0, 9046
Profiling [baseline] (96.891 ms) : 0, 96891
Profiling [candidate] (97.668 ms) : 0, 97668

Loading

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~0f304c70e2, baseline=1.47.0-SNAPSHOT~0ba7b76f47
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043443
Total [baseline] (8.641 s) : 0, 8640975
Agent [candidate] (1.04 s) : 0, 1040116
Total [candidate] (8.626 s) : 0, 8625758
section iast
Agent [baseline] (1.17 s) : 0, 1170028
Total [baseline] (9.277 s) : 0, 9277333
Agent [candidate] (1.177 s) : 0, 1177434
Total [candidate] (9.328 s) : 0, 9328304
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170831
Total [baseline] (9.274 s) : 0, 9274286
Agent [candidate] (1.171 s) : 0, 1170518
Total [candidate] (9.213 s) : 0, 9213331
section iast_TELEMETRY_OFF
Agent [baseline] (1.165 s) : 0, 1165307
Total [baseline] (9.22 s) : 0, 9220210
Agent [candidate] (1.167 s) : 0, 1166916
Total [candidate] (9.26 s) : 0, 9260403

Loading

• baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	iast	1.17 s	126.585 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.171 s	127.387 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.165 s	121.863 ms (11.7%)
Total	tracing	8.641 s	-
Total	iast	9.277 s	636.358 ms (7.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.274 s	633.312 ms (7.3%)
Total	iast_TELEMETRY_OFF	9.22 s	579.235 ms (6.7%)

• candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	iast	1.177 s	137.318 ms (13.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.171 s	130.402 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.167 s	126.8 ms (12.2%)
Total	tracing	8.626 s	-
Total	iast	9.328 s	702.546 ms (8.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.213 s	587.573 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.26 s	634.645 ms (7.4%)

gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~0f304c70e2, baseline=1.47.0-SNAPSHOT~0ba7b76f47
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.209 ms) : 0, 718209
BytebuddyAgent [candidate] (717.201 ms) : 0, 717201
GlobalTracer [baseline] (240.21 ms) : 0, 240210
GlobalTracer [candidate] (239.43 ms) : 0, 239430
AppSec [baseline] (56.256 ms) : 0, 56256
AppSec [candidate] (55.421 ms) : 0, 55421
Remote Config [baseline] (695.784 µs) : 0, 696
Remote Config [candidate] (692.699 µs) : 0, 693
Telemetry [baseline] (12.872 ms) : 0, 12872
Telemetry [candidate] (12.18 ms) : 0, 12180
section iast
BytebuddyAgent [baseline] (834.498 ms) : 0, 834498
BytebuddyAgent [candidate] (840.02 ms) : 0, 840020
GlobalTracer [baseline] (230.838 ms) : 0, 230838
GlobalTracer [candidate] (232.267 ms) : 0, 232267
IAST [baseline] (22.795 ms) : 0, 22795
IAST [candidate] (22.961 ms) : 0, 22961
AppSec [baseline] (57.255 ms) : 0, 57255
AppSec [candidate] (57.49 ms) : 0, 57490
Remote Config [baseline] (619.376 µs) : 0, 619
Remote Config [candidate] (618.436 µs) : 0, 618
Telemetry [baseline] (8.712 ms) : 0, 8712
Telemetry [candidate] (8.779 ms) : 0, 8779
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.413 ms) : 0, 834413
BytebuddyAgent [candidate] (835.558 ms) : 0, 835558
GlobalTracer [baseline] (230.972 ms) : 0, 230972
GlobalTracer [candidate] (230.506 ms) : 0, 230506
IAST [baseline] (22.932 ms) : 0, 22932
IAST [candidate] (22.723 ms) : 0, 22723
AppSec [baseline] (57.811 ms) : 0, 57811
AppSec [candidate] (57.174 ms) : 0, 57174
Remote Config [baseline] (619.165 µs) : 0, 619
Remote Config [candidate] (599.033 µs) : 0, 599
Telemetry [baseline] (8.861 ms) : 0, 8861
Telemetry [candidate] (8.629 ms) : 0, 8629
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.665 ms) : 0, 831665
BytebuddyAgent [candidate] (833.126 ms) : 0, 833126
GlobalTracer [baseline] (229.675 ms) : 0, 229675
GlobalTracer [candidate] (229.83 ms) : 0, 229830
IAST [baseline] (25.483 ms) : 0, 25483
IAST [candidate] (23.625 ms) : 0, 23625
AppSec [baseline] (54.02 ms) : 0, 54020
AppSec [candidate] (55.773 ms) : 0, 55773
Remote Config [baseline] (630.322 µs) : 0, 630
Remote Config [candidate] (615.01 µs) : 0, 615
Telemetry [baseline] (8.6 ms) : 0, 8600
Telemetry [candidate] (8.644 ms) : 0, 8644

Loading

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-18T16:58:35	2025-02-18T17:05:39
git_branch	master	dylan/sfn-trace-ctx
git_commit_date	1739895801	1739897266
git_commit_sha	0ba7b76	0f304c7
release_version	1.47.0-SNAPSHOT~0ba7b76f47	1.47.0-SNAPSHOT~0f304c70e2
start_time	2025-02-18T16:58:20	2025-02-18T17:05:25

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739898701	1739898701
ci_job_id	812393943	812393943
ci_pipeline_id	56180929	56180929
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-tsbfvevz-project-304-concurrent-0-fyx1n6o0 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-tsbfvevz-project-304-concurrent-0-fyx1n6o0 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	worse [+34.983µs; +89.086µs] or [+2.286%; +5.821%]	unstable [-574.972op/s; +574.972op/s] or [-19.405%; +19.405%]	1.592ms	2962.963op/s	1.530ms	2962.963op/s

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~0f304c70e2, baseline=1.47.0-SNAPSHOT~0ba7b76f47
dateFormat X
axisFormat %s
section baseline
no_agent (378.684 µs) : 359, 399
. : milestone, 379,
iast (518.91 µs) : 497, 541
. : milestone, 519,
iast_FULL (727.718 µs) : 706, 750
. : milestone, 728,
iast_GLOBAL (560.072 µs) : 538, 582
. : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (513.96 µs) : 491, 537
. : milestone, 514,
iast_INACTIVE (460.46 µs) : 439, 482
. : milestone, 460,
iast_TELEMETRY_OFF (501.622 µs) : 478, 525
. : milestone, 502,
tracing (456.374 µs) : 436, 477
. : milestone, 456,
section candidate
no_agent (377.078 µs) : 357, 397
. : milestone, 377,
iast (517.392 µs) : 495, 540
. : milestone, 517,
iast_FULL (730.088 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (571.721 µs) : 548, 596
. : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (514.872 µs) : 492, 537
. : milestone, 515,
iast_INACTIVE (464.346 µs) : 443, 486
. : milestone, 464,
iast_TELEMETRY_OFF (500.604 µs) : 479, 522
. : milestone, 501,
tracing (461.627 µs) : 440, 483
. : milestone, 462,

Loading

• baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	378.684 µs [358.75 µs, 398.619 µs]	-
iast	518.91 µs [496.744 µs, 541.075 µs]	140.225 µs (37.0%)
iast_FULL	727.718 µs [705.515 µs, 749.922 µs]	349.034 µs (92.2%)
iast_GLOBAL	560.072 µs [538.193 µs, 581.952 µs]	181.388 µs (47.9%)
iast_HARDCODED_SECRET_DISABLED	513.96 µs [490.918 µs, 537.002 µs]	135.275 µs (35.7%)
iast_INACTIVE	460.46 µs [438.626 µs, 482.294 µs]	81.775 µs (21.6%)
iast_TELEMETRY_OFF	501.622 µs [478.287 µs, 524.957 µs]	122.938 µs (32.5%)
tracing	456.374 µs [435.711 µs, 477.037 µs]	77.689 µs (20.5%)

• candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.078 µs [357.255 µs, 396.9 µs]	-
iast	517.392 µs [494.684 µs, 540.099 µs]	140.314 µs (37.2%)
iast_FULL	730.088 µs [708.053 µs, 752.123 µs]	353.011 µs (93.6%)
iast_GLOBAL	571.721 µs [547.731 µs, 595.711 µs]	194.643 µs (51.6%)
iast_HARDCODED_SECRET_DISABLED	514.872 µs [492.443 µs, 537.3 µs]	137.794 µs (36.5%)
iast_INACTIVE	464.346 µs [442.828 µs, 485.863 µs]	87.268 µs (23.1%)
iast_TELEMETRY_OFF	500.604 µs [478.831 µs, 522.378 µs]	123.527 µs (32.8%)
tracing	461.627 µs [440.312 µs, 482.942 µs]	84.549 µs (22.4%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~0f304c70e2, baseline=1.47.0-SNAPSHOT~0ba7b76f47
dateFormat X
axisFormat %s
section baseline
no_agent (1.364 ms) : 1345, 1384
. : milestone, 1364,
appsec (1.737 ms) : 1713, 1761
. : milestone, 1737,
appsec_no_iast (1.767 ms) : 1744, 1790
. : milestone, 1767,
iast (1.516 ms) : 1492, 1540
. : milestone, 1516,
profiling (1.53 ms) : 1505, 1555
. : milestone, 1530,
tracing (1.499 ms) : 1475, 1524
. : milestone, 1499,
section candidate
no_agent (1.358 ms) : 1339, 1377
. : milestone, 1358,
appsec (1.768 ms) : 1744, 1792
. : milestone, 1768,
appsec_no_iast (1.776 ms) : 1753, 1799
. : milestone, 1776,
iast (1.526 ms) : 1502, 1550
. : milestone, 1526,
profiling (1.592 ms) : 1567, 1618
. : milestone, 1592,
tracing (1.487 ms) : 1462, 1512
. : milestone, 1487,

Loading

• baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.364 ms [1.345 ms, 1.384 ms]	-
appsec	1.737 ms [1.713 ms, 1.761 ms]	372.673 µs (27.3%)
appsec_no_iast	1.767 ms [1.744 ms, 1.79 ms]	402.511 µs (29.5%)
iast	1.516 ms [1.492 ms, 1.54 ms]	151.887 µs (11.1%)
profiling	1.53 ms [1.505 ms, 1.555 ms]	166.0 µs (12.2%)
tracing	1.499 ms [1.475 ms, 1.524 ms]	135.073 µs (9.9%)

• candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.358 ms [1.339 ms, 1.377 ms]	-
appsec	1.768 ms [1.744 ms, 1.792 ms]	410.283 µs (30.2%)
appsec_no_iast	1.776 ms [1.753 ms, 1.799 ms]	418.22 µs (30.8%)
iast	1.526 ms [1.502 ms, 1.55 ms]	168.543 µs (12.4%)
profiling	1.592 ms [1.567 ms, 1.618 ms]	234.488 µs (17.3%)
tracing	1.487 ms [1.462 ms, 1.512 ms]	128.995 µs (9.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	dylan/sfn-trace-ctx
git_commit_date	1739895801	1739897266
git_commit_sha	0ba7b76	0f304c7
release_version	1.47.0-SNAPSHOT~0ba7b76f47	1.47.0-SNAPSHOT~0f304c70e2

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1739899330	1739899330
ci_job_id	812393945	812393945
ci_pipeline_id	56180929	56180929
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-wxk4-4f-project-304-concurrent-1-388lq479 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-wxk4-4f-project-304-concurrent-1-388lq479 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~0f304c70e2, baseline=1.47.0-SNAPSHOT~0ba7b76f47
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.381 ms) : 2337, 2424
. : milestone, 2381,
iast (2.127 ms) : 2072, 2183
. : milestone, 2127,
iast_GLOBAL (2.166 ms) : 2110, 2221
. : milestone, 2166,
profiling (1.969 ms) : 1925, 2013
. : milestone, 1969,
tracing (1.955 ms) : 1913, 1997
. : milestone, 1955,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.369 ms) : 2325, 2412
. : milestone, 2369,
iast (2.129 ms) : 2074, 2184
. : milestone, 2129,
iast_GLOBAL (2.159 ms) : 2103, 2214
. : milestone, 2159,
profiling (1.963 ms) : 1920, 2006
. : milestone, 1963,
tracing (1.961 ms) : 1919, 2004
. : milestone, 1961,

Loading

• baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.381 ms [2.337 ms, 2.424 ms]	904.526 µs (61.3%)
iast	2.127 ms [2.072 ms, 2.183 ms]	650.913 µs (44.1%)
iast_GLOBAL	2.166 ms [2.11 ms, 2.221 ms]	689.144 µs (46.7%)
profiling	1.969 ms [1.925 ms, 2.013 ms]	492.654 µs (33.4%)
tracing	1.955 ms [1.913 ms, 1.997 ms]	478.332 µs (32.4%)

• candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.464 ms, 1.487 ms]	-
appsec	2.369 ms [2.325 ms, 2.412 ms]	893.557 µs (60.6%)
iast	2.129 ms [2.074 ms, 2.184 ms]	654.197 µs (44.3%)
iast_GLOBAL	2.159 ms [2.103 ms, 2.214 ms]	683.734 µs (46.3%)
profiling	1.963 ms [1.92 ms, 2.006 ms]	487.8 µs (33.1%)
tracing	1.961 ms [1.919 ms, 2.004 ms]	486.152 µs (33.0%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~0f304c70e2, baseline=1.47.0-SNAPSHOT~0ba7b76f47
dateFormat X
axisFormat %s
section baseline
no_agent (14.792 s) : 14792000, 14792000
. : milestone, 14792000,
appsec (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
iast (18.913 s) : 18913000, 18913000
. : milestone, 18913000,
iast_GLOBAL (17.864 s) : 17864000, 17864000
. : milestone, 17864000,
profiling (15.125 s) : 15125000, 15125000
. : milestone, 15125000,
tracing (14.984 s) : 14984000, 14984000
. : milestone, 14984000,
section candidate
no_agent (15.457 s) : 15457000, 15457000
. : milestone, 15457000,
appsec (14.983 s) : 14983000, 14983000
. : milestone, 14983000,
iast (18.338 s) : 18338000, 18338000
. : milestone, 18338000,
iast_GLOBAL (18.018 s) : 18018000, 18018000
. : milestone, 18018000,
profiling (15.247 s) : 15247000, 15247000
. : milestone, 15247000,
tracing (14.944 s) : 14944000, 14944000
. : milestone, 14944000,

Loading

• baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.792 s [14.792 s, 14.792 s]	-
appsec	15.016 s [15.016 s, 15.016 s]	224.0 ms (1.5%)
iast	18.913 s [18.913 s, 18.913 s]	4.121 s (27.9%)
iast_GLOBAL	17.864 s [17.864 s, 17.864 s]	3.072 s (20.8%)
profiling	15.125 s [15.125 s, 15.125 s]	333.0 ms (2.3%)
tracing	14.984 s [14.984 s, 14.984 s]	192.0 ms (1.3%)

• candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.457 s [15.457 s, 15.457 s]	-
appsec	14.983 s [14.983 s, 14.983 s]	-474.0 ms (-3.1%)
iast	18.338 s [18.338 s, 18.338 s]	2.881 s (18.6%)
iast_GLOBAL	18.018 s [18.018 s, 18.018 s]	2.561 s (16.6%)
profiling	15.247 s [15.247 s, 15.247 s]	-210.0 ms (-1.4%)
tracing	14.944 s [14.944 s, 14.944 s]	-513.0 ms (-3.3%)

[PerfectSlayer]

I left a bunch of comments about refactoring and testing

[PerfectSlayer]

Can be deduplicated using a dedicated method:

SdkRequestinjectTraceContext(request, span) {
StringtraceContext = InputAttributeInjector.buildTraceContext(span);
// Inject the trace context into the Step Function inputStringmodifiedInput = InputAttributeInjector.getModifiedInput(request.input(), traceContext);
returnrequest.toBuilder().input(modifiedInput).build()
}

[DylanLovesCoffee]

Since I had to handle both StartExecutionRequest and StartSyncExecutionRequest param types I ended up doing method overloading for injectTraceContext()

[DylanLovesCoffee]

@PerfectSlayer I think I covered all of the comments/corrections, but for some reason the CI's muzzle check is continuing to fail :/ It seems like it's mostly timing out, so may be unrelated to my changes?

[dougqh]

I'd like to see the Json construction done in a safer way.
I also think we should guard against exceptions propagating out of the listener.

[nhulston]

Failures appear to be unrelated

[PerfectSlayer]

Looking good from Platform PoV. I will let IDM review instrumentation.

About the failing tests, you can retry them following: https://github.com/DataDog/dd-trace-java/blob/master/docs/how_to_test.md#flaky-tests

[mcculls]

This method could be made more performant with the following approach:

• skip trimming the string before finding { and } to avoid creating an intermediate string
• that would also let you use request.indexOf('{') etc. which is faster
• compare the numerical positions of { and }
  • if they're next to each other, no need to create/trim anything and you can return "{" + DATADOG_KEY + ":" + ddTraceContextJSON + "}"
  • otherwise get the substring between { and } trim it and store it in existingJSON
  • if existingJSON is empty you can return "{" + DATADOG_KEY + ":" + ddTraceContextJSON + "}"
  • otherwise return "{" + existingJSON + "," + DATADOG_KEY + ":" + ddTraceContextJSON + "}"

you could also extract DATADOG_KEY + ":" + ddTraceContextJSON to a local variable to avoid repeating it

[mcculls]

Also I assume we know the original string will always be JSON?

[nhulston]

Yes, the original string must be a JSON string (if empty, it must be {}) in order for AWS to accept the request. However, the user could end up putting an incorrect json string; in that case, we should leave the request unchanged so that the error comes from AWS, not the tracer.

[mcculls]

Thanks for the work on this - I've suggested a couple of final improvements

Changes approved. PR can be merged