Do not generate Muzzle references for primitive arrays in method body by amarziali · Pull Request #8361 · DataDog/dd-trace-java

amarziali · 2025-02-10T10:58:22Z

What Does This Do

If a helper/advice class contains this kind of code:

if (something instanceof byte[]) {
..
}

muzzle will create a reference for B since, for methods, it checks only the underlying type without checking if it's a primitive array [B

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2025-02-10T10:58:34Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

mcculls

good catch

pr-commenter · 2025-02-10T11:37:07Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/muzzle-arrays
git_commit_date	1739182985	1739184987
git_commit_sha	`ca6895a`	`bf6162c`
release_version	1.47.0-SNAPSHOT~ca6895a0a9	1.47.0-SNAPSHOT~bf6162c180

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739187379	1739187379
ci_job_id	800643277	800643277
ci_pipeline_id	55378125	55378125
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-bpvn9ue-project-304-concurrent-0-t9fn7kee 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-bpvn9ue-project-304-concurrent-0-t9fn7kee 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~bf6162c180, baseline=1.47.0-SNAPSHOT~ca6895a0a9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039496
Total [baseline] (8.613 s) : 0, 8613236
Agent [candidate] (1.042 s) : 0, 1042250
Total [candidate] (8.607 s) : 0, 8607127
section iast
Agent [baseline] (1.178 s) : 0, 1177954
Total [baseline] (9.223 s) : 0, 9223192
Agent [candidate] (1.177 s) : 0, 1177151
Total [candidate] (9.184 s) : 0, 9184180
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1179977
Total [baseline] (9.188 s) : 0, 9187576
Agent [candidate] (1.173 s) : 0, 1173109
Total [candidate] (9.202 s) : 0, 9201929
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1177143
Total [baseline] (9.215 s) : 0, 9215424
Agent [candidate] (1.171 s) : 0, 1170827
Total [candidate] (9.214 s) : 0, 9214322

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.039 s	-
Agent	iast	1.178 s	138.459 ms (13.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.18 s	140.482 ms (13.5%)
Agent	iast_TELEMETRY_OFF	1.177 s	137.647 ms (13.2%)
Total	tracing	8.613 s	-
Total	iast	9.223 s	609.956 ms (7.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.188 s	574.34 ms (6.7%)
Total	iast_TELEMETRY_OFF	9.215 s	602.188 ms (7.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	iast	1.177 s	134.901 ms (12.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.173 s	130.859 ms (12.6%)
Agent	iast_TELEMETRY_OFF	1.171 s	128.577 ms (12.3%)
Total	tracing	8.607 s	-
Total	iast	9.184 s	577.053 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.202 s	594.802 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.214 s	607.196 ms (7.1%)

gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~bf6162c180, baseline=1.47.0-SNAPSHOT~ca6895a0a9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.764 ms) : 0, 716764
BytebuddyAgent [candidate] (716.471 ms) : 0, 716471
GlobalTracer [baseline] (242.281 ms) : 0, 242281
GlobalTracer [candidate] (242.803 ms) : 0, 242803
AppSec [baseline] (54.702 ms) : 0, 54702
AppSec [candidate] (54.961 ms) : 0, 54961
Remote Config [baseline] (705.831 µs) : 0, 706
Remote Config [candidate] (728.994 µs) : 0, 729
Telemetry [baseline] (9.916 ms) : 0, 9916
Telemetry [candidate] (12.107 ms) : 0, 12107
section iast
BytebuddyAgent [baseline] (840.242 ms) : 0, 840242
BytebuddyAgent [candidate] (838.522 ms) : 0, 838522
GlobalTracer [baseline] (232.885 ms) : 0, 232885
GlobalTracer [candidate] (233.409 ms) : 0, 233409
IAST [baseline] (22.999 ms) : 0, 22999
IAST [candidate] (22.991 ms) : 0, 22991
AppSec [baseline] (57.271 ms) : 0, 57271
AppSec [candidate] (57.552 ms) : 0, 57552
Remote Config [baseline] (629.066 µs) : 0, 629
Remote Config [candidate] (637.443 µs) : 0, 637
Telemetry [baseline] (8.683 ms) : 0, 8683
Telemetry [candidate] (8.757 ms) : 0, 8757
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.577 ms) : 0, 840577
BytebuddyAgent [candidate] (835.387 ms) : 0, 835387
GlobalTracer [baseline] (234.667 ms) : 0, 234667
GlobalTracer [candidate] (233.552 ms) : 0, 233552
IAST [baseline] (23.025 ms) : 0, 23025
IAST [candidate] (22.864 ms) : 0, 22864
AppSec [baseline] (57.081 ms) : 0, 57081
AppSec [candidate] (56.837 ms) : 0, 56837
Remote Config [baseline] (620.922 µs) : 0, 621
Remote Config [candidate] (617.543 µs) : 0, 618
Telemetry [baseline] (8.684 ms) : 0, 8684
Telemetry [candidate] (8.659 ms) : 0, 8659
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.653 ms) : 0, 838653
BytebuddyAgent [candidate] (834.254 ms) : 0, 834254
GlobalTracer [baseline] (234.76 ms) : 0, 234760
GlobalTracer [candidate] (232.85 ms) : 0, 232850
IAST [baseline] (27.057 ms) : 0, 27057
IAST [candidate] (22.284 ms) : 0, 22284
AppSec [baseline] (52.118 ms) : 0, 52118
AppSec [candidate] (57.036 ms) : 0, 57036
Remote Config [baseline] (619.444 µs) : 0, 619
Remote Config [candidate] (616.76 µs) : 0, 617
Telemetry [baseline] (8.653 ms) : 0, 8653
Telemetry [candidate] (8.551 ms) : 0, 8551

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~bf6162c180, baseline=1.47.0-SNAPSHOT~ca6895a0a9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041158
Total [baseline] (10.566 s) : 0, 10566499
Agent [candidate] (1.04 s) : 0, 1040268
Total [candidate] (10.477 s) : 0, 10476764
section appsec
Agent [baseline] (1.183 s) : 0, 1182851
Total [baseline] (10.712 s) : 0, 10712032
Agent [candidate] (1.195 s) : 0, 1194884
Total [candidate] (10.79 s) : 0, 10789899
section iast
Agent [baseline] (1.188 s) : 0, 1188301
Total [baseline] (10.976 s) : 0, 10976364
Agent [candidate] (1.175 s) : 0, 1174595
Total [candidate] (10.926 s) : 0, 10925994
section profiling
Agent [baseline] (1.269 s) : 0, 1269331
Total [baseline] (10.87 s) : 0, 10870306
Agent [candidate] (1.261 s) : 0, 1261285
Total [candidate] (10.864 s) : 0, 10864111

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	appsec	1.183 s	141.693 ms (13.6%)
Agent	iast	1.188 s	147.143 ms (14.1%)
Agent	profiling	1.269 s	228.173 ms (21.9%)
Total	tracing	10.566 s	-
Total	appsec	10.712 s	145.533 ms (1.4%)
Total	iast	10.976 s	409.865 ms (3.9%)
Total	profiling	10.87 s	303.807 ms (2.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	appsec	1.195 s	154.615 ms (14.9%)
Agent	iast	1.175 s	134.327 ms (12.9%)
Agent	profiling	1.261 s	221.017 ms (21.2%)
Total	tracing	10.477 s	-
Total	appsec	10.79 s	313.135 ms (3.0%)
Total	iast	10.926 s	449.23 ms (4.3%)
Total	profiling	10.864 s	387.346 ms (3.7%)

gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~bf6162c180, baseline=1.47.0-SNAPSHOT~ca6895a0a9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.35 ms) : 0, 716350
BytebuddyAgent [candidate] (715.544 ms) : 0, 715544
GlobalTracer [baseline] (243.322 ms) : 0, 243322
GlobalTracer [candidate] (242.929 ms) : 0, 242929
AppSec [baseline] (54.875 ms) : 0, 54875
AppSec [candidate] (55.182 ms) : 0, 55182
Remote Config [baseline] (709.126 µs) : 0, 709
Remote Config [candidate] (710.689 µs) : 0, 711
Telemetry [baseline] (10.771 ms) : 0, 10771
Telemetry [candidate] (10.683 ms) : 0, 10683
section appsec
BytebuddyAgent [baseline] (732.415 ms) : 0, 732415
BytebuddyAgent [candidate] (740.746 ms) : 0, 740746
GlobalTracer [baseline] (239.626 ms) : 0, 239626
GlobalTracer [candidate] (242.04 ms) : 0, 242040
IAST [baseline] (21.772 ms) : 0, 21772
IAST [candidate] (22.21 ms) : 0, 22210
AppSec [baseline] (175.883 ms) : 0, 175883
AppSec [candidate] (176.676 ms) : 0, 176676
Remote Config [baseline] (652.944 µs) : 0, 653
Remote Config [candidate] (666.877 µs) : 0, 667
Telemetry [baseline] (8.205 ms) : 0, 8205
Telemetry [candidate] (8.324 ms) : 0, 8324
section iast
BytebuddyAgent [baseline] (846.806 ms) : 0, 846806
BytebuddyAgent [candidate] (836.747 ms) : 0, 836747
GlobalTracer [baseline] (235.993 ms) : 0, 235993
GlobalTracer [candidate] (233.583 ms) : 0, 233583
IAST [baseline] (23.306 ms) : 0, 23306
IAST [candidate] (23.044 ms) : 0, 23044
AppSec [baseline] (57.3 ms) : 0, 57300
AppSec [candidate] (56.649 ms) : 0, 56649
Remote Config [baseline] (627.765 µs) : 0, 628
Remote Config [candidate] (619.669 µs) : 0, 620
Telemetry [baseline] (8.719 ms) : 0, 8719
Telemetry [candidate] (8.683 ms) : 0, 8683
section profiling
BytebuddyAgent [baseline] (710.792 ms) : 0, 710792
BytebuddyAgent [candidate] (706.512 ms) : 0, 706512
GlobalTracer [baseline] (353.892 ms) : 0, 353892
GlobalTracer [candidate] (353.473 ms) : 0, 353473
AppSec [baseline] (55.901 ms) : 0, 55901
AppSec [candidate] (54.189 ms) : 0, 54189
Remote Config [baseline] (719.812 µs) : 0, 720
Remote Config [candidate] (704.495 µs) : 0, 704
Telemetry [baseline] (8.901 ms) : 0, 8901
Telemetry [candidate] (8.88 ms) : 0, 8880
ProfilingAgent [baseline] (96.648 ms) : 0, 96648
ProfilingAgent [candidate] (95.267 ms) : 0, 95267
Profiling [baseline] (96.672 ms) : 0, 96672
Profiling [candidate] (95.293 ms) : 0, 95293

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-10T11:08:15	2025-02-10T11:15:18
git_branch	master	andrea.marziali/muzzle-arrays
git_commit_date	1739182985	1739184987
git_commit_sha	`ca6895a`	`bf6162c`
release_version	1.47.0-SNAPSHOT~ca6895a0a9	1.47.0-SNAPSHOT~bf6162c180
start_time	2025-02-10T11:08:01	2025-02-10T11:15:04

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739186475	1739186475
ci_job_id	800643278	800643278
ci_pipeline_id	55378125	55378125
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-6cbfw4b4-project-304-concurrent-0-u8mgh10s 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-6cbfw4b4-project-304-concurrent-0-u8mgh10s 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~bf6162c180, baseline=1.47.0-SNAPSHOT~ca6895a0a9
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1372
. : milestone, 1353,
appsec (1.756 ms) : 1733, 1779
. : milestone, 1756,
appsec_no_iast (1.758 ms) : 1734, 1782
. : milestone, 1758,
iast (1.497 ms) : 1473, 1520
. : milestone, 1497,
profiling (1.508 ms) : 1484, 1532
. : milestone, 1508,
tracing (1.494 ms) : 1469, 1519
. : milestone, 1494,
section candidate
no_agent (1.343 ms) : 1324, 1363
. : milestone, 1343,
appsec (1.754 ms) : 1732, 1777
. : milestone, 1754,
appsec_no_iast (1.742 ms) : 1719, 1765
. : milestone, 1742,
iast (1.516 ms) : 1491, 1540
. : milestone, 1516,
profiling (1.52 ms) : 1495, 1544
. : milestone, 1520,
tracing (1.477 ms) : 1453, 1501
. : milestone, 1477,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.353 ms [1.333 ms, 1.372 ms]	-
appsec	1.756 ms [1.733 ms, 1.779 ms]	403.033 µs (29.8%)
appsec_no_iast	1.758 ms [1.734 ms, 1.782 ms]	405.692 µs (30.0%)
iast	1.497 ms [1.473 ms, 1.52 ms]	144.025 µs (10.6%)
profiling	1.508 ms [1.484 ms, 1.532 ms]	155.558 µs (11.5%)
tracing	1.494 ms [1.469 ms, 1.519 ms]	141.631 µs (10.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.343 ms [1.324 ms, 1.363 ms]	-
appsec	1.754 ms [1.732 ms, 1.777 ms]	411.267 µs (30.6%)
appsec_no_iast	1.742 ms [1.719 ms, 1.765 ms]	399.092 µs (29.7%)
iast	1.516 ms [1.491 ms, 1.54 ms]	172.561 µs (12.8%)
profiling	1.52 ms [1.495 ms, 1.544 ms]	176.471 µs (13.1%)
tracing	1.477 ms [1.453 ms, 1.501 ms]	133.55 µs (9.9%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~bf6162c180, baseline=1.47.0-SNAPSHOT~ca6895a0a9
dateFormat X
axisFormat %s
section baseline
no_agent (381.305 µs) : 361, 401
. : milestone, 381,
iast (509.176 µs) : 488, 531
. : milestone, 509,
iast_FULL (739.428 µs) : 717, 761
. : milestone, 739,
iast_GLOBAL (549.88 µs) : 528, 572
. : milestone, 550,
iast_HARDCODED_SECRET_DISABLED (503.973 µs) : 482, 526
. : milestone, 504,
iast_INACTIVE (453.95 µs) : 433, 475
. : milestone, 454,
iast_TELEMETRY_OFF (490.795 µs) : 469, 513
. : milestone, 491,
tracing (459.6 µs) : 439, 480
. : milestone, 460,
section candidate
no_agent (380.364 µs) : 359, 401
. : milestone, 380,
iast (505.478 µs) : 484, 527
. : milestone, 505,
iast_FULL (740.174 µs) : 718, 762
. : milestone, 740,
iast_GLOBAL (550.532 µs) : 529, 572
. : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (500.345 µs) : 479, 522
. : milestone, 500,
iast_INACTIVE (457.193 µs) : 435, 479
. : milestone, 457,
iast_TELEMETRY_OFF (500.767 µs) : 477, 524
. : milestone, 501,
tracing (458.133 µs) : 437, 479
. : milestone, 458,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.305 µs [361.299 µs, 401.311 µs]	-
iast	509.176 µs [487.62 µs, 530.733 µs]	127.871 µs (33.5%)
iast_FULL	739.428 µs [717.458 µs, 761.398 µs]	358.123 µs (93.9%)
iast_GLOBAL	549.88 µs [528.044 µs, 571.716 µs]	168.575 µs (44.2%)
iast_HARDCODED_SECRET_DISABLED	503.973 µs [482.337 µs, 525.609 µs]	122.668 µs (32.2%)
iast_INACTIVE	453.95 µs [433.066 µs, 474.833 µs]	72.645 µs (19.1%)
iast_TELEMETRY_OFF	490.795 µs [468.542 µs, 513.049 µs]	109.49 µs (28.7%)
tracing	459.6 µs [438.733 µs, 480.467 µs]	78.295 µs (20.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.364 µs [359.475 µs, 401.252 µs]	-
iast	505.478 µs [483.59 µs, 527.366 µs]	125.114 µs (32.9%)
iast_FULL	740.174 µs [718.287 µs, 762.06 µs]	359.81 µs (94.6%)
iast_GLOBAL	550.532 µs [528.599 µs, 572.465 µs]	170.168 µs (44.7%)
iast_HARDCODED_SECRET_DISABLED	500.345 µs [478.852 µs, 521.837 µs]	119.981 µs (31.5%)
iast_INACTIVE	457.193 µs [435.22 µs, 479.166 µs]	76.829 µs (20.2%)
iast_TELEMETRY_OFF	500.767 µs [477.421 µs, 524.114 µs]	120.404 µs (31.7%)
tracing	458.133 µs [436.835 µs, 479.43 µs]	77.769 µs (20.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/muzzle-arrays
git_commit_date	1739182985	1739184987
git_commit_sha	`ca6895a`	`bf6162c`
release_version	1.47.0-SNAPSHOT~ca6895a0a9	1.47.0-SNAPSHOT~bf6162c180

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1739186947	1739186947
ci_job_id	800643279	800643279
ci_pipeline_id	55378125	55378125
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-x7zjttkf-project-304-concurrent-0-yonu6sz5 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-x7zjttkf-project-304-concurrent-0-yonu6sz5 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~bf6162c180, baseline=1.47.0-SNAPSHOT~ca6895a0a9
dateFormat X
axisFormat %s
section baseline
no_agent (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
appsec (14.699 s) : 14699000, 14699000
. : milestone, 14699000,
iast (18.439 s) : 18439000, 18439000
. : milestone, 18439000,
iast_GLOBAL (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
profiling (15.198 s) : 15198000, 15198000
. : milestone, 15198000,
tracing (14.926 s) : 14926000, 14926000
. : milestone, 14926000,
section candidate
no_agent (15.154 s) : 15154000, 15154000
. : milestone, 15154000,
appsec (14.707 s) : 14707000, 14707000
. : milestone, 14707000,
iast (19.083 s) : 19083000, 19083000
. : milestone, 19083000,
iast_GLOBAL (17.926 s) : 17926000, 17926000
. : milestone, 17926000,
profiling (15.641 s) : 15641000, 15641000
. : milestone, 15641000,
tracing (14.879 s) : 14879000, 14879000
. : milestone, 14879000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.942 s [14.942 s, 14.942 s]	-
appsec	14.699 s [14.699 s, 14.699 s]	-243.0 ms (-1.6%)
iast	18.439 s [18.439 s, 18.439 s]	3.497 s (23.4%)
iast_GLOBAL	17.898 s [17.898 s, 17.898 s]	2.956 s (19.8%)
profiling	15.198 s [15.198 s, 15.198 s]	256.0 ms (1.7%)
tracing	14.926 s [14.926 s, 14.926 s]	-16.0 ms (-0.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.154 s [15.154 s, 15.154 s]	-
appsec	14.707 s [14.707 s, 14.707 s]	-447.0 ms (-2.9%)
iast	19.083 s [19.083 s, 19.083 s]	3.929 s (25.9%)
iast_GLOBAL	17.926 s [17.926 s, 17.926 s]	2.772 s (18.3%)
profiling	15.641 s [15.641 s, 15.641 s]	487.0 ms (3.2%)
tracing	14.879 s [14.879 s, 14.879 s]	-275.0 ms (-1.8%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~bf6162c180, baseline=1.47.0-SNAPSHOT~ca6895a0a9
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.356 ms) : 2313, 2400
. : milestone, 2356,
iast (2.114 ms) : 2059, 2169
. : milestone, 2114,
iast_GLOBAL (2.15 ms) : 2095, 2206
. : milestone, 2150,
profiling (1.961 ms) : 1917, 2004
. : milestone, 1961,
tracing (1.935 ms) : 1893, 1977
. : milestone, 1935,
section candidate
no_agent (1.463 ms) : 1452, 1475
. : milestone, 1463,
appsec (2.347 ms) : 2304, 2390
. : milestone, 2347,
iast (2.11 ms) : 2054, 2165
. : milestone, 2110,
iast_GLOBAL (2.147 ms) : 2091, 2202
. : milestone, 2147,
profiling (1.958 ms) : 1915, 2001
. : milestone, 1958,
tracing (1.947 ms) : 1905, 1989
. : milestone, 1947,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	2.356 ms [2.313 ms, 2.4 ms]	883.295 µs (60.0%)
iast	2.114 ms [2.059 ms, 2.169 ms]	640.501 µs (43.5%)
iast_GLOBAL	2.15 ms [2.095 ms, 2.206 ms]	677.426 µs (46.0%)
profiling	1.961 ms [1.917 ms, 2.004 ms]	487.753 µs (33.1%)
tracing	1.935 ms [1.893 ms, 1.977 ms]	462.224 µs (31.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.463 ms [1.452 ms, 1.475 ms]	-
appsec	2.347 ms [2.304 ms, 2.39 ms]	883.801 µs (60.4%)
iast	2.11 ms [2.054 ms, 2.165 ms]	646.444 µs (44.2%)
iast_GLOBAL	2.147 ms [2.091 ms, 2.202 ms]	683.654 µs (46.7%)
profiling	1.958 ms [1.915 ms, 2.001 ms]	494.756 µs (33.8%)
tracing	1.947 ms [1.905 ms, 1.989 ms]	483.61 µs (33.1%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

Muzzle: do not generate references for primitive arrays in method body
bf6162c

amarziali requested a review from a team as a code owner February 10, 2025 10:58

amarziali requested a review from smola February 10, 2025 10:58

amarziali added type: bug fix Bug fix comp: tooling Build & Tooling labels Feb 10, 2025

mcculls approved these changes Feb 10, 2025
View reviewed changes

amarziali enabled auto-merge (squash) February 10, 2025 13:14

amarziali merged commit ec92bff into masterFeb 10, 2025

amarziali deleted the andrea.marziali/muzzle-arrays branch February 10, 2025 13:28

github-actionsBot added this to the 1.47.0 milestone Feb 10, 2025

PerfectSlayer changed the title ~~Muzzle: do not generate references for primitive arrays in method body~~Do not generate Muzzle references for primitive arrays in method bodyFeb 10, 2025

Navigation Menu

Uh oh!

Do not generate Muzzle references for primitive arrays in method body - #8361

Do not generate Muzzle references for primitive arrays in method body#8361
amarziali merged 1 commit into
masterfrom
andrea.marziali/muzzle-arrays

amarziali commented Feb 10, 2025•
edited
Loading

Uh oh!

github-actionsBot commented Feb 10, 2025

Uh oh!

mcculls left a comment

Uh oh!

pr-commenterBot commented Feb 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

amarziali commented Feb 10, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actionsBot commented Feb 10, 2025

Uh oh!

mcculls left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenterBot commented Feb 10, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

amarziali commented Feb 10, 2025•
edited
Loading