Look in another location for grpc service methods by evanchooly · Pull Request #8468 · DataDog/dd-trace-java

evanchooly · 2025-02-27T21:47:36Z

What Does This Do

The version of grpc used by the tracer’s testing is older than the version used by logs-backend and so the generated code is slightly different. In the tracer version, the proto interface gets generated into a FooImplBase for the proto type foo. In logs-backed, FooImplBase implements an interface called AsyncService and all the pertinent method definitions are there instead. The fix here, then, is to look first at the ImplBase type and if the only method is bindService(), look for the methods on the generated AsyncService interface instead.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3563

… interface which *should* have the service methods.

github-actions · 2025-02-27T21:47:50Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2025-02-27T22:27:21Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3563
git_commit_date	1740676228	1740705133
git_commit_sha	`ccc22c5`	`c0f1a8f`
release_version	1.47.0-SNAPSHOT~ccc22c5138	1.47.0-SNAPSHOT~c0f1a8fc49

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740707475	1740707475
ci_job_id	827121441	827121441
ci_pipeline_id	57294917	57294917
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-pu8wify-project-304-concurrent-0-ulon2w5f 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-pu8wify-project-304-concurrent-0-ulon2w5f 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~c0f1a8fc49, baseline=1.47.0-SNAPSHOT~ccc22c5138
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041240
Total [baseline] (10.412 s) : 0, 10412442
Agent [candidate] (1.042 s) : 0, 1041961
Total [candidate] (10.356 s) : 0, 10355689
section appsec
Agent [baseline] (1.184 s) : 0, 1184182
Total [baseline] (10.773 s) : 0, 10772715
Agent [candidate] (1.189 s) : 0, 1188801
Total [candidate] (10.764 s) : 0, 10764360
section iast
Agent [baseline] (1.177 s) : 0, 1176994
Total [baseline] (11.002 s) : 0, 11002310
Agent [candidate] (1.168 s) : 0, 1167738
Total [candidate] (10.947 s) : 0, 10947395
section profiling
Agent [baseline] (1.257 s) : 0, 1257207
Total [baseline] (10.812 s) : 0, 10811583
Agent [candidate] (1.26 s) : 0, 1259622
Total [candidate] (10.853 s) : 0, 10853163

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.041 s	-
Agent	appsec	1.184 s	142.942 ms (13.7%)
Agent	iast	1.177 s	135.754 ms (13.0%)
Agent	profiling	1.257 s	215.967 ms (20.7%)
Total	tracing	10.412 s	-
Total	appsec	10.773 s	360.273 ms (3.5%)
Total	iast	11.002 s	589.868 ms (5.7%)
Total	profiling	10.812 s	399.141 ms (3.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	appsec	1.189 s	146.84 ms (14.1%)
Agent	iast	1.168 s	125.777 ms (12.1%)
Agent	profiling	1.26 s	217.66 ms (20.9%)
Total	tracing	10.356 s	-
Total	appsec	10.764 s	408.671 ms (3.9%)
Total	iast	10.947 s	591.706 ms (5.7%)
Total	profiling	10.853 s	497.474 ms (4.8%)

gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~c0f1a8fc49, baseline=1.47.0-SNAPSHOT~ccc22c5138
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.087 ms) : 0, 717087
BytebuddyAgent [candidate] (717.434 ms) : 0, 717434
GlobalTracer [baseline] (239.236 ms) : 0, 239236
GlobalTracer [candidate] (239.266 ms) : 0, 239266
AppSec [baseline] (55.617 ms) : 0, 55617
AppSec [candidate] (55.832 ms) : 0, 55832
Remote Config [baseline] (692.823 µs) : 0, 693
Remote Config [candidate] (702.677 µs) : 0, 703
Telemetry [baseline] (13.699 ms) : 0, 13699
Telemetry [candidate] (13.727 ms) : 0, 13727
section appsec
BytebuddyAgent [baseline] (735.635 ms) : 0, 735635
BytebuddyAgent [candidate] (739.634 ms) : 0, 739634
GlobalTracer [baseline] (236.445 ms) : 0, 236445
GlobalTracer [candidate] (236.843 ms) : 0, 236843
AppSec [baseline] (177.614 ms) : 0, 177614
AppSec [candidate] (177.689 ms) : 0, 177689
Remote Config [baseline] (664.205 µs) : 0, 664
Remote Config [candidate] (660.602 µs) : 0, 661
Telemetry [baseline] (8.274 ms) : 0, 8274
Telemetry [candidate] (8.308 ms) : 0, 8308
IAST [baseline] (21.377 ms) : 0, 21377
IAST [candidate] (21.342 ms) : 0, 21342
section iast
BytebuddyAgent [baseline] (841.121 ms) : 0, 841121
BytebuddyAgent [candidate] (834.38 ms) : 0, 834380
GlobalTracer [baseline] (230.746 ms) : 0, 230746
GlobalTracer [candidate] (229.403 ms) : 0, 229403
AppSec [baseline] (57.583 ms) : 0, 57583
AppSec [candidate] (56.923 ms) : 0, 56923
Remote Config [baseline] (618.642 µs) : 0, 619
Remote Config [candidate] (599.904 µs) : 0, 600
Telemetry [baseline] (8.798 ms) : 0, 8798
Telemetry [candidate] (8.747 ms) : 0, 8747
IAST [baseline] (23.056 ms) : 0, 23056
IAST [candidate] (22.766 ms) : 0, 22766
section profiling
BytebuddyAgent [baseline] (707.537 ms) : 0, 707537
BytebuddyAgent [candidate] (708.539 ms) : 0, 708540
GlobalTracer [baseline] (348.736 ms) : 0, 348736
GlobalTracer [candidate] (350.072 ms) : 0, 350072
AppSec [baseline] (55.44 ms) : 0, 55440
AppSec [candidate] (54.49 ms) : 0, 54490
Remote Config [baseline] (667.99 µs) : 0, 668
Remote Config [candidate] (668.565 µs) : 0, 669
Telemetry [baseline] (8.846 ms) : 0, 8846
Telemetry [candidate] (8.955 ms) : 0, 8955
ProfilingAgent [baseline] (95.784 ms) : 0, 95784
ProfilingAgent [candidate] (96.633 ms) : 0, 96633
Profiling [baseline] (95.808 ms) : 0, 95808
Profiling [candidate] (96.657 ms) : 0, 96657

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~c0f1a8fc49, baseline=1.47.0-SNAPSHOT~ccc22c5138
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1038356
Total [baseline] (8.645 s) : 0, 8644685
Agent [candidate] (1.04 s) : 0, 1040248
Total [candidate] (8.647 s) : 0, 8647374
section iast
Agent [baseline] (1.168 s) : 0, 1167799
Total [baseline] (9.189 s) : 0, 9188862
Agent [candidate] (1.167 s) : 0, 1167262
Total [candidate] (9.228 s) : 0, 9228081
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1176196
Total [baseline] (9.231 s) : 0, 9230767
Agent [candidate] (1.172 s) : 0, 1171669
Total [candidate] (9.25 s) : 0, 9249597
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1175449
Total [baseline] (9.285 s) : 0, 9284965
Agent [candidate] (1.171 s) : 0, 1170787
Total [candidate] (9.204 s) : 0, 9204483

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.038 s	-
Agent	iast	1.168 s	129.443 ms (12.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.176 s	137.84 ms (13.3%)
Agent	iast_TELEMETRY_OFF	1.175 s	137.093 ms (13.2%)
Total	tracing	8.645 s	-
Total	iast	9.189 s	544.177 ms (6.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.231 s	586.082 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.285 s	640.28 ms (7.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	iast	1.167 s	127.014 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	131.421 ms (12.6%)
Agent	iast_TELEMETRY_OFF	1.171 s	130.54 ms (12.5%)
Total	tracing	8.647 s	-
Total	iast	9.228 s	580.706 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.25 s	602.223 ms (7.0%)
Total	iast_TELEMETRY_OFF	9.204 s	557.109 ms (6.4%)

gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~c0f1a8fc49, baseline=1.47.0-SNAPSHOT~ccc22c5138
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.449 ms) : 0, 716449
BytebuddyAgent [candidate] (716.518 ms) : 0, 716518
GlobalTracer [baseline] (238.123 ms) : 0, 238123
GlobalTracer [candidate] (238.837 ms) : 0, 238837
AppSec [baseline] (55.391 ms) : 0, 55391
AppSec [candidate] (55.724 ms) : 0, 55724
Remote Config [baseline] (696.548 µs) : 0, 697
Remote Config [candidate] (690.013 µs) : 0, 690
Telemetry [baseline] (12.839 ms) : 0, 12839
Telemetry [candidate] (13.584 ms) : 0, 13584
section iast
BytebuddyAgent [baseline] (834.318 ms) : 0, 834318
BytebuddyAgent [candidate] (833.906 ms) : 0, 833906
GlobalTracer [baseline] (229.482 ms) : 0, 229482
GlobalTracer [candidate] (229.864 ms) : 0, 229864
AppSec [baseline] (56.789 ms) : 0, 56789
AppSec [candidate] (56.608 ms) : 0, 56608
Remote Config [baseline] (602.686 µs) : 0, 603
Remote Config [candidate] (603.006 µs) : 0, 603
Telemetry [baseline] (8.671 ms) : 0, 8671
Telemetry [candidate] (8.708 ms) : 0, 8708
IAST [baseline] (22.912 ms) : 0, 22912
IAST [candidate] (22.662 ms) : 0, 22662
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.684 ms) : 0, 840684
BytebuddyAgent [candidate] (836.891 ms) : 0, 836891
GlobalTracer [baseline] (230.711 ms) : 0, 230711
GlobalTracer [candidate] (230.847 ms) : 0, 230847
AppSec [baseline] (57.311 ms) : 0, 57311
AppSec [candidate] (56.717 ms) : 0, 56717
Remote Config [baseline] (620.013 µs) : 0, 620
Remote Config [candidate] (611.86 µs) : 0, 612
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.726 ms) : 0, 8726
IAST [baseline] (23.02 ms) : 0, 23020
IAST [candidate] (22.904 ms) : 0, 22904
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.434 ms) : 0, 839434
BytebuddyAgent [candidate] (837.131 ms) : 0, 837131
GlobalTracer [baseline] (231.15 ms) : 0, 231150
GlobalTracer [candidate] (230.695 ms) : 0, 230695
AppSec [baseline] (54.528 ms) : 0, 54528
AppSec [candidate] (51.107 ms) : 0, 51107
Remote Config [baseline] (628.441 µs) : 0, 628
Remote Config [candidate] (607.877 µs) : 0, 608
Telemetry [baseline] (8.777 ms) : 0, 8777
Telemetry [candidate] (8.522 ms) : 0, 8522
IAST [baseline] (25.917 ms) : 0, 25917
IAST [candidate] (27.612 ms) : 0, 27612

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-28T01:23:44	2025-02-28T01:31:29
git_branch	master	evanchooly/DEBUG-3563
git_commit_date	1740676228	1740705133
git_commit_sha	`ccc22c5`	`c0f1a8f`
release_version	1.47.0-SNAPSHOT~ccc22c5138	1.47.0-SNAPSHOT~c0f1a8fc49
start_time	2025-02-28T01:23:30	2025-02-28T01:31:14

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740706686	1740706686
ci_job_id	827121442	827121442
ci_pipeline_id	57294917	57294917
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-pu8wify-project-304-concurrent-1-7dz6w97v 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-pu8wify-project-304-concurrent-1-7dz6w97v 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~c0f1a8fc49, baseline=1.47.0-SNAPSHOT~ccc22c5138
dateFormat X
axisFormat %s
section baseline
no_agent (1.356 ms) : 1336, 1376
. : milestone, 1356,
appsec (1.728 ms) : 1705, 1752
. : milestone, 1728,
appsec_no_iast (1.727 ms) : 1703, 1751
. : milestone, 1727,
code_origins (1.69 ms) : 1658, 1722
. : milestone, 1690,
iast (1.513 ms) : 1489, 1536
. : milestone, 1513,
profiling (1.524 ms) : 1500, 1547
. : milestone, 1524,
tracing (1.509 ms) : 1484, 1533
. : milestone, 1509,
section candidate
no_agent (1.355 ms) : 1336, 1375
. : milestone, 1355,
appsec (1.702 ms) : 1678, 1726
. : milestone, 1702,
appsec_no_iast (1.743 ms) : 1718, 1768
. : milestone, 1743,
code_origins (1.686 ms) : 1652, 1720
. : milestone, 1686,
iast (1.508 ms) : 1484, 1532
. : milestone, 1508,
profiling (1.509 ms) : 1485, 1533
. : milestone, 1509,
tracing (1.495 ms) : 1470, 1520
. : milestone, 1495,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.336 ms, 1.376 ms]	-
appsec	1.728 ms [1.705 ms, 1.752 ms]	372.219 µs (27.4%)
appsec_no_iast	1.727 ms [1.703 ms, 1.751 ms]	370.63 µs (27.3%)
code_origins	1.69 ms [1.658 ms, 1.722 ms]	334.062 µs (24.6%)
iast	1.513 ms [1.489 ms, 1.536 ms]	156.499 µs (11.5%)
profiling	1.524 ms [1.5 ms, 1.547 ms]	167.675 µs (12.4%)
tracing	1.509 ms [1.484 ms, 1.533 ms]	152.544 µs (11.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.336 ms, 1.375 ms]	-
appsec	1.702 ms [1.678 ms, 1.726 ms]	346.113 µs (25.5%)
appsec_no_iast	1.743 ms [1.718 ms, 1.768 ms]	387.382 µs (28.6%)
code_origins	1.686 ms [1.652 ms, 1.72 ms]	330.338 µs (24.4%)
iast	1.508 ms [1.484 ms, 1.532 ms]	152.268 µs (11.2%)
profiling	1.509 ms [1.485 ms, 1.533 ms]	153.414 µs (11.3%)
tracing	1.495 ms [1.47 ms, 1.52 ms]	139.574 µs (10.3%)

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~c0f1a8fc49, baseline=1.47.0-SNAPSHOT~ccc22c5138
dateFormat X
axisFormat %s
section baseline
no_agent (381.864 µs) : 362, 402
. : milestone, 382,
iast (512.549 µs) : 490, 535
. : milestone, 513,
iast_FULL (735.033 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (556.812 µs) : 535, 578
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (515.748 µs) : 494, 538
. : milestone, 516,
iast_INACTIVE (462.417 µs) : 441, 484
. : milestone, 462,
iast_TELEMETRY_OFF (502.31 µs) : 480, 525
. : milestone, 502,
tracing (452.317 µs) : 432, 473
. : milestone, 452,
section candidate
no_agent (386.435 µs) : 366, 406
. : milestone, 386,
iast (512.952 µs) : 490, 536
. : milestone, 513,
iast_FULL (731.614 µs) : 710, 753
. : milestone, 732,
iast_GLOBAL (556.865 µs) : 535, 578
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (506.731 µs) : 484, 530
. : milestone, 507,
iast_INACTIVE (466.86 µs) : 445, 488
. : milestone, 467,
iast_TELEMETRY_OFF (499.214 µs) : 478, 521
. : milestone, 499,
tracing (457.103 µs) : 436, 479
. : milestone, 457,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.864 µs [361.584 µs, 402.144 µs]	-
iast	512.549 µs [489.919 µs, 535.18 µs]	130.685 µs (34.2%)
iast_FULL	735.033 µs [713.104 µs, 756.962 µs]	353.169 µs (92.5%)
iast_GLOBAL	556.812 µs [535.224 µs, 578.401 µs]	174.948 µs (45.8%)
iast_HARDCODED_SECRET_DISABLED	515.748 µs [493.603 µs, 537.892 µs]	133.884 µs (35.1%)
iast_INACTIVE	462.417 µs [441.194 µs, 483.641 µs]	80.553 µs (21.1%)
iast_TELEMETRY_OFF	502.31 µs [479.633 µs, 524.987 µs]	120.446 µs (31.5%)
tracing	452.317 µs [431.639 µs, 472.995 µs]	70.453 µs (18.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	386.435 µs [366.404 µs, 406.466 µs]	-
iast	512.952 µs [490.175 µs, 535.729 µs]	126.517 µs (32.7%)
iast_FULL	731.614 µs [709.744 µs, 753.483 µs]	345.179 µs (89.3%)
iast_GLOBAL	556.865 µs [535.307 µs, 578.423 µs]	170.43 µs (44.1%)
iast_HARDCODED_SECRET_DISABLED	506.731 µs [483.77 µs, 529.693 µs]	120.296 µs (31.1%)
iast_INACTIVE	466.86 µs [445.493 µs, 488.226 µs]	80.425 µs (20.8%)
iast_TELEMETRY_OFF	499.214 µs [477.689 µs, 520.739 µs]	112.779 µs (29.2%)
tracing	457.103 µs [435.511 µs, 478.695 µs]	70.668 µs (18.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	evanchooly/DEBUG-3563
git_commit_date	1740676228	1740705133
git_commit_sha	`ccc22c5`	`c0f1a8f`
release_version	1.47.0-SNAPSHOT~ccc22c5138	1.47.0-SNAPSHOT~c0f1a8fc49

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1740707187	1740707187
ci_job_id	827121443	827121443
ci_pipeline_id	57294917	57294917
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-pu8wify-project-304-concurrent-2-lo4vvmll 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-pu8wify-project-304-concurrent-2-lo4vvmll 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~c0f1a8fc49, baseline=1.47.0-SNAPSHOT~ccc22c5138
dateFormat X
axisFormat %s
section baseline
no_agent (14.954 s) : 14954000, 14954000
. : milestone, 14954000,
appsec (15.051 s) : 15051000, 15051000
. : milestone, 15051000,
iast (18.77 s) : 18770000, 18770000
. : milestone, 18770000,
iast_GLOBAL (18.216 s) : 18216000, 18216000
. : milestone, 18216000,
profiling (15.096 s) : 15096000, 15096000
. : milestone, 15096000,
tracing (14.892 s) : 14892000, 14892000
. : milestone, 14892000,
section candidate
no_agent (15.618 s) : 15618000, 15618000
. : milestone, 15618000,
appsec (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
iast (18.8 s) : 18800000, 18800000
. : milestone, 18800000,
iast_GLOBAL (17.615 s) : 17615000, 17615000
. : milestone, 17615000,
profiling (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
tracing (15.101 s) : 15101000, 15101000
. : milestone, 15101000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.954 s [14.954 s, 14.954 s]	-
appsec	15.051 s [15.051 s, 15.051 s]	97.0 ms (0.6%)
iast	18.77 s [18.77 s, 18.77 s]	3.816 s (25.5%)
iast_GLOBAL	18.216 s [18.216 s, 18.216 s]	3.262 s (21.8%)
profiling	15.096 s [15.096 s, 15.096 s]	142.0 ms (0.9%)
tracing	14.892 s [14.892 s, 14.892 s]	-62.0 ms (-0.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.618 s [15.618 s, 15.618 s]	-
appsec	14.949 s [14.949 s, 14.949 s]	-669.0 ms (-4.3%)
iast	18.8 s [18.8 s, 18.8 s]	3.182 s (20.4%)
iast_GLOBAL	17.615 s [17.615 s, 17.615 s]	1.997 s (12.8%)
profiling	15.063 s [15.063 s, 15.063 s]	-555.0 ms (-3.6%)
tracing	15.101 s [15.101 s, 15.101 s]	-517.0 ms (-3.3%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~c0f1a8fc49, baseline=1.47.0-SNAPSHOT~ccc22c5138
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.346 ms) : 2303, 2390
. : milestone, 2346,
iast (2.118 ms) : 2063, 2173
. : milestone, 2118,
iast_GLOBAL (2.159 ms) : 2104, 2214
. : milestone, 2159,
profiling (1.989 ms) : 1943, 2034
. : milestone, 1989,
tracing (1.95 ms) : 1907, 1992
. : milestone, 1950,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.327 ms) : 2284, 2370
. : milestone, 2327,
iast (2.119 ms) : 2064, 2174
. : milestone, 2119,
iast_GLOBAL (2.156 ms) : 2101, 2212
. : milestone, 2156,
profiling (1.994 ms) : 1949, 2038
. : milestone, 1994,
tracing (1.953 ms) : 1911, 1995
. : milestone, 1953,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	2.346 ms [2.303 ms, 2.39 ms]	873.213 µs (59.3%)
iast	2.118 ms [2.063 ms, 2.173 ms]	645.281 µs (43.8%)
iast_GLOBAL	2.159 ms [2.104 ms, 2.214 ms]	685.887 µs (46.6%)
profiling	1.989 ms [1.943 ms, 2.034 ms]	515.525 µs (35.0%)
tracing	1.95 ms [1.907 ms, 1.992 ms]	476.706 µs (32.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.327 ms [2.284 ms, 2.37 ms]	850.767 µs (57.6%)
iast	2.119 ms [2.064 ms, 2.174 ms]	642.406 µs (43.5%)
iast_GLOBAL	2.156 ms [2.101 ms, 2.212 ms]	679.982 µs (46.1%)
profiling	1.994 ms [1.949 ms, 2.038 ms]	517.42 µs (35.0%)
tracing	1.953 ms [1.911 ms, 1.995 ms]	476.548 µs (32.3%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

if the service aren't found on the ImplBase, look for an AsyncService…
c43f93c
… interface which *should* have the service methods.

evanchooly added inst: grpc gRPC instrumentation comp: debugger Dynamic Instrumentation inst: java Core Java language instrumentation labels Feb 27, 2025

evanchooly requested review from jpbempel and shatzi February 27, 2025 21:47

evanchooly requested a review from a team as a code owner February 27, 2025 21:47

jpbempel approved these changes Feb 27, 2025
View reviewed changes

evanchooly added 2 commits February 27, 2025 17:41

inline the method. I should have known better. :)
3911b6d

remove the lambda
c0f1a8f

evanchooly added inst: java Core Java language instrumentation type: feature Enhancements and improvements and removed inst: java Core Java language instrumentation labels Feb 28, 2025

evanchooly merged commit 87b5366 into masterFeb 28, 2025

evanchooly deleted the evanchooly/DEBUG-3563 branch February 28, 2025 14:02

github-actionsBot added this to the 1.47.0 milestone Feb 28, 2025

Navigation Menu

Uh oh!

Look in another location for grpc service methods - #8468

Look in another location for grpc service methods#8468
evanchooly merged 3 commits into
masterfrom
evanchooly/DEBUG-3563

evanchooly commented Feb 27, 2025•
edited by atlassian Bot
Loading

Uh oh!

github-actionsBot commented Feb 27, 2025•
edited
Loading

Uh oh!

pr-commenterBot commented Feb 27, 2025•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

evanchooly commented Feb 27, 2025• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

github-actionsBot commented Feb 27, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenterBot commented Feb 27, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

evanchooly commented Feb 27, 2025•
edited by atlassian Bot
Loading

github-actionsBot commented Feb 27, 2025•
edited
Loading

pr-commenterBot commented Feb 27, 2025•
edited
Loading