Disable capture of entry values by jpbempel · Pull Request #8369 · DataDog/dd-trace-java

jpbempel · 2025-02-11T13:37:10Z

What Does This Do

Due to overhead induced by capturing entry values because we need to freeze them (serialize as Json) immediately before even know if we are
sampling it or not, compared to the usefulness of having those values
we only capture at exit by default.

Motivation

Performance

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

Due to overhead induced by capturing entry values because we need to freeze them (serialize as Json) immediately before even know if we are sampling it or not, compared to the usefulness of having those values we only capture at exit by default.

pr-commenter · 2025-02-11T13:56:04Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1739281407	1739281790
end_time	2025-02-11T13:44:44	2025-02-11T13:51:07
git_branch	master	jpbempel/disable-capture-entry-values
git_commit_sha	`652b465`	`d5d15f1`
start_time	2025-02-11T13:43:28	2025-02-11T13:49:51

See matching parameters

	Baseline	Candidate
ci_job_id	802844575	802844575
ci_pipeline_id	55527576	55527576
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1739280817	1739280817

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics.

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-23781.726ns; +24874.790ns] or [-8.801%; +9.205%]	unstable [-36952.998ns; +37516.868ns] or [-11.888%; +12.069%]	unstable [-49.880µs; +46.892µs] or [-15.282%; +14.366%]	unstable [-112.719µs; +110.106µs] or [-19.413%; +18.963%]	same
scenario:basic	unsure [+0.536µs; +9.801µs] or [+0.197%; +3.598%]	same	same	unstable [-27.379µs; +57.495µs] or [-5.158%; +10.832%]	same
scenario:loop	same	same	same	same	same

Request duration reports for reports

gantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (310.849 µs) : 271, 350
. : milestone, 311,
basic (303.555 µs) : 293, 314
. : milestone, 304,
loop (10.804 ms) : 10772, 10836
. : milestone, 10804,
section candidate
noprobe (311.131 µs) : 280, 342
. : milestone, 311,
basic (308.405 µs) : 300, 316
. : milestone, 308,
loop (10.723 ms) : 10599, 10847
. : milestone, 10723,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	310.849 µs [271.484 µs, 350.213 µs]
basic	303.555 µs [292.992 µs, 314.119 µs]
loop	10.804 ms [10.772 ms, 10.836 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	311.131 µs [279.989 µs, 342.273 µs]
basic	308.405 µs [300.34 µs, 316.47 µs]
loop	10.723 ms [10.599 ms, 10.847 ms]

pr-commenter · 2025-02-11T14:15:24Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/disable-capture-entry-values
git_commit_date	1739276388	1739280817
git_commit_sha	`652b465`	`d5d15f1`
release_version	1.47.0-SNAPSHOT~652b46574b	1.47.0-SNAPSHOT~d5d15f1071

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739283278	1739283278
ci_job_id	802844569	802844569
ci_pipeline_id	55527576	55527576
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-tp66uhdj-project-304-concurrent-0-ocvvp335 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-tp66uhdj-project-304-concurrent-0-ocvvp335 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~d5d15f1071, baseline=1.47.0-SNAPSHOT~652b46574b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045279
Total [baseline] (10.447 s) : 0, 10447428
Agent [candidate] (1.043 s) : 0, 1042888
Total [candidate] (10.438 s) : 0, 10437898
section appsec
Agent [baseline] (1.186 s) : 0, 1186387
Total [baseline] (10.771 s) : 0, 10770800
Agent [candidate] (1.191 s) : 0, 1190715
Total [candidate] (10.763 s) : 0, 10763433
section iast
Agent [baseline] (1.176 s) : 0, 1175892
Total [baseline] (10.972 s) : 0, 10971634
Agent [candidate] (1.185 s) : 0, 1185066
Total [candidate] (10.992 s) : 0, 10992190
section profiling
Agent [baseline] (1.266 s) : 0, 1266252
Total [baseline] (10.888 s) : 0, 10888428
Agent [candidate] (1.266 s) : 0, 1265818
Total [candidate] (10.875 s) : 0, 10875195

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.045 s	-
Agent	appsec	1.186 s	141.108 ms (13.5%)
Agent	iast	1.176 s	130.613 ms (12.5%)
Agent	profiling	1.266 s	220.973 ms (21.1%)
Total	tracing	10.447 s	-
Total	appsec	10.771 s	323.372 ms (3.1%)
Total	iast	10.972 s	524.206 ms (5.0%)
Total	profiling	10.888 s	441.0 ms (4.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	appsec	1.191 s	147.827 ms (14.2%)
Agent	iast	1.185 s	142.178 ms (13.6%)
Agent	profiling	1.266 s	222.93 ms (21.4%)
Total	tracing	10.438 s	-
Total	appsec	10.763 s	325.535 ms (3.1%)
Total	iast	10.992 s	554.292 ms (5.3%)
Total	profiling	10.875 s	437.297 ms (4.2%)

gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~d5d15f1071, baseline=1.47.0-SNAPSHOT~652b46574b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.873 ms) : 0, 717873
BytebuddyAgent [candidate] (716.553 ms) : 0, 716553
GlobalTracer [baseline] (243.882 ms) : 0, 243882
GlobalTracer [candidate] (243.352 ms) : 0, 243352
AppSec [baseline] (56.06 ms) : 0, 56060
AppSec [candidate] (54.806 ms) : 0, 54806
Remote Config [baseline] (718.466 µs) : 0, 718
Remote Config [candidate] (719.41 µs) : 0, 719
Telemetry [baseline] (11.514 ms) : 0, 11514
Telemetry [candidate] (12.25 ms) : 0, 12250
section appsec
BytebuddyAgent [baseline] (733.904 ms) : 0, 733904
BytebuddyAgent [candidate] (739.088 ms) : 0, 739088
GlobalTracer [baseline] (240.795 ms) : 0, 240795
GlobalTracer [candidate] (240.637 ms) : 0, 240637
IAST [baseline] (21.748 ms) : 0, 21748
IAST [candidate] (21.754 ms) : 0, 21754
AppSec [baseline] (176.678 ms) : 0, 176678
AppSec [candidate] (175.847 ms) : 0, 175847
Remote Config [baseline] (656.227 µs) : 0, 656
Remote Config [candidate] (661.849 µs) : 0, 662
Telemetry [baseline] (8.262 ms) : 0, 8262
Telemetry [candidate] (8.308 ms) : 0, 8308
section iast
BytebuddyAgent [baseline] (836.371 ms) : 0, 836371
BytebuddyAgent [candidate] (843.016 ms) : 0, 843016
GlobalTracer [baseline] (234.548 ms) : 0, 234548
GlobalTracer [candidate] (235.828 ms) : 0, 235828
IAST [baseline] (22.896 ms) : 0, 22896
IAST [candidate] (23.14 ms) : 0, 23140
AppSec [baseline] (57.399 ms) : 0, 57399
AppSec [candidate] (57.98 ms) : 0, 57980
Remote Config [baseline] (614.649 µs) : 0, 615
Remote Config [candidate] (646.929 µs) : 0, 647
Telemetry [baseline] (8.799 ms) : 0, 8799
Telemetry [candidate] (8.849 ms) : 0, 8849
section profiling
BytebuddyAgent [baseline] (708.089 ms) : 0, 708089
BytebuddyAgent [candidate] (708.405 ms) : 0, 708405
GlobalTracer [baseline] (355.047 ms) : 0, 355047
GlobalTracer [candidate] (354.99 ms) : 0, 354990
AppSec [baseline] (55.43 ms) : 0, 55430
AppSec [candidate] (54.533 ms) : 0, 54533
Remote Config [baseline] (703.841 µs) : 0, 704
Remote Config [candidate] (715.01 µs) : 0, 715
Telemetry [baseline] (8.949 ms) : 0, 8949
Telemetry [candidate] (8.934 ms) : 0, 8934
ProfilingAgent [baseline] (95.679 ms) : 0, 95679
ProfilingAgent [candidate] (95.853 ms) : 0, 95853
Profiling [baseline] (95.704 ms) : 0, 95704
Profiling [candidate] (95.878 ms) : 0, 95878

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~d5d15f1071, baseline=1.47.0-SNAPSHOT~652b46574b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060542
Total [baseline] (8.689 s) : 0, 8689359
Agent [candidate] (1.044 s) : 0, 1043503
Total [candidate] (8.668 s) : 0, 8667879
section iast
Agent [baseline] (1.181 s) : 0, 1181377
Total [baseline] (9.244 s) : 0, 9243740
Agent [candidate] (1.182 s) : 0, 1181973
Total [candidate] (9.242 s) : 0, 9242374
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1178850
Total [baseline] (9.222 s) : 0, 9221741
Agent [candidate] (1.192 s) : 0, 1192076
Total [candidate] (9.29 s) : 0, 9290021
section iast_TELEMETRY_OFF
Agent [baseline] (1.172 s) : 0, 1171563
Total [baseline] (9.28 s) : 0, 9279619
Agent [candidate] (1.174 s) : 0, 1173709
Total [candidate] (9.245 s) : 0, 9245115

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	iast	1.181 s	120.835 ms (11.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.179 s	118.308 ms (11.2%)
Agent	iast_TELEMETRY_OFF	1.172 s	111.022 ms (10.5%)
Total	tracing	8.689 s	-
Total	iast	9.244 s	554.381 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.222 s	532.382 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.28 s	590.26 ms (6.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	iast	1.182 s	138.469 ms (13.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.192 s	148.572 ms (14.2%)
Agent	iast_TELEMETRY_OFF	1.174 s	130.205 ms (12.5%)
Total	tracing	8.668 s	-
Total	iast	9.242 s	574.495 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.29 s	622.142 ms (7.2%)
Total	iast_TELEMETRY_OFF	9.245 s	577.236 ms (6.7%)

gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~d5d15f1071, baseline=1.47.0-SNAPSHOT~652b46574b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (727.593 ms) : 0, 727593
BytebuddyAgent [candidate] (716.48 ms) : 0, 716480
GlobalTracer [baseline] (246.835 ms) : 0, 246835
GlobalTracer [candidate] (243.705 ms) : 0, 243705
AppSec [baseline] (55.59 ms) : 0, 55590
AppSec [candidate] (55.344 ms) : 0, 55344
Remote Config [baseline] (730.265 µs) : 0, 730
Remote Config [candidate] (725.391 µs) : 0, 725
Telemetry [baseline] (14.373 ms) : 0, 14373
Telemetry [candidate] (12.148 ms) : 0, 12148
section iast
BytebuddyAgent [baseline] (841.345 ms) : 0, 841345
BytebuddyAgent [candidate] (842.588 ms) : 0, 842588
GlobalTracer [baseline] (234.791 ms) : 0, 234791
GlobalTracer [candidate] (234.75 ms) : 0, 234750
IAST [baseline] (23.111 ms) : 0, 23111
IAST [candidate] (23.138 ms) : 0, 23138
AppSec [baseline] (57.318 ms) : 0, 57318
AppSec [candidate] (56.742 ms) : 0, 56742
Remote Config [baseline] (638.06 µs) : 0, 638
Remote Config [candidate] (614.491 µs) : 0, 614
Telemetry [baseline] (8.807 ms) : 0, 8807
Telemetry [candidate] (8.687 ms) : 0, 8687
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.639 ms) : 0, 837639
BytebuddyAgent [candidate] (849.131 ms) : 0, 849131
GlobalTracer [baseline] (235.71 ms) : 0, 235710
GlobalTracer [candidate] (236.678 ms) : 0, 236678
IAST [baseline] (23.05 ms) : 0, 23050
IAST [candidate] (23.409 ms) : 0, 23409
AppSec [baseline] (57.843 ms) : 0, 57843
AppSec [candidate] (57.567 ms) : 0, 57567
Remote Config [baseline] (632.107 µs) : 0, 632
Remote Config [candidate] (643.572 µs) : 0, 644
Telemetry [baseline] (8.796 ms) : 0, 8796
Telemetry [candidate] (8.955 ms) : 0, 8955
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.88 ms) : 0, 832880
BytebuddyAgent [candidate] (834.742 ms) : 0, 834742
GlobalTracer [baseline] (234.493 ms) : 0, 234493
GlobalTracer [candidate] (234.905 ms) : 0, 234905
IAST [baseline] (26.265 ms) : 0, 26265
IAST [candidate] (25.546 ms) : 0, 25546
AppSec [baseline] (53.325 ms) : 0, 53325
AppSec [candidate] (53.997 ms) : 0, 53997
Remote Config [baseline] (621.958 µs) : 0, 622
Remote Config [candidate] (611.738 µs) : 0, 612
Telemetry [baseline] (8.654 ms) : 0, 8654
Telemetry [candidate] (8.571 ms) : 0, 8571

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-11T13:44:36	2025-02-11T13:51:44
git_branch	master	jpbempel/disable-capture-entry-values
git_commit_date	1739276388	1739280817
git_commit_sha	`652b465`	`d5d15f1`
release_version	1.47.0-SNAPSHOT~652b46574b	1.47.0-SNAPSHOT~d5d15f1071
start_time	2025-02-11T13:44:22	2025-02-11T13:51:30

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739282263	1739282263
ci_job_id	802844570	802844570
ci_pipeline_id	55527576	55527576
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-b9vwe93j-project-304-concurrent-0-uylvbi3a 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-b9vwe93j-project-304-concurrent-0-uylvbi3a 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d5d15f1071, baseline=1.47.0-SNAPSHOT~652b46574b
dateFormat X
axisFormat %s
section baseline
no_agent (382.039 µs) : 362, 402
. : milestone, 382,
iast (518.121 µs) : 496, 540
. : milestone, 518,
iast_FULL (751.651 µs) : 730, 774
. : milestone, 752,
iast_GLOBAL (563.324 µs) : 540, 586
. : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (523.203 µs) : 501, 545
. : milestone, 523,
iast_INACTIVE (467.178 µs) : 445, 489
. : milestone, 467,
iast_TELEMETRY_OFF (501.716 µs) : 480, 524
. : milestone, 502,
tracing (458.829 µs) : 438, 480
. : milestone, 459,
section candidate
no_agent (387.72 µs) : 368, 408
. : milestone, 388,
iast (518.051 µs) : 495, 541
. : milestone, 518,
iast_FULL (746.138 µs) : 724, 768
. : milestone, 746,
iast_GLOBAL (558.129 µs) : 536, 580
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (511.186 µs) : 490, 533
. : milestone, 511,
iast_INACTIVE (461.359 µs) : 440, 483
. : milestone, 461,
iast_TELEMETRY_OFF (497.875 µs) : 475, 520
. : milestone, 498,
tracing (462.015 µs) : 441, 483
. : milestone, 462,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.039 µs [362.24 µs, 401.838 µs]	-
iast	518.121 µs [496.153 µs, 540.089 µs]	136.082 µs (35.6%)
iast_FULL	751.651 µs [729.76 µs, 773.541 µs]	369.612 µs (96.7%)
iast_GLOBAL	563.324 µs [540.361 µs, 586.287 µs]	181.285 µs (47.5%)
iast_HARDCODED_SECRET_DISABLED	523.203 µs [501.219 µs, 545.188 µs]	141.164 µs (37.0%)
iast_INACTIVE	467.178 µs [445.395 µs, 488.961 µs]	85.139 µs (22.3%)
iast_TELEMETRY_OFF	501.716 µs [479.506 µs, 523.927 µs]	119.677 µs (31.3%)
tracing	458.829 µs [437.629 µs, 480.03 µs]	76.79 µs (20.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	387.72 µs [367.528 µs, 407.912 µs]	-
iast	518.051 µs [495.362 µs, 540.741 µs]	130.331 µs (33.6%)
iast_FULL	746.138 µs [724.098 µs, 768.178 µs]	358.418 µs (92.4%)
iast_GLOBAL	558.129 µs [536.217 µs, 580.041 µs]	170.408 µs (44.0%)
iast_HARDCODED_SECRET_DISABLED	511.186 µs [489.66 µs, 532.712 µs]	123.466 µs (31.8%)
iast_INACTIVE	461.359 µs [439.979 µs, 482.738 µs]	73.638 µs (19.0%)
iast_TELEMETRY_OFF	497.875 µs [475.405 µs, 520.346 µs]	110.155 µs (28.4%)
tracing	462.015 µs [440.814 µs, 483.216 µs]	74.295 µs (19.2%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d5d15f1071, baseline=1.47.0-SNAPSHOT~652b46574b
dateFormat X
axisFormat %s
section baseline
no_agent (1.361 ms) : 1341, 1382
. : milestone, 1361,
appsec (1.76 ms) : 1736, 1783
. : milestone, 1760,
appsec_no_iast (1.771 ms) : 1743, 1799
. : milestone, 1771,
iast (1.51 ms) : 1484, 1536
. : milestone, 1510,
profiling (1.519 ms) : 1496, 1543
. : milestone, 1519,
tracing (1.468 ms) : 1442, 1493
. : milestone, 1468,
section candidate
no_agent (1.378 ms) : 1359, 1398
. : milestone, 1378,
appsec (1.746 ms) : 1723, 1769
. : milestone, 1746,
appsec_no_iast (1.75 ms) : 1726, 1775
. : milestone, 1750,
iast (1.512 ms) : 1487, 1537
. : milestone, 1512,
profiling (1.546 ms) : 1521, 1571
. : milestone, 1546,
tracing (1.495 ms) : 1470, 1519
. : milestone, 1495,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.361 ms [1.341 ms, 1.382 ms]	-
appsec	1.76 ms [1.736 ms, 1.783 ms]	398.437 µs (29.3%)
appsec_no_iast	1.771 ms [1.743 ms, 1.799 ms]	409.345 µs (30.1%)
iast	1.51 ms [1.484 ms, 1.536 ms]	148.573 µs (10.9%)
profiling	1.519 ms [1.496 ms, 1.543 ms]	157.946 µs (11.6%)
tracing	1.468 ms [1.442 ms, 1.493 ms]	106.291 µs (7.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.378 ms [1.359 ms, 1.398 ms]	-
appsec	1.746 ms [1.723 ms, 1.769 ms]	367.817 µs (26.7%)
appsec_no_iast	1.75 ms [1.726 ms, 1.775 ms]	372.091 µs (27.0%)
iast	1.512 ms [1.487 ms, 1.537 ms]	133.588 µs (9.7%)
profiling	1.546 ms [1.521 ms, 1.571 ms]	167.965 µs (12.2%)
tracing	1.495 ms [1.47 ms, 1.519 ms]	116.23 µs (8.4%)

Dacapo

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

Disable capture of entry values
d5d15f1
Due to overhead induced by capturing entry values because we need to freeze them (serialize as Json) immediately before even know if we are sampling it or not, compared to the usefulness of having those values we only capture at exit by default.

jpbempel added type: bug fix Bug fix comp: debugger Dynamic Instrumentation labels Feb 11, 2025

jpbempel requested a review from a team as a code owner February 11, 2025 13:37

jpbempel requested review from evanchooly and removed request for a teamFebruary 11, 2025 13:37

tylfin approved these changes Feb 11, 2025
View reviewed changes

jpbempel merged commit e037162 into masterFeb 12, 2025

jpbempel deleted the jpbempel/disable-capture-entry-values branch February 12, 2025 08:41

github-actionsBot added this to the 1.47.0 milestone Feb 12, 2025

evanchooly mentioned this pull request Feb 19, 2025
🍒 8369 - Disable capture of entry values #8424
Merged

Navigation Menu

Uh oh!

Disable capture of entry values - #8369

Disable capture of entry values#8369
jpbempel merged 1 commit into
masterfrom
jpbempel/disable-capture-entry-values

jpbempel commented Feb 11, 2025

Uh oh!

pr-commenterBot commented Feb 11, 2025

Uh oh!

pr-commenterBot commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jpbempel commented Feb 11, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Feb 11, 2025

Debugger benchmarks

Parameters

Summary

Uh oh!

pr-commenterBot commented Feb 11, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants