Disable smap RSS parsing by default by MattAlp · Pull Request #8342 · DataDog/dd-trace-java

MattAlp · 2025-02-05T15:59:13Z

What Does This Do

This disables the parsing of RSS from /proc/pid/smaps by default to be mindful of heavily resource-constrained systems.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: PROF-10699

jbachorik

Could you also remove the logging in SmapEntryFactory.registerEvents() when dcmd is not found, unless it is at debug level?
With those events disabled by default this initialization will be executed at startup but the functionality will be disabled.

pr-commenter · 2025-02-05T16:39:12Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mattalp/disable-rss-tracking-by-default
git_commit_date	1738769011	1738772267
git_commit_sha	`1083178`	`a53514a`
release_version	1.47.0-SNAPSHOT~1083178bc0	1.47.0-SNAPSHOT~a53514a155

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738774801	1738774801
ci_job_id	795625351	795625351
ci_pipeline_id	54999663	54999663
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-qmwscw3r-project-304-concurrent-0-1efvisjm 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-qmwscw3r-project-304-concurrent-0-1efvisjm 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~a53514a155, baseline=1.47.0-SNAPSHOT~1083178bc0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049495
Total [baseline] (10.5 s) : 0, 10499894
Agent [candidate] (1.043 s) : 0, 1042558
Total [candidate] (10.537 s) : 0, 10536513
section appsec
Agent [baseline] (1.189 s) : 0, 1189029
Total [baseline] (10.745 s) : 0, 10744817
Agent [candidate] (1.199 s) : 0, 1199220
Total [candidate] (10.766 s) : 0, 10766339
section iast
Agent [baseline] (1.174 s) : 0, 1173847
Total [baseline] (10.943 s) : 0, 10943083
Agent [candidate] (1.179 s) : 0, 1179078
Total [candidate] (11.008 s) : 0, 11008441
section profiling
Agent [baseline] (1.28 s) : 0, 1279906
Total [baseline] (10.916 s) : 0, 10915958
Agent [candidate] (1.26 s) : 0, 1259650
Total [candidate] (10.877 s) : 0, 10877296

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	appsec	1.189 s	139.533 ms (13.3%)
Agent	iast	1.174 s	124.351 ms (11.8%)
Agent	profiling	1.28 s	230.41 ms (22.0%)
Total	tracing	10.5 s	-
Total	appsec	10.745 s	244.923 ms (2.3%)
Total	iast	10.943 s	443.188 ms (4.2%)
Total	profiling	10.916 s	416.063 ms (4.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	appsec	1.199 s	156.662 ms (15.0%)
Agent	iast	1.179 s	136.52 ms (13.1%)
Agent	profiling	1.26 s	217.092 ms (20.8%)
Total	tracing	10.537 s	-
Total	appsec	10.766 s	229.827 ms (2.2%)
Total	iast	11.008 s	471.928 ms (4.5%)
Total	profiling	10.877 s	340.783 ms (3.2%)

gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~a53514a155, baseline=1.47.0-SNAPSHOT~1083178bc0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.369 ms) : 0, 720369
BytebuddyAgent [candidate] (715.248 ms) : 0, 715248
GlobalTracer [baseline] (244.26 ms) : 0, 244260
GlobalTracer [candidate] (243.297 ms) : 0, 243297
AppSec [baseline] (55.331 ms) : 0, 55331
AppSec [candidate] (55.107 ms) : 0, 55107
Remote Config [baseline] (727.812 µs) : 0, 728
Remote Config [candidate] (712.622 µs) : 0, 713
Telemetry [baseline] (13.629 ms) : 0, 13629
Telemetry [candidate] (12.988 ms) : 0, 12988
section appsec
BytebuddyAgent [baseline] (736.35 ms) : 0, 736350
BytebuddyAgent [candidate] (743.763 ms) : 0, 743763
GlobalTracer [baseline] (240.925 ms) : 0, 240925
GlobalTracer [candidate] (242.923 ms) : 0, 242923
AppSec [baseline] (176.511 ms) : 0, 176511
AppSec [candidate] (176.819 ms) : 0, 176819
Remote Config [baseline] (661.498 µs) : 0, 661
Remote Config [candidate] (666.563 µs) : 0, 667
Telemetry [baseline] (8.288 ms) : 0, 8288
Telemetry [candidate] (8.664 ms) : 0, 8664
IAST [baseline] (21.993 ms) : 0, 21993
IAST [candidate] (22.109 ms) : 0, 22109
section iast
BytebuddyAgent [baseline] (835.556 ms) : 0, 835556
BytebuddyAgent [candidate] (839.61 ms) : 0, 839610
GlobalTracer [baseline] (233.624 ms) : 0, 233624
GlobalTracer [candidate] (234.822 ms) : 0, 234822
AppSec [baseline] (57.199 ms) : 0, 57199
AppSec [candidate] (56.971 ms) : 0, 56971
Remote Config [baseline] (629.905 µs) : 0, 630
Remote Config [candidate] (621.027 µs) : 0, 621
Telemetry [baseline] (8.719 ms) : 0, 8719
Telemetry [candidate] (8.726 ms) : 0, 8726
IAST [baseline] (22.867 ms) : 0, 22867
IAST [candidate] (23.011 ms) : 0, 23011
section profiling
ProfilingAgent [baseline] (98.478 ms) : 0, 98478
ProfilingAgent [candidate] (95.37 ms) : 0, 95370
BytebuddyAgent [baseline] (715.811 ms) : 0, 715811
BytebuddyAgent [candidate] (704.689 ms) : 0, 704689
GlobalTracer [baseline] (357.267 ms) : 0, 357267
GlobalTracer [candidate] (353.71 ms) : 0, 353710
AppSec [baseline] (56.029 ms) : 0, 56029
AppSec [candidate] (54.2 ms) : 0, 54200
Remote Config [baseline] (714.613 µs) : 0, 715
Remote Config [candidate] (719.433 µs) : 0, 719
Telemetry [baseline] (9.022 ms) : 0, 9022
Telemetry [candidate] (8.866 ms) : 0, 8866
Profiling [baseline] (98.502 ms) : 0, 98502
Profiling [candidate] (95.394 ms) : 0, 95394

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~a53514a155, baseline=1.47.0-SNAPSHOT~1083178bc0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046624
Total [baseline] (8.628 s) : 0, 8627729
Agent [candidate] (1.048 s) : 0, 1047521
Total [candidate] (8.63 s) : 0, 8629864
section iast
Agent [baseline] (1.173 s) : 0, 1172995
Total [baseline] (9.188 s) : 0, 9187672
Agent [candidate] (1.174 s) : 0, 1173884
Total [candidate] (9.2 s) : 0, 9199500
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1179613
Total [baseline] (9.209 s) : 0, 9208998
Agent [candidate] (1.172 s) : 0, 1172141
Total [candidate] (9.177 s) : 0, 9177317
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176364
Total [baseline] (9.194 s) : 0, 9193934
Agent [candidate] (1.17 s) : 0, 1169572
Total [candidate] (9.231 s) : 0, 9230665

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	iast	1.173 s	126.371 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.18 s	132.989 ms (12.7%)
Agent	iast_TELEMETRY_OFF	1.176 s	129.739 ms (12.4%)
Total	tracing	8.628 s	-
Total	iast	9.188 s	559.944 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.209 s	581.269 ms (6.7%)
Total	iast_TELEMETRY_OFF	9.194 s	566.205 ms (6.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	iast	1.174 s	126.363 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	124.62 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.17 s	122.051 ms (11.7%)
Total	tracing	8.63 s	-
Total	iast	9.2 s	569.637 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.177 s	547.453 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.231 s	600.801 ms (7.0%)

gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~a53514a155, baseline=1.47.0-SNAPSHOT~1083178bc0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.853 ms) : 0, 717853
BytebuddyAgent [candidate] (721.044 ms) : 0, 721044
GlobalTracer [baseline] (243.817 ms) : 0, 243817
GlobalTracer [candidate] (243.382 ms) : 0, 243382
AppSec [baseline] (55.335 ms) : 0, 55335
AppSec [candidate] (55.06 ms) : 0, 55060
Remote Config [baseline] (706.926 µs) : 0, 707
Remote Config [candidate] (723.26 µs) : 0, 723
Telemetry [baseline] (13.671 ms) : 0, 13671
Telemetry [candidate] (12.142 ms) : 0, 12142
section iast
BytebuddyAgent [baseline] (834.926 ms) : 0, 834926
BytebuddyAgent [candidate] (835.696 ms) : 0, 835696
GlobalTracer [baseline] (233.81 ms) : 0, 233810
GlobalTracer [candidate] (234.233 ms) : 0, 234233
IAST [baseline] (22.697 ms) : 0, 22697
IAST [candidate] (22.765 ms) : 0, 22765
AppSec [baseline] (56.974 ms) : 0, 56974
AppSec [candidate] (56.771 ms) : 0, 56771
Remote Config [baseline] (605.892 µs) : 0, 606
Remote Config [candidate] (608.926 µs) : 0, 609
Telemetry [baseline] (8.721 ms) : 0, 8721
Telemetry [candidate] (8.649 ms) : 0, 8649
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.725 ms) : 0, 839725
BytebuddyAgent [candidate] (833.948 ms) : 0, 833948
GlobalTracer [baseline] (234.92 ms) : 0, 234920
GlobalTracer [candidate] (233.926 ms) : 0, 233926
IAST [baseline] (23.219 ms) : 0, 23219
IAST [candidate] (22.802 ms) : 0, 22802
AppSec [baseline] (56.957 ms) : 0, 56957
AppSec [candidate] (56.86 ms) : 0, 56860
Remote Config [baseline] (617.222 µs) : 0, 617
Remote Config [candidate] (627.609 µs) : 0, 628
Telemetry [baseline] (8.679 ms) : 0, 8679
Telemetry [candidate] (8.705 ms) : 0, 8705
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.57 ms) : 0, 837570
BytebuddyAgent [candidate] (832.382 ms) : 0, 832382
GlobalTracer [baseline] (234.453 ms) : 0, 234453
GlobalTracer [candidate] (233.661 ms) : 0, 233661
IAST [baseline] (24.905 ms) : 0, 24905
IAST [candidate] (26.344 ms) : 0, 26344
AppSec [baseline] (54.678 ms) : 0, 54678
AppSec [candidate] (52.815 ms) : 0, 52815
Remote Config [baseline] (627.661 µs) : 0, 628
Remote Config [candidate] (627.943 µs) : 0, 628
Telemetry [baseline] (8.629 ms) : 0, 8629
Telemetry [candidate] (8.519 ms) : 0, 8519

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-05T16:29:53	2025-02-05T16:36:56
git_branch	master	mattalp/disable-rss-tracking-by-default
git_commit_date	1738769011	1738772267
git_commit_sha	`1083178`	`a53514a`
release_version	1.47.0-SNAPSHOT~1083178bc0	1.47.0-SNAPSHOT~a53514a155
start_time	2025-02-05T16:29:39	2025-02-05T16:36:42

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738773774	1738773774
ci_job_id	795625352	795625352
ci_pipeline_id	54999663	54999663
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-qmwscw3r-project-304-concurrent-1-ppns15sz 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-qmwscw3r-project-304-concurrent-1-ppns15sz 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~a53514a155, baseline=1.47.0-SNAPSHOT~1083178bc0
dateFormat X
axisFormat %s
section baseline
no_agent (376.802 µs) : 357, 397
. : milestone, 377,
iast (504.957 µs) : 483, 527
. : milestone, 505,
iast_FULL (740.484 µs) : 719, 762
. : milestone, 740,
iast_GLOBAL (545.986 µs) : 524, 568
. : milestone, 546,
iast_HARDCODED_SECRET_DISABLED (501.076 µs) : 479, 523
. : milestone, 501,
iast_INACTIVE (450.931 µs) : 429, 473
. : milestone, 451,
iast_TELEMETRY_OFF (492.688 µs) : 470, 515
. : milestone, 493,
tracing (451.994 µs) : 431, 473
. : milestone, 452,
section candidate
no_agent (374.438 µs) : 354, 395
. : milestone, 374,
iast (502.666 µs) : 481, 525
. : milestone, 503,
iast_FULL (735.94 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (546.872 µs) : 525, 569
. : milestone, 547,
iast_HARDCODED_SECRET_DISABLED (507.879 µs) : 486, 530
. : milestone, 508,
iast_INACTIVE (452.068 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (497.282 µs) : 476, 519
. : milestone, 497,
tracing (451.557 µs) : 430, 473
. : milestone, 452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	376.802 µs [357.086 µs, 396.518 µs]	-
iast	504.957 µs [482.91 µs, 527.003 µs]	128.154 µs (34.0%)
iast_FULL	740.484 µs [718.55 µs, 762.418 µs]	363.682 µs (96.5%)
iast_GLOBAL	545.986 µs [523.969 µs, 568.004 µs]	169.184 µs (44.9%)
iast_HARDCODED_SECRET_DISABLED	501.076 µs [479.337 µs, 522.815 µs]	124.274 µs (33.0%)
iast_INACTIVE	450.931 µs [428.744 µs, 473.118 µs]	74.129 µs (19.7%)
iast_TELEMETRY_OFF	492.688 µs [470.5 µs, 514.877 µs]	115.886 µs (30.8%)
tracing	451.994 µs [430.805 µs, 473.182 µs]	75.192 µs (20.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	374.438 µs [354.132 µs, 394.744 µs]	-
iast	502.666 µs [480.79 µs, 524.542 µs]	128.228 µs (34.2%)
iast_FULL	735.94 µs [714.173 µs, 757.708 µs]	361.502 µs (96.5%)
iast_GLOBAL	546.872 µs [525.222 µs, 568.522 µs]	172.434 µs (46.1%)
iast_HARDCODED_SECRET_DISABLED	507.879 µs [485.912 µs, 529.846 µs]	133.441 µs (35.6%)
iast_INACTIVE	452.068 µs [430.983 µs, 473.153 µs]	77.63 µs (20.7%)
iast_TELEMETRY_OFF	497.282 µs [475.578 µs, 518.986 µs]	122.844 µs (32.8%)
tracing	451.557 µs [430.417 µs, 472.697 µs]	77.119 µs (20.6%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~a53514a155, baseline=1.47.0-SNAPSHOT~1083178bc0
dateFormat X
axisFormat %s
section baseline
no_agent (1.341 ms) : 1321, 1361
. : milestone, 1341,
appsec (1.735 ms) : 1712, 1759
. : milestone, 1735,
appsec_no_iast (1.739 ms) : 1715, 1763
. : milestone, 1739,
iast (1.511 ms) : 1486, 1535
. : milestone, 1511,
profiling (1.544 ms) : 1520, 1568
. : milestone, 1544,
tracing (1.493 ms) : 1469, 1517
. : milestone, 1493,
section candidate
no_agent (1.357 ms) : 1336, 1377
. : milestone, 1357,
appsec (1.743 ms) : 1720, 1766
. : milestone, 1743,
appsec_no_iast (1.75 ms) : 1726, 1773
. : milestone, 1750,
iast (1.508 ms) : 1484, 1532
. : milestone, 1508,
profiling (1.543 ms) : 1519, 1567
. : milestone, 1543,
tracing (1.5 ms) : 1476, 1523
. : milestone, 1500,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.341 ms [1.321 ms, 1.361 ms]	-
appsec	1.735 ms [1.712 ms, 1.759 ms]	394.46 µs (29.4%)
appsec_no_iast	1.739 ms [1.715 ms, 1.763 ms]	398.057 µs (29.7%)
iast	1.511 ms [1.486 ms, 1.535 ms]	169.626 µs (12.6%)
profiling	1.544 ms [1.52 ms, 1.568 ms]	203.239 µs (15.2%)
tracing	1.493 ms [1.469 ms, 1.517 ms]	151.64 µs (11.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.357 ms [1.336 ms, 1.377 ms]	-
appsec	1.743 ms [1.72 ms, 1.766 ms]	386.406 µs (28.5%)
appsec_no_iast	1.75 ms [1.726 ms, 1.773 ms]	393.12 µs (29.0%)
iast	1.508 ms [1.484 ms, 1.532 ms]	151.287 µs (11.2%)
profiling	1.543 ms [1.519 ms, 1.567 ms]	186.605 µs (13.8%)
tracing	1.5 ms [1.476 ms, 1.523 ms]	142.972 µs (10.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mattalp/disable-rss-tracking-by-default
git_commit_date	1738769011	1738772267
git_commit_sha	`1083178`	`a53514a`
release_version	1.47.0-SNAPSHOT~1083178bc0	1.47.0-SNAPSHOT~a53514a155

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1738774300	1738774300
ci_job_id	795625353	795625353
ci_pipeline_id	54999663	54999663
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-9e4gtdsb-project-304-concurrent-0-kk2en2ku 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-9e4gtdsb-project-304-concurrent-0-kk2en2ku 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~a53514a155, baseline=1.47.0-SNAPSHOT~1083178bc0
dateFormat X
axisFormat %s
section baseline
no_agent (15.451 s) : 15451000, 15451000
. : milestone, 15451000,
appsec (15.2 s) : 15200000, 15200000
. : milestone, 15200000,
iast (18.409 s) : 18409000, 18409000
. : milestone, 18409000,
iast_GLOBAL (17.959 s) : 17959000, 17959000
. : milestone, 17959000,
profiling (15.207 s) : 15207000, 15207000
. : milestone, 15207000,
tracing (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
section candidate
no_agent (15.228 s) : 15228000, 15228000
. : milestone, 15228000,
appsec (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
iast (18.335 s) : 18335000, 18335000
. : milestone, 18335000,
iast_GLOBAL (18.33 s) : 18330000, 18330000
. : milestone, 18330000,
profiling (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
tracing (14.843 s) : 14843000, 14843000
. : milestone, 14843000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.451 s [15.451 s, 15.451 s]	-
appsec	15.2 s [15.2 s, 15.2 s]	-251.0 ms (-1.6%)
iast	18.409 s [18.409 s, 18.409 s]	2.958 s (19.1%)
iast_GLOBAL	17.959 s [17.959 s, 17.959 s]	2.508 s (16.2%)
profiling	15.207 s [15.207 s, 15.207 s]	-244.0 ms (-1.6%)
tracing	15.017 s [15.017 s, 15.017 s]	-434.0 ms (-2.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.228 s [15.228 s, 15.228 s]	-
appsec	15.072 s [15.072 s, 15.072 s]	-156.0 ms (-1.0%)
iast	18.335 s [18.335 s, 18.335 s]	3.107 s (20.4%)
iast_GLOBAL	18.33 s [18.33 s, 18.33 s]	3.102 s (20.4%)
profiling	15.05 s [15.05 s, 15.05 s]	-178.0 ms (-1.2%)
tracing	14.843 s [14.843 s, 14.843 s]	-385.0 ms (-2.5%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~a53514a155, baseline=1.47.0-SNAPSHOT~1083178bc0
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.348 ms) : 2304, 2391
. : milestone, 2348,
iast (2.101 ms) : 2046, 2155
. : milestone, 2101,
iast_GLOBAL (2.14 ms) : 2085, 2195
. : milestone, 2140,
profiling (1.994 ms) : 1948, 2041
. : milestone, 1994,
tracing (1.943 ms) : 1901, 1985
. : milestone, 1943,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.352 ms) : 2309, 2395
. : milestone, 2352,
iast (2.095 ms) : 2040, 2149
. : milestone, 2095,
iast_GLOBAL (2.143 ms) : 2088, 2198
. : milestone, 2143,
profiling (1.978 ms) : 1933, 2023
. : milestone, 1978,
tracing (1.936 ms) : 1894, 1978
. : milestone, 1936,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.464 ms [1.452 ms, 1.475 ms]	-
appsec	2.348 ms [2.304 ms, 2.391 ms]	883.89 µs (60.4%)
iast	2.101 ms [2.046 ms, 2.155 ms]	636.787 µs (43.5%)
iast_GLOBAL	2.14 ms [2.085 ms, 2.195 ms]	675.814 µs (46.2%)
profiling	1.994 ms [1.948 ms, 2.041 ms]	530.315 µs (36.2%)
tracing	1.943 ms [1.901 ms, 1.985 ms]	479.164 µs (32.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.455 ms, 1.478 ms]	-
appsec	2.352 ms [2.309 ms, 2.395 ms]	885.275 µs (60.4%)
iast	2.095 ms [2.04 ms, 2.149 ms]	627.978 µs (42.8%)
iast_GLOBAL	2.143 ms [2.088 ms, 2.198 ms]	676.267 µs (46.1%)
profiling	1.978 ms [1.933 ms, 2.023 ms]	511.289 µs (34.9%)
tracing	1.936 ms [1.894 ms, 1.978 ms]	469.02 µs (32.0%)

manuel-alvarez-alvarez

LGTM

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

Disable smap RSS parsing by default
5a9529c

MattAlp added type: refactoring comp: profiling Profiling labels Feb 5, 2025

MattAlp requested a review from jbachorik February 5, 2025 15:59

MattAlp requested a review from a team as a code owner February 5, 2025 15:59

MattAlp requested a review from manuel-alvarez-alvarez February 5, 2025 15:59

jbachorik requested changes Feb 5, 2025
View reviewed changes

Reduce logging level for smap scraping
a53514a

MattAlp requested a review from jbachorik February 5, 2025 16:18

jbachorik approved these changes Feb 5, 2025
View reviewed changes

manuel-alvarez-alvarez approved these changes Feb 6, 2025
View reviewed changes

MattAlp merged commit 97961ff into masterFeb 6, 2025

MattAlp deleted the mattalp/disable-rss-tracking-by-default branch February 6, 2025 14:13

github-actionsBot added this to the 1.47.0 milestone Feb 6, 2025

jbachorik mentioned this pull request Feb 19, 2025
SmapEntryFactory - Smap entry events could not be registered due to missing systemMap operation #8067
Open

Navigation Menu

Uh oh!

Disable smap RSS parsing by default - #8342

Disable smap RSS parsing by default#8342
MattAlp merged 2 commits into
masterfrom
mattalp/disable-rss-tracking-by-default

MattAlp commented Feb 5, 2025•
edited by atlassian Bot
Loading

Uh oh!

jbachorik left a comment

Uh oh!

pr-commenterBot commented Feb 5, 2025•
edited
Loading

Uh oh!

manuel-alvarez-alvarez left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

MattAlp commented Feb 5, 2025• edited by atlassian BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

jbachorik left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenterBot commented Feb 5, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MattAlp commented Feb 5, 2025•
edited by atlassian Bot
Loading

pr-commenterBot commented Feb 5, 2025•
edited
Loading