Send error message and stack to Lambda extension by nhulston · Pull Request #8417 · DataDog/dd-trace-java

nhulston · 2025-02-18T20:29:19Z

What Does This Do

Call span.addThrowable(throwable); in the Lambda handler instrumentation. This allows the error tags to get passed to the Lambda extension in this file:

dd-trace-java/dd-trace-core/src/main/java/datadog/trace/lambda/LambdaHandler.java

Lines 119 to 139 in 5bd6139

ObjecterrorMessage = span.getTag(DDTags.ERROR_MSG); 
if (errorMessage != null) { 
builder.addHeader(DATADOG_INVOCATION_ERROR_MSG, errorMessage.toString()); 
 } 
ObjecterrorType = span.getTag(DDTags.ERROR_TYPE); 
if (errorType != null) { 
builder.addHeader(DATADOG_INVOCATION_ERROR_TYPE, errorType.toString()); 
 } 
ObjecterrorStack = span.getTag(DDTags.ERROR_STACK); 
if (errorStack != null) { 
StringencodedErrStack = 
Base64.getEncoder() 
 .encodeToString(errorStack.toString().getBytes(StandardCharsets.UTF_8)); 
builder.addHeader(DATADOG_INVOCATION_ERROR_STACK, encodedErrStack); 
 } 
if (isError) { 
builder.addHeader(DATADOG_INVOCATION_ERROR, "true"); 
 } 

Before this change, we'd see this message in Datadog, which isn't helpful:

Now, we actually see the error message:

Motivation

An issue was opened in Zendesk

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-02-18T21:03:36Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nicholas.hulston/pass-error-tags-to-lambda-extension
git_commit_date	1740058310	1740060465
git_commit_sha	`10dc2ef`	`5540855`
release_version	1.47.0-SNAPSHOT~10dc2ef4fb	1.47.0-SNAPSHOT~554085511a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740063046	1740063046
ci_job_id	815891769	815891769
ci_pipeline_id	56426031	56426031
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-sezc2swb-project-304-concurrent-0-0sk18vai 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-sezc2swb-project-304-concurrent-0-0sk18vai 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~554085511a, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039607
Total [baseline] (10.405 s) : 0, 10405174
Agent [candidate] (1.043 s) : 0, 1042776
Total [candidate] (10.426 s) : 0, 10426475
section appsec
Agent [baseline] (1.184 s) : 0, 1184116
Total [baseline] (10.726 s) : 0, 10726440
Agent [candidate] (1.187 s) : 0, 1187328
Total [candidate] (10.755 s) : 0, 10755134
section iast
Agent [baseline] (1.181 s) : 0, 1180729
Total [baseline] (11.011 s) : 0, 11010514
Agent [candidate] (1.173 s) : 0, 1172932
Total [candidate] (11.039 s) : 0, 11038966
section profiling
Agent [baseline] (1.264 s) : 0, 1264287
Total [baseline] (10.857 s) : 0, 10857224
Agent [candidate] (1.263 s) : 0, 1262778
Total [candidate] (10.882 s) : 0, 10881869

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	appsec	1.184 s	144.508 ms (13.9%)
Agent	iast	1.181 s	141.122 ms (13.6%)
Agent	profiling	1.264 s	224.68 ms (21.6%)
Total	tracing	10.405 s	-
Total	appsec	10.726 s	321.266 ms (3.1%)
Total	iast	11.011 s	605.34 ms (5.8%)
Total	profiling	10.857 s	452.05 ms (4.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	appsec	1.187 s	144.552 ms (13.9%)
Agent	iast	1.173 s	130.156 ms (12.5%)
Agent	profiling	1.263 s	220.002 ms (21.1%)
Total	tracing	10.426 s	-
Total	appsec	10.755 s	328.659 ms (3.2%)
Total	iast	11.039 s	612.492 ms (5.9%)
Total	profiling	10.882 s	455.394 ms (4.4%)

gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~554085511a, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.715 ms) : 0, 717715
BytebuddyAgent [candidate] (718.133 ms) : 0, 718133
GlobalTracer [baseline] (239.11 ms) : 0, 239110
GlobalTracer [candidate] (240.746 ms) : 0, 240746
AppSec [baseline] (55.404 ms) : 0, 55404
AppSec [candidate] (55.722 ms) : 0, 55722
Remote Config [baseline] (693.127 µs) : 0, 693
Remote Config [candidate] (691.162 µs) : 0, 691
Telemetry [baseline] (11.531 ms) : 0, 11531
Telemetry [candidate] (12.302 ms) : 0, 12302
section appsec
BytebuddyAgent [baseline] (736.488 ms) : 0, 736488
BytebuddyAgent [candidate] (737.645 ms) : 0, 737645
GlobalTracer [baseline] (236.172 ms) : 0, 236172
GlobalTracer [candidate] (237.042 ms) : 0, 237042
IAST [baseline] (21.508 ms) : 0, 21508
IAST [candidate] (21.473 ms) : 0, 21473
AppSec [baseline] (176.516 ms) : 0, 176516
AppSec [candidate] (177.7 ms) : 0, 177700
Remote Config [baseline] (662.923 µs) : 0, 663
Remote Config [candidate] (671.483 µs) : 0, 671
Telemetry [baseline] (8.276 ms) : 0, 8276
Telemetry [candidate] (8.298 ms) : 0, 8298
section iast
BytebuddyAgent [baseline] (843.653 ms) : 0, 843653
BytebuddyAgent [candidate] (837.475 ms) : 0, 837475
GlobalTracer [baseline] (231.619 ms) : 0, 231619
GlobalTracer [candidate] (230.423 ms) : 0, 230423
IAST [baseline] (23.132 ms) : 0, 23132
IAST [candidate] (22.966 ms) : 0, 22966
AppSec [baseline] (57.633 ms) : 0, 57633
AppSec [candidate] (57.473 ms) : 0, 57473
Remote Config [baseline] (625.4 µs) : 0, 625
Remote Config [candidate] (612.457 µs) : 0, 612
Telemetry [baseline] (8.758 ms) : 0, 8758
Telemetry [candidate] (8.711 ms) : 0, 8711
section profiling
BytebuddyAgent [baseline] (710.22 ms) : 0, 710220
BytebuddyAgent [candidate] (709.372 ms) : 0, 709372
GlobalTracer [baseline] (350.245 ms) : 0, 350245
GlobalTracer [candidate] (350.796 ms) : 0, 350796
AppSec [baseline] (55.225 ms) : 0, 55225
AppSec [candidate] (54.193 ms) : 0, 54193
Remote Config [baseline] (677.128 µs) : 0, 677
Remote Config [candidate] (677.543 µs) : 0, 678
Telemetry [baseline] (9.011 ms) : 0, 9011
Telemetry [candidate] (8.91 ms) : 0, 8910
ProfilingAgent [baseline] (96.537 ms) : 0, 96537
ProfilingAgent [candidate] (96.564 ms) : 0, 96564
Profiling [baseline] (96.561 ms) : 0, 96561
Profiling [candidate] (96.589 ms) : 0, 96589

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~554085511a, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043359
Total [baseline] (8.672 s) : 0, 8672475
Agent [candidate] (1.043 s) : 0, 1042717
Total [candidate] (8.637 s) : 0, 8636665
section iast
Agent [baseline] (1.173 s) : 0, 1173364
Total [baseline] (9.229 s) : 0, 9229376
Agent [candidate] (1.172 s) : 0, 1171969
Total [candidate] (9.223 s) : 0, 9222605
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1179825
Total [baseline] (9.243 s) : 0, 9243023
Agent [candidate] (1.174 s) : 0, 1173684
Total [candidate] (9.193 s) : 0, 9193224
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1166717
Total [baseline] (9.237 s) : 0, 9236969
Agent [candidate] (1.171 s) : 0, 1170859
Total [candidate] (9.173 s) : 0, 9173017

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	iast	1.173 s	130.006 ms (12.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.18 s	136.466 ms (13.1%)
Agent	iast_TELEMETRY_OFF	1.167 s	123.358 ms (11.8%)
Total	tracing	8.672 s	-
Total	iast	9.229 s	556.901 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.243 s	570.547 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.237 s	564.494 ms (6.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	iast	1.172 s	129.252 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	130.966 ms (12.6%)
Agent	iast_TELEMETRY_OFF	1.171 s	128.142 ms (12.3%)
Total	tracing	8.637 s	-
Total	iast	9.223 s	585.939 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.193 s	556.559 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.173 s	536.352 ms (6.2%)

gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~554085511a, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.912 ms) : 0, 718912
BytebuddyAgent [candidate] (719.503 ms) : 0, 719503
GlobalTracer [baseline] (239.847 ms) : 0, 239847
GlobalTracer [candidate] (240.0 ms) : 0, 240000
AppSec [baseline] (55.432 ms) : 0, 55432
AppSec [candidate] (55.71 ms) : 0, 55710
Remote Config [baseline] (703.022 µs) : 0, 703
Remote Config [candidate] (699.447 µs) : 0, 699
Telemetry [baseline] (13.181 ms) : 0, 13181
Telemetry [candidate] (11.612 ms) : 0, 11612
section iast
BytebuddyAgent [baseline] (837.291 ms) : 0, 837291
BytebuddyAgent [candidate] (836.647 ms) : 0, 836647
GlobalTracer [baseline] (231.115 ms) : 0, 231115
GlobalTracer [candidate] (230.34 ms) : 0, 230340
IAST [baseline] (22.915 ms) : 0, 22915
IAST [candidate] (22.871 ms) : 0, 22871
AppSec [baseline] (57.475 ms) : 0, 57475
AppSec [candidate] (57.552 ms) : 0, 57552
Remote Config [baseline] (617.638 µs) : 0, 618
Remote Config [candidate] (621.923 µs) : 0, 622
Telemetry [baseline] (8.694 ms) : 0, 8694
Telemetry [candidate] (8.658 ms) : 0, 8658
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (843.13 ms) : 0, 843130
BytebuddyAgent [candidate] (837.869 ms) : 0, 837869
GlobalTracer [baseline] (231.663 ms) : 0, 231663
GlobalTracer [candidate] (230.603 ms) : 0, 230603
IAST [baseline] (22.855 ms) : 0, 22855
IAST [candidate] (22.949 ms) : 0, 22949
AppSec [baseline] (57.407 ms) : 0, 57407
AppSec [candidate] (57.607 ms) : 0, 57607
Remote Config [baseline] (609.146 µs) : 0, 609
Remote Config [candidate] (617.876 µs) : 0, 618
Telemetry [baseline] (8.721 ms) : 0, 8721
Telemetry [candidate] (8.733 ms) : 0, 8733
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.539 ms) : 0, 832539
BytebuddyAgent [candidate] (836.086 ms) : 0, 836086
GlobalTracer [baseline] (230.241 ms) : 0, 230241
GlobalTracer [candidate] (230.762 ms) : 0, 230762
IAST [baseline] (26.296 ms) : 0, 26296
IAST [candidate] (27.884 ms) : 0, 27884
AppSec [baseline] (53.221 ms) : 0, 53221
AppSec [candidate] (51.558 ms) : 0, 51558
Remote Config [baseline] (608.622 µs) : 0, 609
Remote Config [candidate] (623.9 µs) : 0, 624
Telemetry [baseline] (8.591 ms) : 0, 8591
Telemetry [candidate] (8.616 ms) : 0, 8616

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-20T14:20:11	2025-02-20T14:27:14
git_branch	master	nicholas.hulston/pass-error-tags-to-lambda-extension
git_commit_date	1740058310	1740060465
git_commit_sha	`10dc2ef`	`5540855`
release_version	1.47.0-SNAPSHOT~10dc2ef4fb	1.47.0-SNAPSHOT~554085511a
start_time	2025-02-20T14:19:57	2025-02-20T14:27:00

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1740061991	1740061991
ci_job_id	815891770	815891770
ci_pipeline_id	56426031	56426031
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-n6wpmhv-project-304-concurrent-0-36dg55qz 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-n6wpmhv-project-304-concurrent-0-36dg55qz 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:profiling	worse [+44.182µs; +97.653µs] or [+2.975%; +6.576%]	unstable [-807.690op/s; +333.615op/s] or [-25.240%; +10.425%]	1.556ms	2962.963op/s	1.485ms	3200.000op/s

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~554085511a, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section baseline
no_agent (386.522 µs) : 367, 406
. : milestone, 387,
iast (515.295 µs) : 493, 537
. : milestone, 515,
iast_FULL (723.896 µs) : 702, 746
. : milestone, 724,
iast_GLOBAL (557.284 µs) : 535, 579
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (511.5 µs) : 489, 534
. : milestone, 512,
iast_INACTIVE (461.205 µs) : 440, 483
. : milestone, 461,
iast_TELEMETRY_OFF (499.771 µs) : 477, 523
. : milestone, 500,
tracing (451.965 µs) : 431, 473
. : milestone, 452,
section candidate
no_agent (383.736 µs) : 363, 404
. : milestone, 384,
iast (507.714 µs) : 485, 531
. : milestone, 508,
iast_FULL (729.814 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (560.191 µs) : 538, 582
. : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (523.712 µs) : 501, 546
. : milestone, 524,
iast_INACTIVE (460.737 µs) : 439, 483
. : milestone, 461,
iast_TELEMETRY_OFF (494.323 µs) : 471, 517
. : milestone, 494,
tracing (451.247 µs) : 430, 472
. : milestone, 451,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	386.522 µs [366.86 µs, 406.185 µs]	-
iast	515.295 µs [493.25 µs, 537.34 µs]	128.773 µs (33.3%)
iast_FULL	723.896 µs [701.809 µs, 745.984 µs]	337.374 µs (87.3%)
iast_GLOBAL	557.284 µs [535.368 µs, 579.2 µs]	170.762 µs (44.2%)
iast_HARDCODED_SECRET_DISABLED	511.5 µs [489.061 µs, 533.94 µs]	124.978 µs (32.3%)
iast_INACTIVE	461.205 µs [439.668 µs, 482.742 µs]	74.683 µs (19.3%)
iast_TELEMETRY_OFF	499.771 µs [476.578 µs, 522.964 µs]	113.249 µs (29.3%)
tracing	451.965 µs [430.921 µs, 473.009 µs]	65.443 µs (16.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.736 µs [363.464 µs, 404.007 µs]	-
iast	507.714 µs [484.826 µs, 530.602 µs]	123.978 µs (32.3%)
iast_FULL	729.814 µs [707.813 µs, 751.816 µs]	346.079 µs (90.2%)
iast_GLOBAL	560.191 µs [538.129 µs, 582.253 µs]	176.455 µs (46.0%)
iast_HARDCODED_SECRET_DISABLED	523.712 µs [501.07 µs, 546.354 µs]	139.976 µs (36.5%)
iast_INACTIVE	460.737 µs [438.864 µs, 482.609 µs]	77.001 µs (20.1%)
iast_TELEMETRY_OFF	494.323 µs [471.406 µs, 517.241 µs]	110.588 µs (28.8%)
tracing	451.247 µs [430.099 µs, 472.395 µs]	67.512 µs (17.6%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~554085511a, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section baseline
no_agent (1.354 ms) : 1334, 1374
. : milestone, 1354,
appsec (1.751 ms) : 1727, 1774
. : milestone, 1751,
appsec_no_iast (1.752 ms) : 1728, 1776
. : milestone, 1752,
iast (1.515 ms) : 1491, 1539
. : milestone, 1515,
profiling (1.485 ms) : 1461, 1509
. : milestone, 1485,
tracing (1.495 ms) : 1471, 1519
. : milestone, 1495,
section candidate
no_agent (1.356 ms) : 1337, 1376
. : milestone, 1356,
appsec (1.731 ms) : 1707, 1754
. : milestone, 1731,
appsec_no_iast (1.748 ms) : 1723, 1773
. : milestone, 1748,
iast (1.505 ms) : 1481, 1528
. : milestone, 1505,
profiling (1.556 ms) : 1530, 1581
. : milestone, 1556,
tracing (1.489 ms) : 1464, 1513
. : milestone, 1489,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.354 ms [1.334 ms, 1.374 ms]	-
appsec	1.751 ms [1.727 ms, 1.774 ms]	396.849 µs (29.3%)
appsec_no_iast	1.752 ms [1.728 ms, 1.776 ms]	398.174 µs (29.4%)
iast	1.515 ms [1.491 ms, 1.539 ms]	161.29 µs (11.9%)
profiling	1.485 ms [1.461 ms, 1.509 ms]	131.104 µs (9.7%)
tracing	1.495 ms [1.471 ms, 1.519 ms]	141.42 µs (10.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.356 ms [1.337 ms, 1.376 ms]	-
appsec	1.731 ms [1.707 ms, 1.754 ms]	374.158 µs (27.6%)
appsec_no_iast	1.748 ms [1.723 ms, 1.773 ms]	391.53 µs (28.9%)
iast	1.505 ms [1.481 ms, 1.528 ms]	148.232 µs (10.9%)
profiling	1.556 ms [1.53 ms, 1.581 ms]	199.355 µs (14.7%)
tracing	1.489 ms [1.464 ms, 1.513 ms]	132.077 µs (9.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nicholas.hulston/pass-error-tags-to-lambda-extension
git_commit_date	1740058310	1740060465
git_commit_sha	`10dc2ef`	`5540855`
release_version	1.47.0-SNAPSHOT~10dc2ef4fb	1.47.0-SNAPSHOT~554085511a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1740062589	1740062589
ci_job_id	815891771	815891771
ci_pipeline_id	56426031	56426031
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-sezc2swb-project-304-concurrent-2-vivk2sgz 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-sezc2swb-project-304-concurrent-2-vivk2sgz 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~554085511a, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section baseline
no_agent (15.434 s) : 15434000, 15434000
. : milestone, 15434000,
appsec (15.06 s) : 15060000, 15060000
. : milestone, 15060000,
iast (18.779 s) : 18779000, 18779000
. : milestone, 18779000,
iast_GLOBAL (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
profiling (15.559 s) : 15559000, 15559000
. : milestone, 15559000,
tracing (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
section candidate
no_agent (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
appsec (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
iast (18.607 s) : 18607000, 18607000
. : milestone, 18607000,
iast_GLOBAL (18.175 s) : 18175000, 18175000
. : milestone, 18175000,
profiling (15.002 s) : 15002000, 15002000
. : milestone, 15002000,
tracing (15.088 s) : 15088000, 15088000
. : milestone, 15088000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.434 s [15.434 s, 15.434 s]	-
appsec	15.06 s [15.06 s, 15.06 s]	-374.0 ms (-2.4%)
iast	18.779 s [18.779 s, 18.779 s]	3.345 s (21.7%)
iast_GLOBAL	17.896 s [17.896 s, 17.896 s]	2.462 s (16.0%)
profiling	15.559 s [15.559 s, 15.559 s]	125.0 ms (0.8%)
tracing	14.986 s [14.986 s, 14.986 s]	-448.0 ms (-2.9%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.764 s [14.764 s, 14.764 s]	-
appsec	15.174 s [15.174 s, 15.174 s]	410.0 ms (2.8%)
iast	18.607 s [18.607 s, 18.607 s]	3.843 s (26.0%)
iast_GLOBAL	18.175 s [18.175 s, 18.175 s]	3.411 s (23.1%)
profiling	15.002 s [15.002 s, 15.002 s]	238.0 ms (1.6%)
tracing	15.088 s [15.088 s, 15.088 s]	324.0 ms (2.2%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~554085511a, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.36 ms) : 2316, 2403
. : milestone, 2360,
iast (2.11 ms) : 2055, 2165
. : milestone, 2110,
iast_GLOBAL (2.155 ms) : 2100, 2210
. : milestone, 2155,
profiling (1.963 ms) : 1919, 2006
. : milestone, 1963,
tracing (1.945 ms) : 1903, 1987
. : milestone, 1945,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.354 ms) : 2310, 2398
. : milestone, 2354,
iast (2.115 ms) : 2060, 2170
. : milestone, 2115,
iast_GLOBAL (2.147 ms) : 2092, 2203
. : milestone, 2147,
profiling (1.978 ms) : 1933, 2022
. : milestone, 1978,
tracing (1.945 ms) : 1903, 1987
. : milestone, 1945,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.457 ms, 1.48 ms]	-
appsec	2.36 ms [2.316 ms, 2.403 ms]	890.907 µs (60.7%)
iast	2.11 ms [2.055 ms, 2.165 ms]	641.05 µs (43.6%)
iast_GLOBAL	2.155 ms [2.1 ms, 2.21 ms]	686.043 µs (46.7%)
profiling	1.963 ms [1.919 ms, 2.006 ms]	494.167 µs (33.6%)
tracing	1.945 ms [1.903 ms, 1.987 ms]	476.418 µs (32.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	2.354 ms [2.31 ms, 2.398 ms]	881.419 µs (59.9%)
iast	2.115 ms [2.06 ms, 2.17 ms]	642.362 µs (43.6%)
iast_GLOBAL	2.147 ms [2.092 ms, 2.203 ms]	674.516 µs (45.8%)
profiling	1.978 ms [1.933 ms, 2.022 ms]	504.958 µs (34.3%)
tracing	1.945 ms [1.903 ms, 1.987 ms]	472.568 µs (32.1%)

github-actions · 2025-02-19T14:29:36Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Remove the tag from the pull request title

If you need help, please check our contributing guidelines.

…-extension

joeyzhao2018

LGTM

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

nhulston added 2 commits February 18, 2025 15:22

add throwable in Lambda handler instrumentation
0c96c1c

add tests
16db575

nhulston added type: bug fix Bug fix inst: aws lambda AWS Lambda instrumentation labels Feb 18, 2025

fix tests
3e7aa9d

nhulston changed the title ~~Fix 'Error Message' in Datadog for Lambda functions~~[serverless] Fix error message in Datadog UI for Lambda functionsFeb 18, 2025

nhulston changed the title ~~[serverless] Fix error message in Datadog UI for Lambda functions~~[serverless] Send error message and stack to Lambda extensionFeb 18, 2025

nhulston marked this pull request as ready for review February 19, 2025 14:29

nhulston requested a review from a team as a code owner February 19, 2025 14:29

nhulston changed the title ~~[serverless] Send error message and stack to Lambda extension~~Send error message and stack to Lambda extensionFeb 19, 2025

nhulstonand others added 2 commits February 19, 2025 16:33

add throwable only if not null
a0219e8

Merge branch 'master' into nicholas.hulston/pass-error-tags-to-lambda…
5540855
…-extension

joeyzhao2018 approved these changes Feb 20, 2025
View reviewed changes

nhulston merged commit 121f38f into masterFeb 20, 2025

nhulston deleted the nicholas.hulston/pass-error-tags-to-lambda-extension branch February 20, 2025 17:59

github-actionsBot added this to the 1.47.0 milestone Feb 20, 2025

Navigation Menu

Uh oh!

Send error message and stack to Lambda extension - #8417

Send error message and stack to Lambda extension#8417
nhulston merged 5 commits into
masterfrom
nicholas.hulston/pass-error-tags-to-lambda-extension

nhulston commented Feb 18, 2025•
edited
Loading

Uh oh!

pr-commenterBot commented Feb 18, 2025•
edited
Loading

Uh oh!

github-actionsBot commented Feb 19, 2025•
edited
Loading

Uh oh!

joeyzhao2018 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	ObjecterrorMessage = span.getTag(DDTags.ERROR_MSG);
	if (errorMessage != null) {
	builder.addHeader(DATADOG_INVOCATION_ERROR_MSG, errorMessage.toString());
	}

	ObjecterrorType = span.getTag(DDTags.ERROR_TYPE);
	if (errorType != null) {
	builder.addHeader(DATADOG_INVOCATION_ERROR_TYPE, errorType.toString());
	}

	ObjecterrorStack = span.getTag(DDTags.ERROR_STACK);
	if (errorStack != null) {
	StringencodedErrStack =
	Base64.getEncoder()
	.encodeToString(errorStack.toString().getBytes(StandardCharsets.UTF_8));
	builder.addHeader(DATADOG_INVOCATION_ERROR_STACK, encodedErrStack);
	}

	if (isError) {
	builder.addHeader(DATADOG_INVOCATION_ERROR, "true");
	}

Uh oh!

Conversation

nhulston commented Feb 18, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Feb 18, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actionsBot commented Feb 19, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joeyzhao2018 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nhulston commented Feb 18, 2025•
edited
Loading

pr-commenterBot commented Feb 18, 2025•
edited
Loading

github-actionsBot commented Feb 19, 2025•
edited
Loading