Uh oh!
There was an error while loading. Please reload this page.
ARROW-15622: [R] Implement union_all and union for arrow_dplyr_query - #13090
ARROW-15622: [R] Implement union_all and union for arrow_dplyr_query#13090wjones127 wants to merge 7 commits into
Conversation
wjones127
commented
May 9, 2022
Some example usage: library(arrow)
#> #> Attaching package: 'arrow'#> The following object is masked from 'package:utils':#> #> timestamp
library(dplyr)
#> #> Attaching package: 'dplyr'#> The following objects are masked from 'package:stats':#> #> filter, lag#> The following objects are masked from 'package:base':#> #> intersect, setdiff, setequal, uniontab1<- arrow_table(x=1:3)
tab2<- arrow_table(x=2:4, y= c("a", "b", "c"))
tab1|>
mutate(y="a") |>
union_all(tab2) |>
collect()
#> # A tibble: 6 × 2#> x y #> <int> <chr>#> 1 2 a #> 2 3 b #> 3 4 c #> 4 1 a #> 5 2 a #> 6 3 atab1|>
mutate(y="a") |>
union_all(tab2) |>
arrange(x, y) |>
collect()
#> # A tibble: 6 × 2#> x y #> <int> <chr>#> 1 1 a #> 2 2 a #> 3 2 a #> 4 3 a #> 5 3 b #> 6 4 ctab1|>
mutate(y="a") |>dplyr::union(tab2) |>
arrange(x, y) |>
collect()
#> # A tibble: 5 × 2#> x y #> <int> <chr>#> 1 1 a #> 2 2 a #> 3 3 a #> 4 3 b #> 5 4 cCreated on 2022-05-09 by the reprex package (v2.0.1) |
fb0b93a to
2d6d125Compare2d6d125 to
1640771Comparewjones127
commented
May 23, 2022
The timeouts on RTools mingw seem to be random. I ran locally on mingw64 and was able to get it to build and pass all R tests. |
nealrichardson
commented
May 23, 2022
Probably namespace collision: |
nealrichardson
left a comment
There was a problem hiding this comment.
A couple of suggestions on the tests but otherwise LGTM, thanks!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
ursabot
commented
May 24, 2022
Benchmark runs are scheduled for baseline = 6576aa0 and contender = d889ade. d889ade is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
ursabot
commented
May 24, 2022
['Python', 'R'] benchmarks have high level of regressions. |
…Hub issue numbers (#34260) Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature. Issue numbers have been rewritten based on the following correspondence. Also, the pkgdown settings have been changed and updated to link to GitHub. I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly. --- ARROW-6338#5198ARROW-6364#5201ARROW-6323#5169ARROW-6278#5141ARROW-6360#5329ARROW-6533#5450ARROW-6348#5223ARROW-6337#5399ARROW-10850#9128ARROW-10624#9092ARROW-10386#8549ARROW-6994#23308ARROW-12774#10320ARROW-12670#10287ARROW-16828#13484ARROW-14989#13482ARROW-16977#13514ARROW-13404#10999ARROW-16887#13601ARROW-15906#13206ARROW-15280#13171ARROW-16144#13183ARROW-16511#13105ARROW-16085#13088ARROW-16715#13555ARROW-16268#13550ARROW-16700#13518ARROW-16807#13583ARROW-16871#13517ARROW-16415#13190ARROW-14821#12154ARROW-16439#13174ARROW-16394#13118ARROW-16516#13163ARROW-16395#13627ARROW-14848#12589ARROW-16407#13196ARROW-16653#13506ARROW-14575#13160ARROW-15271#13170ARROW-16703#13650ARROW-16444#13397ARROW-15016#13541ARROW-16776#13563ARROW-15622#13090ARROW-18131#14484ARROW-18305#14581ARROW-18285#14615 * Closes: #33631 Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This PR adds support for
dplyr::unionanddplyr::union_all. Not sure why, but I find I must use the fully qualified namedplyr::unionor else will get an error.