Skip to content

ARROW-6348: [R] arrow::read_csv_arrow namespace error when package not loaded - #5223

Closed
nealrichardson wants to merge 1 commit into
apache:masterfrom
nealrichardson:read-csv-namespace
Closed

ARROW-6348: [R] arrow::read_csv_arrow namespace error when package not loaded#5223
nealrichardson wants to merge 1 commit into
apache:masterfrom
nealrichardson:read-csv-namespace

Conversation

@nealrichardson

Copy link
Copy Markdown
Member

Can't (easily) cover this with an automated test due to the way tests are executed inside the package namespace, but tests show that this doesn't break things, and I confirmed manually that the reported behavior is resolved.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #5223 into master will decrease coverage by 12.26%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #5223 +/- ##
===========================================
- Coverage 87.67% 75.41% -12.27% 
===========================================
Files 1025 57 -968 Lines 147030 3636 -143394 Branches 1437 0 -1437 ===========================================
- Hits 128915 2742 -126173 + Misses 17753 894 -16859 + Partials 362 0 -362
Impacted FilesCoverage Δ
r/R/csv.R97.22% <100%> (ø)⬆️
python/pyarrow/ipc.pxi
cpp/src/parquet/column_page.h
cpp/src/plasma/test/external_store_tests.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
rust/parquet/src/arrow/converter.rs
cpp/src/arrow/compute/compute_test.cc
cpp/src/arrow/python/io.cc
python/pyarrow/hdfs.py
... and 959 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bc63c...13ffc86. Read the comment docs.

@wesmwesm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesmwesm closed this in bcf5897Aug 29, 2019
kou pushed a commit that referenced this pull request Feb 20, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nealrichardson@codecov-io@wesm