Skip to content

ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17 - #9128

Closed
jorisvandenbossche wants to merge 5 commits into
apache:masterfrom
jorisvandenbossche:ARROW-11163
Closed

ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17#9128
jorisvandenbossche wants to merge 5 commits into
apache:masterfrom
jorisvandenbossche:ARROW-11163

Conversation

@jorisvandenbossche

Copy link
Copy Markdown
Member

(obviously still needs test, but already putting the fix I was testing locally in a draft PR)

@github-actions

Copy link
Copy Markdown

@jorisvandenbossche
jorisvandenbossche marked this pull request as draft January 7, 2021 16:08
@pitrou

Copy link
Copy Markdown
Member

+1. Perhaps the test file should be added to https://github.com/apache/arrow-testing (not sure).

@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

If it's a tiny file (can be less than 1 kB), can we then add it to the arrow repo itself? (historically, we have some files included in pyarrow/tests/data) Or do we try to avoid that entirely nowadays?
Can certainly look into adding a file to https://github.com/apache/arrow-testing as well

@pitrou

Copy link
Copy Markdown
Member

@wesm What do you think?

@nealrichardson

Copy link
Copy Markdown
Member

Would you mind adding a bullet to https://github.com/apache/arrow/blob/master/r/NEWS.md#bug-fixes since this was also reported in R (ARROW-10850)?

@nealrichardson

Copy link
Copy Markdown
Member

IMHO it's simpler to add a tiny file here than always having to worry with a git submodule. You could also defer it: @jonkeane is currently working on some backwards/forwards compat testing for parquet and feather files (#9118), so he could handle it there.

@jorisvandenbossche

Copy link
Copy Markdown
MemberAuthor

Added a tiny test, and added an R news bullet point. This should be ready then.

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @jorisvandenbossche

@jorisvandenbossche
jorisvandenbossche deleted the ARROW-11163 branch January 11, 2021 17:36
kou pushed a commit that referenced this pull request Feb 20, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jorisvandenbossche@pitrou@nealrichardson