Uh oh!
There was an error while loading. Please reload this page.
ARROW-16776: [R] dplyr::glimpse method for arrow table and datasets - #13563
Conversation
fe9867e to
2382b88Compare| #' @importFrom rlang sym := | ||
| tally.arrow_dplyr_query <- function(x, wt = NULL, sort = FALSE, name = NULL) { | ||
| check_name <- utils::getFromNamespace("check_name", "dplyr") | ||
| check_name <- getFromNamespace("check_name", "dplyr") |
There was a problem hiding this comment.
Question: Is there a reason we didn't want the utils::?
There was a problem hiding this comment.
We've elsewhere done importFrom so it's not necessary
nealrichardson
commented
Jul 11, 2022
@jthomasmock FYI |
jthomasmock
commented
Jul 11, 2022
Very excited to test this out once it's in dev, had peeked through the |
wjones127
left a comment
There was a problem hiding this comment.
This looks great. I tried to throw something a little more complex and it did well at formatting the output:
library(arrow)
library(dplyr)
tab<- arrow_table(
x=Array$create(c(1, 2, 3)),
extremely_long_name_of_a_column_here=Array$create(list(
list(data.frame(x= rep("XXXXXXXXXXXXXXXX", 100))),
list(data.frame(x= rep("YYYYYY", 100))),
list(data.frame(x= rep("ZZZZZZZZZ", 100)))
))
)
glimpse(tab)
#> Table#> 3 rows x 2 columns#> $ x <double> 1, 2, 3#> $ extremely_long_name_of_a_column_here <list<...>> [[<tbl_df[100 x 1]>]], [[<tbl…#> Call `print()` for full schema detailsCreated on 2022-07-11 by the reprex package (v2.0.1)
Uh oh!
There was an error while loading. Please reload this page.
| has_aggregation <- function(x) { | ||
| # TODO: update with joins (check right side data too) | ||
| !is.null(x$aggregations) || (is_collapsed(x) && has_aggregation(x$.data)) | ||
| query_can_stream <- function(x) { |
There was a problem hiding this comment.
The reason we can't push this down to C++ is because we haven't constructed an exec plan yet, right? Otherwise, it would be more maintainable to do so.
There was a problem hiding this comment.
I don't follow. We could build an ExecPlan, but it wouldn't tell us anything about how it would perform, would it? I'm trying to detect cases where I can just take head() of the data without having to scan an entire dataset.
There was a problem hiding this comment.
We could build an ExecPlan, but it wouldn't tell us anything about how it would perform, would it?
I'm not super close to the ExecPlan code, but I thought they were composed of a graph of nodes that could be traversed and analyzed, just like our arrow_dplyr_query structure. Am I wrong on that?
I'm trying to detect cases where I can just take head() of the data without having to scan an entire dataset.
I was just thinking that having such a method on ExecPlan would be useful in general.
There was a problem hiding this comment.
Sure, that probably would be useful
There was a problem hiding this comment.
I was just thinking that having such a method on ExecPlan would be useful in general.
Possibly. We'd probably want to define it more formally. SQL has LIMIT X and Substrait's equivalent is FetchRel. Neither of these are exactly what is being detected here. For example, it is legal to have SELECT SUM(x) FROM table LIMIT 1 but it wouldn't actually limit any data being read.
We could define it as "single pipeline queries" but a pipeline breaker doesn't necessarily mean a query is non-streaming (for example, hash-join is sometimes permitted as "streaming" in this example but it is always a pipeline breaker).
There was a problem hiding this comment.
Since you mentioned limit, I'll make a plug for ARROW-16628. Not relevant for this particular question, just would let me delete some R specific handling outside of the ExecPlan, and I'm guessing we'll have to do it to support substrait.
Co-authored-by: Will Jones <willjones127@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…Hub issue numbers (#34260) Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature. Issue numbers have been rewritten based on the following correspondence. Also, the pkgdown settings have been changed and updated to link to GitHub. I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly. --- ARROW-6338#5198ARROW-6364#5201ARROW-6323#5169ARROW-6278#5141ARROW-6360#5329ARROW-6533#5450ARROW-6348#5223ARROW-6337#5399ARROW-10850#9128ARROW-10624#9092ARROW-10386#8549ARROW-6994#23308ARROW-12774#10320ARROW-12670#10287ARROW-16828#13484ARROW-14989#13482ARROW-16977#13514ARROW-13404#10999ARROW-16887#13601ARROW-15906#13206ARROW-15280#13171ARROW-16144#13183ARROW-16511#13105ARROW-16085#13088ARROW-16715#13555ARROW-16268#13550ARROW-16700#13518ARROW-16807#13583ARROW-16871#13517ARROW-16415#13190ARROW-14821#12154ARROW-16439#13174ARROW-16394#13118ARROW-16516#13163ARROW-16395#13627ARROW-14848#12589ARROW-16407#13196ARROW-16653#13506ARROW-14575#13160ARROW-15271#13170ARROW-16703#13650ARROW-16444#13397ARROW-15016#13541ARROW-16776#13563ARROW-15622#13090ARROW-18131#14484ARROW-18305#14581ARROW-18285#14615 * Closes: #33631 Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
See reprex (sans terminal formatting) in r/tests/testthat/_snaps/dplyr-glimpse.md
Not all queries can be glimpse()d: some would require evaluating the whole query, which may be expensive (and can't be interrupted yet, see ARROW-11841).
Note that the existing
print()methods aren't affected by this. There is still the idea that the print methods for Table/RecordBatch should print some data (ARROW-16777 and others), but that should probably be column-oriented instead of row-oriented like glimpse().