Skip to content

ARROW-16395: [R] Implement lubridate's parsers with year, month, and day, hour, minute, and second components - #13627

Merged
paleolimbot merged 3 commits into
apache:masterfrom
rok:ARROW-16395
Jul 22, 2022
Merged

ARROW-16395: [R] Implement lubridate's parsers with year, month, and day, hour, minute, and second components#13627
paleolimbot merged 3 commits into
apache:masterfrom
rok:ARROW-16395

Conversation

@rok

@rokrok commented Jul 16, 2022

Copy link
Copy Markdown
Member

This is to resolve ARROW-16395.

@github-actions

github-actionsBot commented Jul 16, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16395

@rok
rokforce-pushed the ARROW-16395 branch 3 times, most recently from 9bd8f11 to 2d68cdfCompareJuly 19, 2022 11:02
@rok
rok marked this pull request as ready for review July 19, 2022 16:45
@rok

rok commented Jul 19, 2022

Copy link
Copy Markdown
MemberAuthor

@dragosmg is this missing something obvious?

@rok
rok requested a review from paleolimbotJuly 19, 2022 16:45
dragosmg
dragosmg reviewed Jul 19, 2022
View reviewed changes

@dragosmgdragosmg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Many thanks. Just a couple of thoughts.

Comment threadr/R/dplyr-funcs-datetime.R Outdated
Comment threadr/tests/testthat/test-dplyr-funcs-datetime.R Outdated
@rok
rokforce-pushed the ARROW-16395 branch 2 times, most recently from a4e5059 to e6f0eadCompareJuly 20, 2022 14:50
dragosmg
dragosmg approved these changes Jul 20, 2022
View reviewed changes

@dragosmgdragosmg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rok
rok requested a review from jonkeaneJuly 20, 2022 16:22
@rok
rok requested a review from nealrichardsonJuly 20, 2022 19:10
@rok

rok commented Jul 21, 2022

Copy link
Copy Markdown
MemberAuthor

@nealrichardson do you think we could get this into the release?

@dragosmgdragosmg mentioned this pull request Jul 22, 2022
Merged
paleolimbot
paleolimbot approved these changes Jul 22, 2022
View reviewed changes

@paleolimbotpaleolimbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a local checkout and stepped through these. Looks great!

@paleolimbot
paleolimbot merged commit 3c7a0ca into apache:masterJul 22, 2022
@rok

rok commented Jul 22, 2022

Copy link
Copy Markdown
MemberAuthor

Thanks for reviews and merge @dragosmg & @paleolimbot !

@ursabot

ursabot commented Jul 24, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 9442e1c and contender = 3c7a0ca. 3c7a0ca is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.21% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.11% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] 3c7a0cad ec2-t3-xlarge-us-east-2
[Failed] 3c7a0cad test-mac-arm
[Failed] 3c7a0cad ursa-i9-9960x
[Finished] 3c7a0cad ursa-thinkcentre-m75q
[Failed] 9442e1ce ec2-t3-xlarge-us-east-2
[Failed] 9442e1ce test-mac-arm
[Failed] 9442e1ce ursa-i9-9960x
[Finished] 9442e1ce ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@asfimportasfimport mentioned this pull request Jul 24, 2022
Closed
@eitsupieitsupi mentioned this pull request Feb 19, 2023
Merged
kou pushed a commit that referenced this pull request Feb 20, 2023
@eitsupi
GH-33631: [R] Rewrite Jira ticket numbers in pkgdown documents to Git…
be40d9f
…Hub issue numbers (#34260)
Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.
Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.
I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.
---
ARROW-6338#5198ARROW-6364#5201ARROW-6323#5169ARROW-6278#5141ARROW-6360#5329ARROW-6533#5450ARROW-6348#5223ARROW-6337#5399ARROW-10850#9128ARROW-10624#9092ARROW-10386#8549ARROW-6994#23308ARROW-12774#10320ARROW-12670#10287ARROW-16828#13484ARROW-14989#13482ARROW-16977#13514ARROW-13404#10999ARROW-16887#13601ARROW-15906#13206ARROW-15280#13171ARROW-16144#13183ARROW-16511#13105ARROW-16085#13088ARROW-16715#13555ARROW-16268#13550ARROW-16700#13518ARROW-16807#13583ARROW-16871#13517ARROW-16415#13190ARROW-14821#12154ARROW-16439#13174ARROW-16394#13118ARROW-16516#13163ARROW-16395#13627ARROW-14848#12589ARROW-16407#13196ARROW-16653#13506ARROW-14575#13160ARROW-15271#13170ARROW-16703#13650ARROW-16444#13397ARROW-15016#13541ARROW-16776#13563ARROW-15622#13090ARROW-18131#14484ARROW-18305#14581ARROW-18285#14615
* Closes: #33631
Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This was referenced Jul 20, 2022
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paleolimbotpaleolimbotpaleolimbot approved these changes
@jonkeanejonkeaneAwaiting requested review from jonkeane
@nealrichardsonnealrichardsonAwaiting requested review from nealrichardson
+1 more reviewer
@dragosmgdragosmgdragosmg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rok@ursabot@paleolimbot@dragosmg