Skip to content

ARROW-18131: [R] Correctly handle .data pronoun in group_by() - #14484

Merged
thisisnic merged 1 commit into
apache:masterfrom
thisisnic:ARROW-18131_data_pronoun
Oct 24, 2022
Merged

ARROW-18131: [R] Correctly handle .data pronoun in group_by()#14484
thisisnic merged 1 commit into
apache:masterfrom
thisisnic:ARROW-18131_data_pronoun

Conversation

@thisisnic

@thisisnicthisisnic commented Oct 24, 2022

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actionsBot commented Oct 24, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-18131

paleolimbot
paleolimbot approved these changes Oct 24, 2022
View reviewed changes

@paleolimbotpaleolimbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I ran revdeps with this branch and confirmed that it fixes the check.

@thisisnic
thisisnic merged commit eb01350 into apache:masterOct 24, 2022
nealrichardson pushed a commit to nealrichardson/arrow that referenced this pull request Oct 24, 2022
@thisisnic@nealrichardson
ARROW-18131: [R] Correctly handle .data pronoun in group_by() (apache…
022c44c
…#14484)
Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@ursabot

ursabot commented Oct 27, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 33f2c0e and contender = eb01350. eb01350 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] eb01350b ec2-t3-xlarge-us-east-2
[Failed] eb01350b test-mac-arm
[Finished] eb01350b ursa-i9-9960x
[Failed] eb01350b ursa-thinkcentre-m75q
[Failed] 33f2c0ec ec2-t3-xlarge-us-east-2
[Failed] 33f2c0ec test-mac-arm
[Finished] 33f2c0ec ursa-i9-9960x
[Failed] 33f2c0ec ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

kou pushed a commit that referenced this pull request Nov 15, 2022
@thisisnic@kou
ARROW-18131: [R] Correctly handle .data pronoun in group_by() (#14484)
9608485
Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@eitsupieitsupi mentioned this pull request Feb 19, 2023
Merged
kou pushed a commit that referenced this pull request Feb 20, 2023
@eitsupi
GH-33631: [R] Rewrite Jira ticket numbers in pkgdown documents to Git…
be40d9f
…Hub issue numbers (#34260)
Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.
Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.
I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.
---
ARROW-6338#5198ARROW-6364#5201ARROW-6323#5169ARROW-6278#5141ARROW-6360#5329ARROW-6533#5450ARROW-6348#5223ARROW-6337#5399ARROW-10850#9128ARROW-10624#9092ARROW-10386#8549ARROW-6994#23308ARROW-12774#10320ARROW-12670#10287ARROW-16828#13484ARROW-14989#13482ARROW-16977#13514ARROW-13404#10999ARROW-16887#13601ARROW-15906#13206ARROW-15280#13171ARROW-16144#13183ARROW-16511#13105ARROW-16085#13088ARROW-16715#13555ARROW-16268#13550ARROW-16700#13518ARROW-16807#13583ARROW-16871#13517ARROW-16415#13190ARROW-14821#12154ARROW-16439#13174ARROW-16394#13118ARROW-16516#13163ARROW-16395#13627ARROW-14848#12589ARROW-16407#13196ARROW-16653#13506ARROW-14575#13160ARROW-15271#13170ARROW-16703#13650ARROW-16444#13397ARROW-15016#13541ARROW-16776#13563ARROW-15622#13090ARROW-18131#14484ARROW-18305#14581ARROW-18285#14615
* Closes: #33631
Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paleolimbotpaleolimbotpaleolimbot approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thisisnic@ursabot@paleolimbot