Uh oh!
There was an error while loading. Please reload this page.
ARROW-16700: [C++][R][Datasets] aggregates on partitioning columns - #13518
Conversation
westonpace
left a comment
There was a problem hiding this comment.
This looks good. One suggestion for the test.
Uh oh!
There was an error while loading. Please reload this page.
706f409 to
6592ad2Comparedrin
commented
Jul 14, 2022
rebased branch |
The major part of this commit is to add columns to ExecBatches from the guarantees vector instead of taking a lambda. The lambda can be repetitive and a source of error. This still only adds the guarantees to ExecBatches and not the Dataset
whitespace for test data was demolished by clang-format, this just restores the whitespace that made it human readable
drin
commented
Jul 15, 2022
I confirmed that the C++ unit tests validate the fix provided in this PR. Still working on an R test that correctly validates the fix. arrow/cpp/src/arrow/dataset/scanner.cc Lines 911 to 916 in 6592ad2 |
westonpace
commented
Jul 18, 2022
I'm sorry but I believe I have sent you on a wild goose chase. I had suggested an R test but, upon re-reading the JIRA, realize that I had forgotten this is not reproducible from R (because it always inserts a project node prior to an aggregate node) and so no R test is needed. |
westonpace
left a comment
There was a problem hiding this comment.
A few minor suggestions on the unit test and I think this is good to go.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
minor style change Co-authored-by: Weston Pace <weston.pace@gmail.com>
changing use of ARROW_WARN_NOT_OK A more appropriate macro was suggested, EXPECT_OK_AND_ASSIGN Co-authored-by: Weston Pace <weston.pace@gmail.com>
changed variable name and method invocation because EXPECT_OK_AND_ASSIGN unwraps the result whereas ARROW_RETURN_NOT_OK did not
westonpace
left a comment
There was a problem hiding this comment.
Thanks both of you for taking care of this.
Uh oh!
There was an error while loading. Please reload this page.
ursabot
commented
Jul 23, 2022
Benchmark runs are scheduled for baseline = b3ce0fa and contender = e0ccfa1. e0ccfa1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…Hub issue numbers (#34260) Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature. Issue numbers have been rewritten based on the following correspondence. Also, the pkgdown settings have been changed and updated to link to GitHub. I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly. --- ARROW-6338#5198ARROW-6364#5201ARROW-6323#5169ARROW-6278#5141ARROW-6360#5329ARROW-6533#5450ARROW-6348#5223ARROW-6337#5399ARROW-10850#9128ARROW-10624#9092ARROW-10386#8549ARROW-6994#23308ARROW-12774#10320ARROW-12670#10287ARROW-16828#13484ARROW-14989#13482ARROW-16977#13514ARROW-13404#10999ARROW-16887#13601ARROW-15906#13206ARROW-15280#13171ARROW-16144#13183ARROW-16511#13105ARROW-16085#13088ARROW-16715#13555ARROW-16268#13550ARROW-16700#13518ARROW-16807#13583ARROW-16871#13517ARROW-16415#13190ARROW-14821#12154ARROW-16439#13174ARROW-16394#13118ARROW-16516#13163ARROW-16395#13627ARROW-14848#12589ARROW-16407#13196ARROW-16653#13506ARROW-14575#13160ARROW-15271#13170ARROW-16703#13650ARROW-16444#13397ARROW-15016#13541ARROW-16776#13563ARROW-15622#13090ARROW-18131#14484ARROW-18305#14581ARROW-18285#14615 * Closes: #33631 Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This updates the Scanner node such that it will use the guarantee expression to fill out columns missing from the dataset but guaranteed to be some constant with appropriate scalars, rather than just inserting a null placeholder column. In case both are available, the dataset constructor prefers using the scalar from the guarantee expression over the actual data, since the latter would probably be an array that unnecessarily repeats the constant value.
This is the other part of what was uncovered while analyzing ARROW-16700, the more direct cause being a duplicate of ARROW-16904 (see also #13509 for my fix for that).