Uh oh!
There was an error while loading. Please reload this page.
ARROW-10624: [R] Proactively remove "problems" attributes - #9092
ARROW-10624: [R] Proactively remove "problems" attributes#9092jonkeane wants to merge 2 commits into
Conversation
nealrichardson
left a comment
There was a problem hiding this comment.
Please update the JIRA title to match this title (or amend both so they're the same). Also add a bugfix news bullet, let's try to keep up this week :)
| if ("attributes" %in% names(x) && | ||
| "problems" %in% names(x[["attributes"]]) ) { | ||
| x[["attributes"]][["problems"]] <- NULL | ||
| } | ||
There was a problem hiding this comment.
I believe you can safely just
| if ("attributes"%in% names(x) && | |
| "problems"%in% names(x[["attributes"]]) ) { | |
| x[["attributes"]][["problems"]] <-NULL | |
| } | |
| x[["attributes"]][["problems"]] <-NULL |
> x <- list()
> x
list()
> x$attributes$problems <- NULL
> x
list()
> x[["attributes"]][["problems"]] <- NULL
> x
list()
There was a problem hiding this comment.
it turns out just NULLing doesn’t quite work with the tests for garbage metadata ("garbage"[["attributes"]][["problems"]] <- NULL errors. I can either test that the attributes are a list before this or alter our garbage tests to send in a list.
There was a problem hiding this comment.
Should we validate/assert is.list() in this function?
There was a problem hiding this comment.
Yeah I can do that. Though one of the existing tests fails here — the one right above it works which might be sufficient, is there something that lines 76-81 is testing that we aren't covering with lines 70-75?
There was a problem hiding this comment.
I would have to look into the implementation to be sure, but I think the intent of the first test should be that we don't save garbage r metadata and the second would be that, if someone happened to have bad metadata stored in the r key (we can't prevent some other data generating process from doing that), that we don't crash on loading it. It's not clear that that's actually what those tests are doing, but that's what I think they should do.
There was a problem hiding this comment.
Ok, cool — I'll rewrite the second test to avoid using .serialize_arrow_r_metadata() so that we don't error there, but still keep the testing-serialized-data aspect of that test.
jonkeane
commented
Jan 4, 2021
Updated, passing actions on my fork: |
…Hub issue numbers (#34260) Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature. Issue numbers have been rewritten based on the following correspondence. Also, the pkgdown settings have been changed and updated to link to GitHub. I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly. --- ARROW-6338#5198ARROW-6364#5201ARROW-6323#5169ARROW-6278#5141ARROW-6360#5329ARROW-6533#5450ARROW-6348#5223ARROW-6337#5399ARROW-10850#9128ARROW-10624#9092ARROW-10386#8549ARROW-6994#23308ARROW-12774#10320ARROW-12670#10287ARROW-16828#13484ARROW-14989#13482ARROW-16977#13514ARROW-13404#10999ARROW-16887#13601ARROW-15906#13206ARROW-15280#13171ARROW-16144#13183ARROW-16511#13105ARROW-16085#13088ARROW-16715#13555ARROW-16268#13550ARROW-16700#13518ARROW-16807#13583ARROW-16871#13517ARROW-16415#13190ARROW-14821#12154ARROW-16439#13174ARROW-16394#13118ARROW-16516#13163ARROW-16395#13627ARROW-14848#12589ARROW-16407#13196ARROW-16653#13506ARROW-14575#13160ARROW-15271#13170ARROW-16703#13650ARROW-16444#13397ARROW-15016#13541ARROW-16776#13563ARROW-15622#13090ARROW-18131#14484ARROW-18305#14581ARROW-18285#14615 * Closes: #33631 Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
No description provided.