Uh oh!
There was an error while loading. Please reload this page.
ARROW-16871: [R] Implement exp() and sqrt() in Arrow dplyr queries - #13517
Merged
Conversation
implement sqrt and exp dplyr bindings
nealrichardson
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this! One note but this looks like the right approach to me.
Uh oh!
There was an error while loading. Please reload this page.
remove `...` from function signatures
clean up code to address trailing whitespace warnings generated by `lintr`
nealrichardson
approved these changes
Jul 5, 2022
drin pushed a commit
to drin/arrow
that referenced
this pull request
Jul 5, 2022
…pache#13517) In response to https://issues.apache.org/jira/browse/ARROW-16871 - implement `sqrt` and `exp` bindings for `dplyr` - change `sqrt` in `arrow-datum.R` to use `sqrt_checked` rather than `power_checked` - write tests for `sqrt` and `exp` Authored-by: Christopher D. Higgins <40569964+higgicd@users.noreply.github.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
kou pushed a commit
that referenced
this pull request
Feb 20, 2023
…Hub issue numbers (#34260) Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature. Issue numbers have been rewritten based on the following correspondence. Also, the pkgdown settings have been changed and updated to link to GitHub. I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly. --- ARROW-6338#5198ARROW-6364#5201ARROW-6323#5169ARROW-6278#5141ARROW-6360#5329ARROW-6533#5450ARROW-6348#5223ARROW-6337#5399ARROW-10850#9128ARROW-10624#9092ARROW-10386#8549ARROW-6994#23308ARROW-12774#10320ARROW-12670#10287ARROW-16828#13484ARROW-14989#13482ARROW-16977#13514ARROW-13404#10999ARROW-16887#13601ARROW-15906#13206ARROW-15280#13171ARROW-16144#13183ARROW-16511#13105ARROW-16085#13088ARROW-16715#13555ARROW-16268#13550ARROW-16700#13518ARROW-16807#13583ARROW-16871#13517ARROW-16415#13190ARROW-14821#12154ARROW-16439#13174ARROW-16394#13118ARROW-16516#13163ARROW-16395#13627ARROW-14848#12589ARROW-16407#13196ARROW-16653#13506ARROW-14575#13160ARROW-15271#13170ARROW-16703#13650ARROW-16444#13397ARROW-15016#13541ARROW-16776#13563ARROW-15622#13090ARROW-18131#14484ARROW-18305#14581ARROW-18285#14615 * Closes: #33631 Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to https://issues.apache.org/jira/browse/ARROW-16871
sqrtandexpbindings fordplyrsqrtinarrow-datum.Rto usesqrt_checkedrather thanpower_checkedsqrtandexp