Skip to content

ARROW-16715: [R] Bump default parquet version - #13555

Merged
nealrichardson merged 4 commits into
apache:masterfrom
nealrichardson:r-upgrade-parquet
Jul 11, 2022
Merged

ARROW-16715: [R] Bump default parquet version#13555
nealrichardson merged 4 commits into
apache:masterfrom
nealrichardson:r-upgrade-parquet

Conversation

@nealrichardson

@nealrichardsonnealrichardson commented Jul 8, 2022

Copy link
Copy Markdown
Member

Also removes deprecated args to write_parquet()

@github-actions

github-actionsBot commented Jul 8, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16715

@github-actions

github-actionsBot commented Jul 8, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@nealrichardson

nealrichardson commented Jul 8, 2022

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-arrow-backwards-compatibility

@github-actions

github-actionsBot commented Jul 8, 2022

Copy link
Copy Markdown

Revision: f375949

Submitted crossbow builds: ursacomputing/crossbow @ actions-49cb752519

TaskStatus
test-r-arrow-backwards-compatibilityGithub Actions

paleolimbot
paleolimbot approved these changes Jul 8, 2022
View reviewed changes

@paleolimbotpaleolimbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few lintr errors (I think I found them all + suggested the fix) but this looks good to me (The first CI failure appears to be the Array-subset-on-boolean error).

Comment threadr/tests/testthat/test-parquet.R Outdated
Comment threadr/tests/testthat/test-parquet.R Outdated
Comment threadr/tests/testthat/test-parquet.R Outdated
@nealrichardson@paleolimbot
s/'/"/g
1776407
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
@nealrichardson

nealrichardson commented Jul 8, 2022

Copy link
Copy Markdown
MemberAuthor

@jonkeane do you want to take a look at this? I seem to recall you set up the backwards compat testing.

jonkeane
jonkeane approved these changes Jul 11, 2022
View reviewed changes

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm a little bit surprised that the backwards compatibility all the way back still is fine, but we must not test any types that have differed since the 2.0 version.

Comment threadr/tests/testthat/test-parquet.R
expect_equal(make_valid_version(2.0), ParquetVersionType$PARQUET_2_0)
test_that("make_valid_parquet_version() input validation", {
expect_error(
make_valid_parquet_version("0.3.14"),

@jonkeanejonkeaneJul 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥧

@nealrichardson

nealrichardson commented Jul 11, 2022

Copy link
Copy Markdown
MemberAuthor

This looks good to me. I'm a little bit surprised that the backwards compatibility all the way back still is fine, but we must not test any types that have differed since the 2.0 version.

It may also be that the library can read whatever version file it receives (at least as far back as we test)

@nealrichardson
nealrichardson merged commit f0ff8d0 into apache:masterJul 11, 2022
@nealrichardson
nealrichardson deleted the r-upgrade-parquet branch July 11, 2022 15:26
@eitsupieitsupi mentioned this pull request Feb 19, 2023
Merged
kou pushed a commit that referenced this pull request Feb 20, 2023
@eitsupi
GH-33631: [R] Rewrite Jira ticket numbers in pkgdown documents to Git…
be40d9f
…Hub issue numbers (#34260)
Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.
Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.
I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.
---
ARROW-6338#5198ARROW-6364#5201ARROW-6323#5169ARROW-6278#5141ARROW-6360#5329ARROW-6533#5450ARROW-6348#5223ARROW-6337#5399ARROW-10850#9128ARROW-10624#9092ARROW-10386#8549ARROW-6994#23308ARROW-12774#10320ARROW-12670#10287ARROW-16828#13484ARROW-14989#13482ARROW-16977#13514ARROW-13404#10999ARROW-16887#13601ARROW-15906#13206ARROW-15280#13171ARROW-16144#13183ARROW-16511#13105ARROW-16085#13088ARROW-16715#13555ARROW-16268#13550ARROW-16700#13518ARROW-16807#13583ARROW-16871#13517ARROW-16415#13190ARROW-14821#12154ARROW-16439#13174ARROW-16394#13118ARROW-16516#13163ARROW-16395#13627ARROW-14848#12589ARROW-16407#13196ARROW-16653#13506ARROW-14575#13160ARROW-15271#13170ARROW-16703#13650ARROW-16444#13397ARROW-15016#13541ARROW-16776#13563ARROW-15622#13090ARROW-18131#14484ARROW-18305#14581ARROW-18285#14615
* Closes: #33631
Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonkeanejonkeanejonkeane approved these changes
@paleolimbotpaleolimbotpaleolimbot approved these changes

Assignees

No one assigned

Labels

Component: DocumentationComponent: ParquetComponent: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nealrichardson@jonkeane@paleolimbot