Skip to content

ARROW-6323: [R] Expand file paths when passing to readers - #5169

Closed
nealrichardson wants to merge 4 commits into
apache:masterfrom
nealrichardson:path-real
Closed

ARROW-6323: [R] Expand file paths when passing to readers#5169
nealrichardson wants to merge 4 commits into
apache:masterfrom
nealrichardson:path-real

Conversation

@nealrichardson

Copy link
Copy Markdown
Member

Note that there is no test in the test suite that asserts that ~ is expanded correctly because we can only write to tempfiles in the tests, but It Works on My Machine ™️ .

cc @romainfrancois

@nealrichardson

Copy link
Copy Markdown
MemberAuthor

Debugging the windows build failure, stand by

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #5169 into master will decrease coverage by 12.41%.
The diff coverage is 83.33%.

Impacted file tree graph

@@ Coverage Diff @@## master #5169 +/- ##
===========================================
- Coverage 87.63% 75.22% -12.42% 
===========================================
Files 1022 57 -965 Lines 146258 3604 -142654 Branches 1437 0 -1437 ===========================================
- Hits 128174 2711 -125463 + Misses 17722 893 -16829 + Partials 362 0 -362
Impacted FilesCoverage Δ
r/R/feather.R63.41% <ø> (-1.71%)⬇️
r/R/csv.R97.22% <ø> (-0.15%)⬇️
r/R/RecordBatchWriter.R72.22% <ø> (+2.22%)⬆️
r/R/json.R90% <ø> (-1.31%)⬇️
r/R/read_table.R100% <ø> (ø)⬆️
r/R/write_arrow.R96.42% <ø> (-0.13%)⬇️
r/R/compression.R90.9% <ø> (-1.4%)⬇️
r/R/RecordBatchReader.R70.58% <ø> (-1.64%)⬇️
r/R/parquet.R73.07% <100%> (ø)⬆️
r/R/io.R74.28% <75%> (ø)⬆️
... and 965 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9236d...635d954. Read the comment docs.

@fsaintjacques

Copy link
Copy Markdown
Contributor

Is it expected from R libraries to expand path? If so, I have no objection to merge this.

@nealrichardson

Copy link
Copy Markdown
MemberAuthor

Yes:

> write.csv(iris, file="~/Downloads/iris.csv")
> read.csv("~/Downloads/iris.csv")
XSepal.LengthSepal.WidthPetal.LengthPetal.WidthSpecies115.13.51.40.2setosa224.93.01.40.2setosa334.73.21.30.2setosa444.63.11.50.2setosa555.03.61.40.2setosa665.43.91.70.4setosa...

kou pushed a commit that referenced this pull request Feb 20, 2023
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.22%. Comparing base (3c9236d) to head (635d954).

Files with missing linesPatch %Lines
r/R/io.R75.00%1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3c9236d) and HEAD (635d954). Click for more details.

HEAD has 5 uploads less than BASE
FlagBASE (3c9236d)HEAD (635d954)
61
Additional details and impacted files
@@ Coverage Diff @@## master #5169 +/- ##
===========================================
- Coverage 87.63% 75.22% -12.42% 
===========================================
Files 1022 57 -965 Lines 146258 3604 -142654 Branches 1437 0 -1437 ===========================================
- Hits 128174 2711 -125463 + Misses 17722 893 -16829 + Partials 362 0 -362 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nealrichardson@codecov-io@fsaintjacques@codecov-commenter