Skip to content

ARROW-18305: [R] Fix for dev purrr - #14581

Merged
nealrichardson merged 1 commit into
apache:masterfrom
hadley:dev-purrr
Nov 3, 2022
Merged

ARROW-18305: [R] Fix for dev purrr#14581
nealrichardson merged 1 commit into
apache:masterfrom
hadley:dev-purrr

Conversation

@hadley

Copy link
Copy Markdown
Contributor

The recycling rules in map2() are now stricter, so we need to check that x actually has columns before applying the metadata.

I also mildly refactored the test to make it easier to run in isolation; I'm happy to revert those changes if desired.

The recycling rules in map2() are now stricter, so we need to check that `x` actually has columns before applying the metadata.
I also mildly refactored the test to make it easier to run in isolation; I'm happy to revert those changes if desired.
@nealrichardsonnealrichardson changed the title Fix for dev purrrMINOR: [R] Fix for dev purrrNov 3, 2022
@hadleyhadley mentioned this pull request Nov 3, 2022
45 tasks

@nealrichardsonnealrichardson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nealrichardson
nealrichardson merged commit 04917f9 into apache:masterNov 3, 2022
@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 8074496 and contender = 04917f9. 04917f9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.91% ⬆️1.68%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.14% ⬆️0.11%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 04917f94 ec2-t3-xlarge-us-east-2
[Finished] 04917f94 test-mac-arm
[Finished] 04917f94 ursa-i9-9960x
[Finished] 04917f94 ursa-thinkcentre-m75q
[Finished] 8074496c ec2-t3-xlarge-us-east-2
[Finished] 8074496c test-mac-arm
[Finished] 8074496c ursa-i9-9960x
[Finished] 8074496c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

@nealrichardsonnealrichardson changed the title MINOR: [R] Fix for dev purrrARROW-18305: [R] Fix for dev purrrNov 10, 2022
@github-actions

Copy link
Copy Markdown

kou pushed a commit that referenced this pull request Nov 15, 2022
The recycling rules in map2() are now stricter, so we need to check that `x` actually has columns before applying the metadata.
I also mildly refactored the test to make it easier to run in isolation; I'm happy to revert those changes if desired.
Authored-by: Hadley Wickham <h.wickham@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
kou pushed a commit that referenced this pull request Feb 20, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hadley@ursabot@nealrichardson