refactor: remove sprite-env usage from bot scripts - #1
Closed
AhmedTMM wants to merge 138 commits into
Closed
Conversation
…es (OpenRouterLabs#968) Improve error messages in shared utilities and cloud providers that previously showed bare "Failed to..." messages without telling users how to fix the problem. Shared (shared/common.sh): - generate_ssh_key_if_missing: handle ssh-keygen/mkdir failures with disk space and permission guidance - get_ssh_fingerprint: detect missing/corrupt public key files with regeneration instructions - generic_ssh_wait: structured "How to fix" with manual SSH test command and firewall check - _report_api_failure: add DNS/firewall/proxy guidance for network errors - ensure_jq: platform-specific install commands for unknown package managers, hash rehash hint after install - get_openrouter_api_key_manual: structured guidance after 3 failed attempts Cloud providers: - Contabo: actionable guidance for OAuth token failures - Exoscale: guidance for credential validation and CLI download failures - Netcup: network connectivity hint for API connection failure - Scaleway: structured guidance for project ID lookup failure Agent: ux-engineer Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Runs `bash test/mock.sh` on every pull request targeting main. Includes concurrency grouping to cancel stale runs and a 10-minute timeout. Results are posted to the GitHub Actions step summary. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…abs#978) Cover 8 functions that had zero test coverage: - log_install_failed: actionable guidance for agent install failures (added across 126 scripts) - ensure_jq: cross-platform jq installation - get_cloud_init_userdata: cloud-init template structure and content - _multi_creds_validate: credential validation with env var cleanup on failure - check_python_available: dependency check with install guidance - calculate_retry_backoff: exponential backoff with jitter bounds - verify_agent_installed: agent command verification with diagnostic output - _log_diagnostic: structured error reporting with causes and fixes - _generate_csrf_state: CSRF token generation with multiple backends - register_cleanup_trap / track_temp_file / cleanup_temp_files: temp file lifecycle Agent: test-engineer Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
…RouterLabs#974) Add startup validation for the TARGET_SCRIPT env var to prevent arbitrary script execution. The validation: - Requires .sh extension - Checks the file exists - Resolves symlinks and relative paths via realpathSync - Verifies the real path is inside the allowed skill directory FixesOpenRouterLabs#970 Agent: security-auditor Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…l clouds (OpenRouterLabs#975) The `spawn <agent>` quick start section was only showing the first auth env var when the best available cloud requires multiple credentials (e.g., UpCloud with UPCLOUD_USERNAME + UPCLOUD_PASSWORD). This left users confused about what other credentials they needed. Now iterates over all auth vars, consistent with `spawn <cloud>` info. Agent: ux-engineer Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…rLabs#981) The QA cycle was auto-merging stale QA PRs that were mergeable. Now it only closes stale ones — merging is left for human review. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…s#985) * fix: strip ANSI colors before grepping test summary The mock test output uses ANSI escape codes for colored ✓/✗/━━━ characters, so the grep in the Post summary step couldn't match them. Strip colors with sed first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: use NO_COLOR standard instead of sed to strip ANSI codes mock.sh now respects the NO_COLOR env var (https://no-color.org/). CI sets NO_COLOR=1 so grep matches ✓/✗/━━━ cleanly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…uterLabs#983) - Add interactive confirmation prompt before clearing spawn history (spawn list --clear) to prevent accidental data loss - Show total prompt length in dry-run preview when prompt exceeds 100 characters, so users can verify the correct prompt was loaded - Add "Rerun previous" suggestion to non-interactive terminal fallback - Show "(shown first)" hint when clouds with credentials are detected in interactive picker, so users understand the sort order - Add repository URL to spawn version output for discoverability Agent: ux-engineer Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
… JSON sanitization (OpenRouterLabs#984) - Validate SPAWN_HOME is an absolute path, reject relative paths to prevent unintended file writes (addresses OpenRouterLabs#980) - Resolve SPAWN_HOME to canonical form to collapse .. segments - Strip __proto__, constructor, and prototype keys from parsed manifest JSON to prevent prototype pollution (addresses OpenRouterLabs#979) - Apply sanitization to all manifest ingestion paths (GitHub fetch, disk cache, local dev manifest) - Add 12 tests covering path validation and JSON sanitization Agent: security-auditor Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…RouterLabs#987) The bot was under-updating test/mock.sh when adding new clouds because the prompt only mentioned URL stripping. Now lists all 4 required mock.sh functions and all 5 required record.sh functions explicitly. Also adds a "Mock Test Infrastructure" reference table to CLAUDE.md so both human contributors and bots know exactly what to update. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…penRouterLabs#986) When a cloud's fixture recording fails 3+ consecutive QA cycles, the system now auto-creates a GitHub issue flagging the persistent failure. This catches stale API keys, changed endpoints, and other silent regressions that would otherwise go unnoticed. - Persistent tracker at .docs/qa-record-failures.json (git-ignored) - Counter increments on failure, resets on success - Deduplicates: skips issue creation if one already exists for that cloud Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Both mock.sh and record.sh now run each cloud's tests/recordings concurrently as background jobs instead of sequentially. Results are aggregated after all clouds finish. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…ocused helpers (OpenRouterLabs#976) Extract printAgentQuickStart from cmdAgentInfo (63 -> 43 lines), paralleling the existing printCloudQuickStart pattern. Extract _poll_instance_once and _report_instance_timeout from generic_wait_for_instance (52 -> 20 lines), eliminating duplicated elapsed/sleep/increment code in the polling loop. Agent: complexity-hunter Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
…pets (OpenRouterLabs#988) Previously, Phase 3 fix agents only got the last 10 lines grepped from the log file per failing script. This was often insufficient to diagnose the root cause. Now runs `bash test/mock.sh {cloud}` per failing cloud and feeds the complete output to the fix agent. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…penRouterLabs#994) Extract platform-specific install logic from monolithic installer functions into small, focused helpers. Both functions had nested OS/package-manager cascades (depth 3-4) that made the control flow hard to follow. ensure_jq (shared/common.sh): - Extract _install_jq_brew, _install_jq_apt, _install_jq_dnf, _install_jq_apk - Extract _report_jq_not_found for the fallthrough error message - Main function becomes a clean dispatcher + verification ensure_gh_cli + _install_gh_binary (shared/github-auth.sh): - Extract _install_gh_brew, _install_gh_apt, _install_gh_dnf - Extract _detect_gh_platform, _fetch_gh_latest_version, _download_and_install_gh - _install_gh_binary drops from 71 to 12 lines as a clean orchestrator - ensure_gh_cli drops from 57 to 29 lines No behavior changes. All tests pass, bash -n passes. Agent: complexity-hunter Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…cross 10 clouds (OpenRouterLabs#993) Replace fragile blocklist validation and printf '%q' escaping in upload_file() with strict allowlist regex [a-zA-Z0-9/_.~-]+ across all non-SSH cloud providers. For codesandbox, additionally migrate from shell command interpolation to SDK filesystem API via environment variables, eliminating the injection surface entirely. Affected clouds: codesandbox, daytona, e2b, fly, koyeb, modal, northflank, railway, render, sprite FixesOpenRouterLabs#989 Agent: security-auditor Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…manifest (OpenRouterLabs#995) Validates that test/mock.sh and test/record.sh stay in sync with manifest.json. When a new cloud provider is added, CLAUDE.md mandates updating both files with endpoint mappings, auth env vars, and API dispatchers. These tests catch configuration drift automatically: - ALL_RECORDABLE_CLOUDS completeness and no duplicates - get_endpoints(), get_auth_env_var(), call_api() coverage parity - _strip_api_base() URL patterns match fixture directories - Fixture directories have required _env.sh and _metadata.json - Auth env vars in record.sh match manifest auth fields - Shell script conventions (shebang, set -eo pipefail, no echo -e) - Test infrastructure conventions (NO_COLOR, cleanup traps, counters) Agent: test-engineer Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…RouterLabs#996) SLACK_WEBHOOK was embedded directly in heredocs at three locations, allowing potential command injection if the env var contained shell metacharacters. Added early validation requiring the URL to match the expected Slack webhook format (https://hooks.slack.com/...). Also stopped leaking the full webhook URL into prompt text. FixesOpenRouterLabs#992 Agent: security-auditor Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
) Ensures closing a PR also deletes its remote branch, consistent with how gh pr merge already uses --delete-branch. Removes redundant manual git push origin --delete calls that were previously needed. FixesOpenRouterLabs#942 Agent: pr-maintainer Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…OpenRouterLabs#999) Implements 5 missing HOSTKEY matrix entries: - hostkey/nanoclaw - hostkey/aider - hostkey/goose - hostkey/cline - hostkey/continue All scripts follow the standard pattern: 1. Authenticate with HOSTKEY 2. Create server instance 3. Install agent 4. Configure OpenRouter API key injection 5. Launch interactive session Agent: gap-filler Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…ing (OpenRouterLabs#1000) - fly/lib/common.sh: Replace 23-line get_server_name() that duplicated env-var-check, prompt, and validation logic with a one-line call to the shared get_validated_server_name helper, matching all other cloud providers. - oracle/lib/common.sh: Break _setup_vcn_networking (48 lines, 3 distinct responsibilities) into focused helpers: - _create_internet_gateway: creates the IGW resource - _add_default_route: configures the route table - _add_ssh_security_rules: opens SSH port in the security list The orchestrator _setup_vcn_networking now delegates to these three helpers. Agent: complexity-hunter Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Implements CloudSigma matrix entries for openclaw, nanoclaw, interpreter, continue, gemini, and codex. All scripts follow the standard CloudSigma pattern with OpenRouter API key injection. Agent: gap-filler Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…terLabs#1003) - Show list-specific flags (-a, -c, --clear) in unknown flag error - Add specific error for empty prompt files instead of generic validation - Document SPAWN_UNICODE=1 env var in help text and troubleshooting - Show filter/clear hints in interactive list picker Agent: ux-engineer Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Implements Webdock cloud provider with full API integration: - webdock/lib/common.sh with REST API primitives - claude.sh, cline.sh, aider.sh agent scripts - Test coverage in test/record.sh and test/mock.sh - manifest.json updated with cloud entry and matrix - README.md with usage documentation Webdock offers affordable European VPS (€2.15/month starting) with full REST API, SSH access, and developer-friendly features. Agent: cloud-scout-1 Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…#1005) Cover printAgentQuickStart (commands.ts) which has zero test coverage: - Single-auth and multi-auth cloud credential display - URL hint placement (only on first auth var) - All/partial/no credentials detection ("ready to go" vs export lines) - No-auth cloud (auth="none") handling - Agent info header, install line, available clouds listing - Credential prioritization in cloud ordering - Grouped cloud type display and credential indicators - Pure logic replica tests for quick-start computation Agent: test-engineer Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…penRouterLabs#1007) Extract three helpers from the 82-line, 14-conditional function: - _parse_cloud_auths: extract cloud auth specs from manifest.json - _try_load_env_var: load a single env var from env or config file - _load_cloud_credentials: load all env vars for one cloud provider The main function is now a 36-line orchestrator with clear flow: validate prerequisites -> parse manifest -> iterate clouds -> summarize. Agent: complexity-hunter Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
OpenRouterLabs#1004) Extract _get_multi_cred_spec, _load_multi_config_from_file, and _save_multi_config_to_file helpers to eliminate duplicated per-cloud config blocks in try_load_config, save_config, has_credentials, prompt_credentials, and list_clouds. The cloud-to-credential mapping (OVH, UpCloud, Kamatera, AtlanticNet, CloudSigma) is now defined once in _get_multi_cred_spec and consumed by all five functions, making it trivial to add new multi-credential clouds. Agent: complexity-hunter Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rLabs#1009) Tests cover the recently decomposed helper functions from PR OpenRouterLabs#976 (cmdAgentInfo, generic_wait_for_instance) to ensure the refactored helpers maintain correct behavior. Agent: test-engineer Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
…nRouterLabs#1012) - Change 'auth: TOKEN' to 'needs TOKEN' with yellow highlight in spawn clouds - Always show legend footer explaining ready/needs indicators - Add --clear hint to spawn list footer - Show --version/-v and --help/-h aliases in help text - Document SPAWN_UNICODE=1 env var in help - Include HTTP status code in update fetch errors - Bump version to next patch FixesOpenRouterLabs#1010 Agent: issue-fixer Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Adds Alibaba Cloud (Aliyun) ECS provider with 3 initial agent implementations. Provider details: - API: Alibaba Cloud CLI (aliyun ecs commands) - Pricing: Starting at ~$3.50/month for entry-level instances - Regions: Global coverage with strong Asia-Pacific presence - Instance types: Burstable T5 instances for cost-effective compute Implements: claude, codex, gemini Key features: - Automatic CLI installation - VPC and vSwitch auto-creation - Security group configuration with SSH access - Cloud-init support for automated agent setup - Credential persistence in ~/.config/spawn/alibabacloud.json Test coverage: Skipped (CLI-based provider, test infrastructure targets REST APIs) Agent: cloud-scout-2 Co-authored-by: A <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixes two UX issues identified in OpenRouterLabs#1106: 1. Install script: Raw escape codes weren't rendering in log_info - Before: "Run \033[1mspawn\033[0m\033[0;32m to get started\033[0m" - After: Uses printf with proper color variable interpolation 2. Update command: Confusing message after `spawn update` - Before: "Run your spawn command again to use the new version" - After: "Run spawn again to use the new version" - The word "your" implied the user had run some other command, but they explicitly ran `spawn update` Agent: ux-engineer Co-authored-by: Spawn Refactor Service <refactor@spawn.service> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…outerLabs#1116) Extracted ssh-keygen mock creation into _create_ssh_keygen_mock() to simplify setup_mock_agents() from 38 to 13 lines. Extracted validation and response handling in test/record.sh: - _validate_endpoint_response(): handles empty/invalid/error responses - _save_endpoint_fixture(): saves fixture and updates metadata Reduces _record_endpoint() from 43 to 17 lines. Extracted ID extraction and delete response handling: - _extract_resource_id(): extracts ID from create response - _handle_delete_response(): handles fallback for empty delete responses Reduces _live_create_delete_cycle() from 44 to 28 lines. All 79 tests pass. Agent: complexity-hunter Co-authored-by: Spawn Refactor Service <refactor@spawn.service> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…erLabs#1117) When a user tries to spawn an agent on an unimplemented cloud, the error message now shows alternative clouds sorted by credential availability. Clouds where credentials are already set are shown first and marked with "(ready)" to make it obvious which options require no setup. Before: Claude Code is available on 8 clouds. Try one of these instead: spawn claude hetzner spawn claude digitalocean spawn claude sprite After: Claude Code is available on 8 clouds. Try one of these instead: spawn claude sprite (ready) spawn claude hetzner spawn claude digitalocean ready = credentials already set This reduces friction by guiding users toward the path of least resistance when their initial choice isn't available. Agent: ux-engineer Co-authored-by: Spawn Refactor Service <refactor@spawn.service> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…1115) Fixed command injection vulnerability in ssh_run_server() and ssh_interactive_session() by adding double-dash (--) argument separator. Without the -- separator, SSH_OPTS could be exploited if an attacker can control SSH_OPTS environment variable to inject additional SSH arguments like "-o ProxyCommand=..." which would execute arbitrary commands. The -- separator ensures all subsequent arguments are treated as the remote command, not SSH options. Severity: CRITICAL Impact: Remote command execution if SSH_OPTS is attacker-controlled Agent: security-auditor Co-authored-by: Spawn Refactor Service <refactor@spawn.service> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…ck.sh (OpenRouterLabs#1118) Adds missing test infrastructure functions that were previously only in mock-curl-script.sh but required by test-infra-sync.test.ts: - _strip_api_base(): Strips cloud provider API base URLs to extract endpoint paths - _validate_body(): Validates POST request bodies contain required fields for major clouds Fixes test failures in test-infra-sync.test.ts where coverage validation checks rely on these functions being present in test/mock.sh. Agent: test-engineer Co-authored-by: Spawn Refactor Service <refactor@spawn.service> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…terLabs#1119) Extract 60+ line nested case statement in _validate_body() into dedicated _get_required_fields() function using cloud:endpoint pattern matching. Reduces _validate_body() from 93 to 35 lines while improving readability and maintainability. Extract 162-line heredoc from build_team_prompt() into external discovery-team-prompt.txt template file. Reduces function to 6 lines, making discovery.sh more maintainable. All 80 bash tests pass. No functionality change. Co-authored-by: Spawn Refactor Service <refactor@spawn.service> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Agent: ux-engineer Enhance error messages when authentication fails by including direct URLs to the provider's API token page in the remediation steps. Changes: - Updated _validate_token_with_provider() to accept help_url parameter - Updated _validate_multi_credentials() to include help_url in errors - Modified ensure_api_token_with_provider() to pass help_url to validator Users now see the provider dashboard URL immediately when auth fails, reducing friction and eliminating the need to search for token pages. Before: 1. Re-run the command to enter a new token 2. Or set it directly: HCLOUD_TOKEN=your-token spawn ... After: 1. Get a new token from: https://console.hetzner.cloud/projects 2. Re-run the command and paste the new token 3. Or set it directly: HCLOUD_TOKEN=your-token spawn ... Co-authored-by: Spawn Refactor Service <refactor@spawn.service> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…OpenRouterLabs#1123) Break down overly complex functions into smaller, single-purpose helpers: discovery.sh: - Extract _sync_and_setup() from run_team_cycle() for git sync + setup - Extract _launch_claude() to handle process startup - Extract _session_completed() to check session status - Extract _cleanup_cycle_files() for file cleanup - Reduces run_team_cycle() from 71 lines to 39 lines record.sh: - Extract _validate_response_not_empty() for empty check - Extract _validate_response_json() for JSON validation - Extract _validate_response_no_error() for API error checking - Extract _record_fixture_metadata() for metadata recording - Reduces _save_live_fixture() from 34 lines to 15 lines shared/common.sh: - Extract _check_agent_in_path() for PATH verification - Extract _check_agent_runs() for execution verification - Reduces verify_agent_installed() from 32 lines to 11 lines Each helper is focused on one concern, improving maintainability and testability. Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixed 24 failing test assertions by aligning test expectations with actual error message output from the codebase:
- Updated error message strings to match actual implementation (e.g., "What to do" instead of "How to fix")
- Fixed case sensitivity issues ("Report it" vs "report it", "Server is still booting" vs "may still be booting")
- Adjusted assertions to match specific error paths (Network timeout vs Connection refused)
- All 284 tests in these 7 files now pass
Files fixed:
- cli-entry-edge-cases.test.ts: 56 tests
- cmdrun-happy-path.test.ts: 27 tests
- commands-swap-resolve.test.ts: 23 tests
- commands-update-download.test.ts: 17 tests
- download-and-failure.test.ts: 42 tests
- shared-common-ssh-helpers.test.ts: 52 tests
- shared-common-untested-helpers.test.ts: 67 tests
Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>…abs#1127) FixesOpenRouterLabs#1125 and OpenRouterLabs#1114 The upload_config_file() function now creates parent directories before moving config files to paths like ~/.claude/settings.json and ~/.openclaw/openclaw.json. Previously, if these directories didn't exist, the mv command would fail with "No such file or directory" errors. This affected all agents using setup_claude_code_config() and setup_openclaw_config(). Changes: - Extract directory path using dirname - Create parent directories with mkdir -p - Execute chmod and mv in same command chain Agent: ux-engineer Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…nRouterLabs#1128) Extract pattern-matching logic in _strip_api_base() into separate helper functions (_strip_gcore_endpoint, _strip_scaleway_endpoint) to reduce function complexity from 36 lines to organized cases with extracted handlers. Refactor ensure_api_token_with_provider() in shared/common.sh by extracting: - _prompt_for_api_token() handles user prompting - _validate_env_var_name() handles security validation Reduces main function complexity and improves testability. Agent: complexity-hunter Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…penRouterLabs#1131) FixOpenRouterLabs#1114 — `mv` failed because `~/.claude/settings.json` was single-quoted on the remote shell, preventing tilde expansion. Remove the single quotes around remote_path and add a mkdir -p safety net. Also bump the refactor team cron from hourly to every 5 minutes. Co-authored-by: lab <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nRouterLabs#1130) Updated test assertions to reflect refactored helper functions and changed error messages. Key changes: - Fixed atlanticnet security tests to verify ensure_multi_credentials delegation instead of checking implementation details in provider code - Updated shared-common-decomposed-helpers tests to check actual error output messages instead of outdated wording - Fixed shared-github-auth test mocking to properly override command builtin for platform detection - Updated CloudSigma manifest auth field to explicitly mention HTTP Basic Auth Tests now pass with 517/517 success across affected test files. Agent: test-engineer Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…OpenRouterLabs#1132) Extract helper functions to simplify complex control flow: - try_oauth_flow: Extract _start_oauth_session_with_server helper to handle server startup phase, improving readability and testability - _hetzner_resolve_server_type: Extract _hetzner_log_validation_error and _hetzner_log_type_change helpers to separate error handling logic from main flow These changes reduce nesting levels and improve function cohesion while maintaining identical behavior. Agent: complexity-hunter Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…penRouterLabs#1134) Agents were posting redundant comments on issues because dedup checks were soft prompt instructions that agents didn't reliably follow. Strengthens all three team prompts with explicit STRICT DEDUP rules: - security/issue-checker: skip issues entirely if already commented, do label fixes silently without commenting - refactor/community-coordinator: only re-comment to link a new PR or report a concrete resolution, remove interim update instructions - refactor/issue-fixer: check for ANY team's sign-off before posting acknowledgment, not just own team - discovery/issue-responder: skip if already commented unless linking a concrete PR or fix Co-authored-by: lab <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Enhance user-facing error messages with better structure and visual hierarchy: **CLI Error Messages:** - Add bold headers for "Next steps:" and "Possible causes:" sections - Make action items more scannable and directive - Simplify language (e.g., "temporarily" vs "temporarily unavailable") - Reduce redundancy in network error messages **Shell Error Messages:** - Add color-coded section headers (yellow for "Common causes" and "Next steps") - Apply syntax highlighting to commands with CYAN color - Improve readability of multi-step installation instructions - Use bullet points (•) instead of dashes for better visual scanning - Add inline comments to commands (e.g., "# Check disk space") **Impact:** Users experiencing errors will: - Find actionable steps faster with clear visual hierarchy - Copy-paste commands more easily with syntax highlighting - Understand root causes quicker with color-coded sections - Have a better experience during failure scenarios All changes maintain backward compatibility and work across bash 3.x (macOS) and modern bash. Agent: ux-engineer Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…terLabs#1135) * test: fix codesandbox provider pattern tests for helper function indirection Update tests to account for functions that delegate to SDK helpers (_csb_sdk_eval and _csb_run_cmd) rather than directly inlining SDK code. Also add aliyun CLI auth pattern to credential handling test. - Fix codesandbox tests to check for helper calls when patterns aren't direct - Update test_codesandbox_token test to accept "How to fix" variant - Allow interactive_session validation to check via run_server delegation - Fixed: 42 codesandbox failures reduced to 0, 1 alibabacloud failure fixed Agent: test-engineer Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * test: fix alibabacloud provider pattern tests for delegation Update tests to account for alibabacloud delegating to shared SSH functions instead of implementing SSH/SCP directly. Also adjust validation expectations to match actual implementation which uses _aliyun_validate_create_params. - Accept _aliyun_validate_create_params as validation pattern - Update SSH test expectations for ssh_run_server and ssh_interactive_session - Fixed: 6 alibabacloud failures reduced to 0 Agent: test-engineer Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * test: fix new-cloud-provider-patterns codesandbox validation tests Update tests to account for codesandbox delegating to _csb_run_cmd helper and interactive_session delegating to run_server. - Accept _csb_run_cmd as SDK execution pattern - Allow interactive_session validation via run_server delegation - Fixed: 2 codesandbox validation failures reduced to 0 Agent: test-engineer Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…penRouterLabs#1136) Adds a /cleanup-branches skill that deletes local and remote branches with no open PR, and prunes stale worktrees. Supports --dry-run to preview what would be deleted. Protects branches with open PRs. Co-authored-by: lab <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Shorter slash command for branch cleanup. Co-authored-by: lab <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ands.ts (OpenRouterLabs#1138) Extracted helper functions to improve code maintainability: 1. shared/common.sh: - Extracted _prompt_and_validate_api_key() from get_openrouter_api_key_manual() - Simplified API key validation loop and confirmation logic 2. cli/commands.ts: - Extracted selectAgent() from cmdInteractive() for agent selection - Extracted getAndValidateCloudChoices() for cloud validation and prioritization - Extracted selectCloud() for cloud selection UI - Extracted report404Failure() and reportHTTPFailure() from reportDownloadFailure() - Extracted classifyNetworkError(), showTimeoutCauses(), showConnectionCauses(), etc. - Simplified error handling with switch statement in reportDownloadError() These changes reduce cyclomatic complexity and improve testability while preserving all existing functionality. Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Improved the error message when spawn is run without arguments in a non-interactive environment (piped/redirected stdin/stdout). Before: 'No interactive terminal detected.' After: 'Cannot run interactive picker: not a terminal' '(stdin/stdout is piped or redirected)' This makes it clearer why the interactive picker cannot run and what the actual issue is (not just 'detected' but explicitly explaining the stdin/stdout state). Agent: ux-engineer Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…s) (OpenRouterLabs#1140) The mock test assertion was checking for GET /sshkeys but the actual Scaleway API endpoint is /ssh-keys (with a hyphen), causing all 15 scaleway agent tests to fail the "fetches SSH keys" check. Co-authored-by: lab <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…enRouterLabs#1143) Updated failing test cases to match the actual error messages generated by the CLI: - "Cannot run interactive picker: not a terminal" (not "No interactive terminal") - "Try manual installation:" (not "Try the installation manually") - "Retry with a fresh server" (not "Re-run spawn to try") - "installation failed" (not "installation failed to complete successfully") - "Next steps" (not "What to do") - "temporarily unavailable" (not "recovering") Shell tests (80/80) pass. CLI tests improved from 128 failures to 47 failures. Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…ommands.ts) (OpenRouterLabs#1142) - Move exit code conditional logic into EXIT_CODE_GUIDANCE callbacks - Extract buildEnvironmentLines() and buildPromptLines() helpers - Extract buildListFooterLines() to separate formatting from display - Reduces cyclomatic complexity and improves code reusability Agent: complexity-hunter Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
…uterLabs#1146) Automatically closes issues and PRs opened by non-members of the OpenRouterTeam org with an explanatory comment. Co-authored-by: lab <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The default GITHUB_TOKEN lacks issues and pull-requests write access, causing 403 when trying to close issues/PRs from non-org members. Co-authored-by: lab <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Update test expectations to match current UX error messages: - "Cannot run interactive picker" instead of "No interactive terminal" - "Next steps" instead of "What to do" - "experiencing issues" instead of "recovering" - "Firewall or proxy" (capitalized) instead of "firewall or proxy" All affected tests now pass with the current CLI error messages. Agent: ux-engineer Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Bots no longer run on Sprite VMs. Remove all sprite-env checkpoint calls and Sprite-specific comments/docs from automation scripts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sprite-env checkpoint createcalls from discovery.sh, security.sh, and qa-cycle.sh (were already silently failing with|| true)sprite-env checkpointinstruction from refactor.sh promptTest plan
bash -npasses on all 4 modified shell scriptsbash test/run.shpassesgrep -r "sprite-env" .claude/skills/returns zero matches🤖 Generated with Claude Code