Uh oh!
There was an error while loading. Please reload this page.
[ZEPPELIN-1395] Local or Remote Interpreter by Configuration - #1385
Closed
echarles wants to merge 6 commits into
Closed
[ZEPPELIN-1395] Local or Remote Interpreter by Configuration#1385echarles wants to merge 6 commits into
echarles wants to merge 6 commits into
Conversation
jongyoul
commented
Aug 30, 2016
Member
|
…changes to InterpeterSetting method signatures
astroshim
commented
Aug 31, 2016
Contributor
Please fix the CI-fails. |
echarles
commented
Sep 2, 2016
MemberAuthor
@astroshim Thx for the review. I have pushed a fix. |
echarles
commented
Sep 2, 2016
MemberAuthor
@jongyoul |
| * @param o interpreterSetting from interpreterSettingRef | ||
| */ | ||
| public InterpreterSetting(InterpreterSetting o) { | ||
| public InterpreterSetting(InterpreterSetting o, ZeppelinConfiguration conf) { |
Member
There was a problem hiding this comment.
It remains ZeppelinConfiguration. Could you check it again?
Conflicts: zeppelin-web/src/app/interpreter/interpreter.html
MemberAuthor
@jongyoul ZeppelinConfiguration is now also removed on that method. |
asfgit pushed a commit
that referenced
this pull request
May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The current remote interpreter (launched via shell) is scalable and open but suffers from 2 limitations:
A configuration per interpreter "Remote Interpreter" (true/false, true by default) is proposed.
An additional property
zeppeline.interpreter.remote' in zeppelin-site.xml is also proposed (a new interpreter will be created with that value for itoption.remote` attribute).What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
How should this be tested?
Load Zeppelin source in your IDE and start ZeppelinServer in debug mode
Put breakpoints in the interpreter sources, Set / Uset the "Remote Interpeter (see screeenshot).
Screenshots (if appropriate)
Questions: