Skip to content

[ZEPPELIN-1395] Local or Remote Interpreter by Configuration - #1385

Closed
echarles wants to merge 6 commits into
apache:masterfrom
datalayer-attic:remote-interpreter-config
Closed

[ZEPPELIN-1395] Local or Remote Interpreter by Configuration#1385
echarles wants to merge 6 commits into
apache:masterfrom
datalayer-attic:remote-interpreter-config

Conversation

@echarles

Copy link
Copy Markdown
Member

What is this PR for?

The current remote interpreter (launched via shell) is scalable and open but suffers from 2 limitations:

  • It does not allow to easily debug in the IDE.
  • It does not allow to embedd Zeppelin (for small deployements) in a single jar.

A configuration per interpreter "Remote Interpreter" (true/false, true by default) is proposed.
An additional property zeppeline.interpreter.remote' in zeppelin-site.xml is also proposed (a new interpreter will be created with that value for itoption.remote` attribute).

What type of PR is it?

[Improvement]

Todos

  • - Value defined in zeppelin-site.xml is not honored when creating a new interepreter
  • - Unit Test
  • - Documentatoin

What is the Jira issue?

How should this be tested?

Load Zeppelin source in your IDE and start ZeppelinServer in debug mode
Put breakpoints in the interpreter sources, Set / Uset the "Remote Interpeter (see screeenshot).

Screenshots (if appropriate)

animated-gif

Questions:

  • Does the licenses files need update? N
  • Is there breaking changes for older versions? N
  • Does this needs documentation? Y

@jongyoul

Copy link
Copy Markdown
Member

ZeppelinConfiguration has a factory method, thus you don't have to pass it by parameter and you can use ZeppelinConfiguration.create()

…changes to InterpeterSetting method signatures
@astroshim

Copy link
Copy Markdown
Contributor

Please fix the CI-fails.

[INFO] There are 5 checkstyle errors.
[ERROR] InterpreterFactory.java[302] (sizes) LineLength: Line is longer than 100 characters (found 106).
[ERROR] InterpreterFactory.java[327] (sizes) LineLength: Line is longer than 100 characters (found 106).
[ERROR] InterpreterFactory.java[330] (indentation) Indentation: method def child at indentation level 6 not at correct indentation, 4
[ERROR] InterpreterFactory.java[332] (indentation) Indentation: for at indentation level 6 not at correct indentation, 4
[ERROR] InterpreterFactory.java[345] (sizes) LineLength: Line is longer than 100 characters (found 116).

@echarles

Copy link
Copy Markdown
MemberAuthor

@astroshim Thx for the review. I have pushed a fix.

@echarles

Copy link
Copy Markdown
MemberAuthor

@jongyoulZeppelinConfiguration.create() is now used and method signature are now like before.

* @param o interpreterSetting from interpreterSettingRef
*/
public InterpreterSetting(InterpreterSetting o) {
public InterpreterSetting(InterpreterSetting o, ZeppelinConfiguration conf) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It remains ZeppelinConfiguration. Could you check it again?

@echarles

echarles commented Sep 10, 2016

Copy link
Copy Markdown
MemberAuthor

@jongyoul ZeppelinConfiguration is now also removed on that method.

@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@echarles@jongyoul@astroshim