Skip to content

a Js Intepreter, based on Nashorn - #299

Closed
leonardofoderaro wants to merge 10 commits into
apache:masterfrom
leonardofoderaro:js_interpreter
Closed

a Js Intepreter, based on Nashorn#299
leonardofoderaro wants to merge 10 commits into
apache:masterfrom
leonardofoderaro:js_interpreter

Conversation

@leonardofoderaro

Copy link
Copy Markdown

Hi all, I tried to implement my first Zeppelin Interpreter for Javascript. I filled a Jira ticket. Please let me know if I did something wrong (it's my first PR!) - thanks!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to write the exception out to logger.error()

@felixcheung

Copy link
Copy Markdown
Member

Could you please reference the JIRA ticket here?

@bzz

bzz commented Sep 12, 2015

Copy link
Copy Markdown
Member

Great contribution, thank you!
Could you explain a bit what's it for and how user will benefit from it?

Also, all new interpreter PRs should include some docs, so could you please add it to /docs/, more details on how to do that you can find here http://zeppelin.incubator.apache.org/docs/development/howtocontributewebsite.html

@leonardofoderaro

Copy link
Copy Markdown
Author

Thank you all for the feedback. Today I'm a bit busy, I'll work on both the code and the docs in these days. The Jira ticket is this: https://issues.apache.org/jira/browse/ZEPPELIN-300

@bzz

bzz commented Sep 12, 2015

Copy link
Copy Markdown
Member

@leonardofoderaro thank you for prompt response and do not worry, please take your time!
Also it's good practice to put issue number in the name of the PR, like 'ZEPPELIN-300: add Js Intepreter, based on Nashorn', to simplify things for the reviewers.

@corneadoug

Copy link
Copy Markdown
Contributor

@leonardofoderaro
I'm going around old PRs,
Any plan on finishing this one?

@asfgitasfgit closed this in c38a0a0May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close#83close#86close#125close#133close#139close#146close#193close#203close#246close#262close#264close#273close#291close#299close#320close#347close#389close#413close#423close#543close#560close#658close#670close#728close#765close#777close#782close#783close#812close#822close#841close#843close#878close#884close#918close#989close#1076close#1135close#1187close#1231close#1304close#1316close#1361close#1385close#1390close#1414close#1422close#1425close#1447close#1458close#1466close#1485close#1492close#1495close#1497close#1536close#1545close#1561close#1577close#1600close#1603close#1678close#1695close#1739close#1748close#1765close#1767close#1776close#1783close#1799
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@leonardofoderaro@felixcheung@bzz@corneadoug